linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND] memremap: Remove stale comments
@ 2020-03-16 21:32 ira.weiny
  0 siblings, 0 replies; 3+ messages in thread
From: ira.weiny @ 2020-03-16 21:32 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel
  Cc: Ira Weiny, Christoph Hellwig, Jason Gunthorpe, Dan Williams

From: Ira Weiny <ira.weiny@intel.com>

Fixes: 80a72d0af05a ("memremap: remove the data field in struct dev_pagemap")
Fixes: fdc029b19dfd ("memremap: remove the dev field in struct dev_pagemap")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>

---
Resending to Andrew as Jason wanted him to take this:

https://lore.kernel.org/lkml/20200316182121.GL20941@ziepe.ca/

Thanks,
Ira

 include/linux/memremap.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index 6fefb09af7c3..edfd1ec6c165 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -98,8 +98,6 @@ struct dev_pagemap_ops {
  * @ref: reference count that pins the devm_memremap_pages() mapping
  * @internal_ref: internal reference if @ref is not provided by the caller
  * @done: completion for @internal_ref
- * @dev: host device of the mapping for debug
- * @data: private data pointer for page_free()
  * @type: memory type: see MEMORY_* in memory_hotplug.h
  * @flags: PGMAP_* flags to specify defailed behavior
  * @ops: method table
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [RESEND] memremap: Remove stale comments
@ 2020-03-16 17:34 ira.weiny
  2020-03-16 18:21 ` Jason Gunthorpe
  0 siblings, 1 reply; 3+ messages in thread
From: ira.weiny @ 2020-03-16 17:34 UTC (permalink / raw)
  To: Jason Gunthorpe, linux-kernel; +Cc: Dan Williams, Christoph Hellwig, Ira Weiny

From: Ira Weiny <ira.weiny@intel.com>

Fixes: 80a72d0af05a ("memremap: remove the data field in struct dev_pagemap")
Fixes: fdc029b19dfd ("memremap: remove the dev field in struct dev_pagemap")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>

---
Resending as I don't see this picked up in the rdma tree.

Jason I sent this to you as you pulled the patches which dropped the
parameters.  Can you take it?  Or do you want me to send through Andrew?

Thanks,
Ira

 include/linux/memremap.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index 6fefb09af7c3..edfd1ec6c165 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -98,8 +98,6 @@ struct dev_pagemap_ops {
  * @ref: reference count that pins the devm_memremap_pages() mapping
  * @internal_ref: internal reference if @ref is not provided by the caller
  * @done: completion for @internal_ref
- * @dev: host device of the mapping for debug
- * @data: private data pointer for page_free()
  * @type: memory type: see MEMORY_* in memory_hotplug.h
  * @flags: PGMAP_* flags to specify defailed behavior
  * @ops: method table
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-16 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 21:32 [RESEND] memremap: Remove stale comments ira.weiny
  -- strict thread matches above, loose matches on Subject: below --
2020-03-16 17:34 ira.weiny
2020-03-16 18:21 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).