* [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
@ 2020-03-10 13:17 Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 1/3] media: i2c: imx219: Fix power sequence Lad Prabhakar
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Lad Prabhakar @ 2020-03-10 13:17 UTC (permalink / raw)
To: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Lad Prabhakar, Lad Prabhakar
This patch series does the following:
1: Makes sure the sensor is LP11 state on power up
2: Adds support for RAW8
3: Adds support for 640x480 resolution
Changes for v4:
1: Fixed review comments for patch 2/2 as request by Sakari.
Changes for v3:
1: Only patch 3/3 was posted for review.
Changes for v2:
1: Dropped setting the format in probe to coax the sensor to enter LP11
state.
2: Fixed switching between RAW8/RAW10 modes.
3: Fixed fps setting for 640x480 and switched to auto mode.
Lad Prabhakar (3):
media: i2c: imx219: Fix power sequence
media: i2c: imx219: Add support for RAW8 bit bayer format
media: i2c: imx219: Add support for cropped 640x480 resolution
drivers/media/i2c/imx219.c | 235 ++++++++++++++++++++++++++++++++++++++-------
1 file changed, 202 insertions(+), 33 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 1/3] media: i2c: imx219: Fix power sequence
2020-03-10 13:17 [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Lad Prabhakar
@ 2020-03-10 13:17 ` Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 2/3] media: i2c: imx219: Add support for RAW8 bit bayer format Lad Prabhakar
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Lad Prabhakar @ 2020-03-10 13:17 UTC (permalink / raw)
To: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Lad Prabhakar, Lad Prabhakar
When supporting Rpi Camera v2 Module on the RZ/G2E, found the driver had
some issues with rcar mipi-csi driver. The sensor never entered into LP-11
state.
The powerup sequence in the datasheet[1] shows the sensor entering into
LP-11 in streaming mode, so to fix this issue transitions are performed
from "streaming -> standby" in the probe() after power up.
With this commit the sensor is able to enter LP-11 mode during power up,
as expected by some CSI-2 controllers.
[1] https://publiclab.org/system/images/photos/000/023/294/original/
RASPBERRY_PI_CAMERA_V2_DATASHEET_IMX219PQH5_7.0.0_Datasheet_XXX.PDF
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx219.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index f1effb5..16010ca 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -1224,6 +1224,23 @@ static int imx219_probe(struct i2c_client *client)
/* Set default mode to max resolution */
imx219->mode = &supported_modes[0];
+ /* sensor doesn't enter LP-11 state upon power up until and unless
+ * streaming is started, so upon power up switch the modes to:
+ * streaming -> standby
+ */
+ ret = imx219_write_reg(imx219, IMX219_REG_MODE_SELECT,
+ IMX219_REG_VALUE_08BIT, IMX219_MODE_STREAMING);
+ if (ret < 0)
+ goto error_power_off;
+ usleep_range(100, 110);
+
+ /* put sensor back to standby mode */
+ ret = imx219_write_reg(imx219, IMX219_REG_MODE_SELECT,
+ IMX219_REG_VALUE_08BIT, IMX219_MODE_STANDBY);
+ if (ret < 0)
+ goto error_power_off;
+ usleep_range(100, 110);
+
ret = imx219_init_controls(imx219);
if (ret)
goto error_power_off;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4 2/3] media: i2c: imx219: Add support for RAW8 bit bayer format
2020-03-10 13:17 [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 1/3] media: i2c: imx219: Fix power sequence Lad Prabhakar
@ 2020-03-10 13:17 ` Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 3/3] media: i2c: imx219: Add support for cropped 640x480 resolution Lad Prabhakar
2020-03-17 8:01 ` [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Marcus Folkesson
3 siblings, 0 replies; 7+ messages in thread
From: Lad Prabhakar @ 2020-03-10 13:17 UTC (permalink / raw)
To: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Lad Prabhakar, Lad Prabhakar
IMX219 sensor is capable for RAW8/RAW10 modes. This commit adds support
for RAW8 bayer format.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx219.c | 148 +++++++++++++++++++++++++++++++++++----------
1 file changed, 116 insertions(+), 32 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 16010ca..3207487 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -168,15 +168,12 @@ static const struct imx219_reg mode_3280x2464_regs[] = {
{0x0171, 0x01},
{0x0174, 0x00},
{0x0175, 0x00},
- {0x018c, 0x0a},
- {0x018d, 0x0a},
{0x0301, 0x05},
{0x0303, 0x01},
{0x0304, 0x03},
{0x0305, 0x03},
{0x0306, 0x00},
{0x0307, 0x39},
- {0x0309, 0x0a},
{0x030b, 0x01},
{0x030c, 0x00},
{0x030d, 0x72},
@@ -230,15 +227,12 @@ static const struct imx219_reg mode_1920_1080_regs[] = {
{0x0171, 0x01},
{0x0174, 0x00},
{0x0175, 0x00},
- {0x018c, 0x0a},
- {0x018d, 0x0a},
{0x0301, 0x05},
{0x0303, 0x01},
{0x0304, 0x03},
{0x0305, 0x03},
{0x0306, 0x00},
{0x0307, 0x39},
- {0x0309, 0x0a},
{0x030b, 0x01},
{0x030c, 0x00},
{0x030d, 0x72},
@@ -290,15 +284,12 @@ static const struct imx219_reg mode_1640_1232_regs[] = {
{0x0171, 0x01},
{0x0174, 0x01},
{0x0175, 0x01},
- {0x018c, 0x0a},
- {0x018d, 0x0a},
{0x0301, 0x05},
{0x0303, 0x01},
{0x0304, 0x03},
{0x0305, 0x03},
{0x0306, 0x00},
{0x0307, 0x39},
- {0x0309, 0x0a},
{0x030b, 0x01},
{0x030c, 0x00},
{0x030d, 0x72},
@@ -322,6 +313,18 @@ static const struct imx219_reg mode_1640_1232_regs[] = {
{0x0163, 0x78},
};
+static const struct imx219_reg raw8_framefmt_regs[] = {
+ {0x018c, 0x08},
+ {0x018d, 0x08},
+ {0x0309, 0x08},
+};
+
+static const struct imx219_reg raw10_framefmt_regs[] = {
+ {0x018c, 0x0a},
+ {0x018d, 0x0a},
+ {0x0309, 0x0a},
+};
+
static const char * const imx219_test_pattern_menu[] = {
"Disabled",
"Color Bars",
@@ -349,6 +352,27 @@ static const char * const imx219_supply_name[] = {
#define IMX219_NUM_SUPPLIES ARRAY_SIZE(imx219_supply_name)
/*
+ * The supported formats.
+ * This table MUST contain 4 entries per format, to cover the various flip
+ * combinations in the order
+ * - no flip
+ * - h flip
+ * - v flip
+ * - h&v flips
+ */
+static const u32 codes[] = {
+ MEDIA_BUS_FMT_SRGGB10_1X10,
+ MEDIA_BUS_FMT_SGRBG10_1X10,
+ MEDIA_BUS_FMT_SGBRG10_1X10,
+ MEDIA_BUS_FMT_SBGGR10_1X10,
+
+ MEDIA_BUS_FMT_SRGGB8_1X8,
+ MEDIA_BUS_FMT_SGRBG8_1X8,
+ MEDIA_BUS_FMT_SGBRG8_1X8,
+ MEDIA_BUS_FMT_SBGGR8_1X8,
+};
+
+/*
* Initialisation delay between XCLR low->high and the moment when the sensor
* can start capture (i.e. can leave software stanby) must be not less than:
* t4 + max(t5, t6 + <time to initialize the sensor register over I2C>)
@@ -413,6 +437,8 @@ struct imx219 {
struct v4l2_subdev sd;
struct media_pad pad;
+ struct v4l2_mbus_framefmt fmt;
+
struct clk *xclk; /* system clock to IMX219 */
u32 xclk_freq;
@@ -519,19 +545,40 @@ static int imx219_write_regs(struct imx219 *imx219,
}
/* Get bayer order based on flip setting. */
-static u32 imx219_get_format_code(struct imx219 *imx219)
+static u32 imx219_get_format_code(struct imx219 *imx219, u32 code)
{
- /*
- * Only one bayer order is supported.
- * It depends on the flip settings.
- */
- static const u32 codes[2][2] = {
- { MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SGRBG10_1X10, },
- { MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SBGGR10_1X10, },
- };
+ unsigned int i;
lockdep_assert_held(&imx219->mutex);
- return codes[imx219->vflip->val][imx219->hflip->val];
+
+ for (i = 0; i < ARRAY_SIZE(codes); i++)
+ if (codes[i] == code)
+ break;
+
+ if (i >= ARRAY_SIZE(codes))
+ i = 0;
+
+ i = (i & ~3) | (imx219->vflip->val ? 2 : 0) |
+ (imx219->hflip->val ? 1 : 0);
+
+ return codes[i];
+}
+
+static void imx219_set_default_format(struct imx219 *imx219)
+{
+ struct v4l2_mbus_framefmt *fmt;
+
+ fmt = &imx219->fmt;
+ fmt->code = MEDIA_BUS_FMT_SRGGB10_1X10;
+ fmt->colorspace = V4L2_COLORSPACE_SRGB;
+ fmt->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(fmt->colorspace);
+ fmt->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
+ fmt->colorspace,
+ fmt->ycbcr_enc);
+ fmt->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(fmt->colorspace);
+ fmt->width = supported_modes[0].width;
+ fmt->height = supported_modes[0].height;
+ fmt->field = V4L2_FIELD_NONE;
}
static int imx219_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
@@ -545,7 +592,8 @@ static int imx219_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
/* Initialize try_fmt */
try_fmt->width = supported_modes[0].width;
try_fmt->height = supported_modes[0].height;
- try_fmt->code = imx219_get_format_code(imx219);
+ try_fmt->code = imx219_get_format_code(imx219,
+ MEDIA_BUS_FMT_SRGGB10_1X10);
try_fmt->field = V4L2_FIELD_NONE;
mutex_unlock(&imx219->mutex);
@@ -648,14 +696,10 @@ static int imx219_enum_mbus_code(struct v4l2_subdev *sd,
{
struct imx219 *imx219 = to_imx219(sd);
- /*
- * Only one bayer order is supported (though it depends on the flip
- * settings)
- */
- if (code->index > 0)
+ if (code->index >= (ARRAY_SIZE(codes) / 4))
return -EINVAL;
- code->code = imx219_get_format_code(imx219);
+ code->code = imx219_get_format_code(imx219, codes[code->index * 4]);
return 0;
}
@@ -669,7 +713,7 @@ static int imx219_enum_frame_size(struct v4l2_subdev *sd,
if (fse->index >= ARRAY_SIZE(supported_modes))
return -EINVAL;
- if (fse->code != imx219_get_format_code(imx219))
+ if (fse->code != imx219_get_format_code(imx219, imx219->fmt.code))
return -EINVAL;
fse->min_width = supported_modes[fse->index].width;
@@ -696,9 +740,7 @@ static void imx219_update_pad_format(struct imx219 *imx219,
{
fmt->format.width = mode->width;
fmt->format.height = mode->height;
- fmt->format.code = imx219_get_format_code(imx219);
fmt->format.field = V4L2_FIELD_NONE;
-
imx219_reset_colorspace(&fmt->format);
}
@@ -710,10 +752,12 @@ static int __imx219_get_pad_format(struct imx219 *imx219,
struct v4l2_mbus_framefmt *try_fmt =
v4l2_subdev_get_try_format(&imx219->sd, cfg, fmt->pad);
/* update the code which could change due to vflip or hflip: */
- try_fmt->code = imx219_get_format_code(imx219);
+ try_fmt->code = imx219_get_format_code(imx219, try_fmt->code);
fmt->format = *try_fmt;
} else {
imx219_update_pad_format(imx219, imx219->mode, fmt);
+ fmt->format.code = imx219_get_format_code(imx219,
+ imx219->fmt.code);
}
return 0;
@@ -741,11 +785,18 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
const struct imx219_mode *mode;
struct v4l2_mbus_framefmt *framefmt;
int exposure_max, exposure_def, hblank;
+ unsigned int i;
mutex_lock(&imx219->mutex);
+ for (i = 0; i < ARRAY_SIZE(codes); i++)
+ if (codes[i] == fmt->format.code)
+ break;
+ if (i >= ARRAY_SIZE(codes))
+ i = 0;
+
/* Bayer order varies with flips */
- fmt->format.code = imx219_get_format_code(imx219);
+ fmt->format.code = imx219_get_format_code(imx219, codes[i]);
mode = v4l2_find_nearest_size(supported_modes,
ARRAY_SIZE(supported_modes),
@@ -755,7 +806,9 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
*framefmt = fmt->format;
- } else if (imx219->mode != mode) {
+ } else if (imx219->mode != mode ||
+ imx219->fmt.code != fmt->format.code) {
+ imx219->fmt = fmt->format;
imx219->mode = mode;
/* Update limits and set FPS to default */
__v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN,
@@ -786,6 +839,27 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
return 0;
}
+static int imx219_set_framefmt(struct imx219 *imx219)
+{
+ switch (imx219->fmt.code) {
+ case MEDIA_BUS_FMT_SRGGB8_1X8:
+ case MEDIA_BUS_FMT_SGRBG8_1X8:
+ case MEDIA_BUS_FMT_SGBRG8_1X8:
+ case MEDIA_BUS_FMT_SBGGR8_1X8:
+ return imx219_write_regs(imx219, raw8_framefmt_regs,
+ ARRAY_SIZE(raw8_framefmt_regs));
+
+ case MEDIA_BUS_FMT_SRGGB10_1X10:
+ case MEDIA_BUS_FMT_SGRBG10_1X10:
+ case MEDIA_BUS_FMT_SGBRG10_1X10:
+ case MEDIA_BUS_FMT_SBGGR10_1X10:
+ return imx219_write_regs(imx219, raw10_framefmt_regs,
+ ARRAY_SIZE(raw10_framefmt_regs));
+ }
+
+ return -EINVAL;
+}
+
static int imx219_start_streaming(struct imx219 *imx219)
{
struct i2c_client *client = v4l2_get_subdevdata(&imx219->sd);
@@ -800,6 +874,13 @@ static int imx219_start_streaming(struct imx219 *imx219)
return ret;
}
+ ret = imx219_set_framefmt(imx219);
+ if (ret) {
+ dev_err(&client->dev, "%s failed to set frame format: %d\n",
+ __func__, ret);
+ return ret;
+ }
+
/* Apply customized values from user */
ret = __v4l2_ctrl_handler_setup(imx219->sd.ctrl_handler);
if (ret)
@@ -1253,6 +1334,9 @@ static int imx219_probe(struct i2c_client *client)
/* Initialize source pad */
imx219->pad.flags = MEDIA_PAD_FL_SOURCE;
+ /* Initialize default format */
+ imx219_set_default_format(imx219);
+
ret = media_entity_pads_init(&imx219->sd.entity, 1, &imx219->pad);
if (ret) {
dev_err(dev, "failed to init entity pads: %d\n", ret);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4 3/3] media: i2c: imx219: Add support for cropped 640x480 resolution
2020-03-10 13:17 [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 1/3] media: i2c: imx219: Fix power sequence Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 2/3] media: i2c: imx219: Add support for RAW8 bit bayer format Lad Prabhakar
@ 2020-03-10 13:17 ` Lad Prabhakar
2020-03-17 8:01 ` [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Marcus Folkesson
3 siblings, 0 replies; 7+ messages in thread
From: Lad Prabhakar @ 2020-03-10 13:17 UTC (permalink / raw)
To: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Lad Prabhakar, Lad Prabhakar
This patch adds mode table entry for capturing cropped 640x480 resolution
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx219.c | 70 +++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 69 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 3207487..cb03bde 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -54,6 +54,7 @@
#define IMX219_VTS_15FPS 0x0dc6
#define IMX219_VTS_30FPS_1080P 0x06e3
#define IMX219_VTS_30FPS_BINNED 0x06e3
+#define IMX219_VTS_30FPS_640x480 0x06e3
#define IMX219_VTS_MAX 0xffff
#define IMX219_VBLANK_MIN 4
@@ -138,7 +139,7 @@ struct imx219_mode {
/*
* Register sets lifted off the i2C interface from the Raspberry Pi firmware
* driver.
- * 3280x2464 = mode 2, 1920x1080 = mode 1, and 1640x1232 = mode 4.
+ * 3280x2464 = mode 2, 1920x1080 = mode 1, 1640x1232 = mode 4, 640x480 = mode 7.
*/
static const struct imx219_reg mode_3280x2464_regs[] = {
{0x0100, 0x00},
@@ -313,6 +314,63 @@ static const struct imx219_reg mode_1640_1232_regs[] = {
{0x0163, 0x78},
};
+static const struct imx219_reg mode_640_480_regs[] = {
+ {0x0100, 0x00},
+ {0x30eb, 0x05},
+ {0x30eb, 0x0c},
+ {0x300a, 0xff},
+ {0x300b, 0xff},
+ {0x30eb, 0x05},
+ {0x30eb, 0x09},
+ {0x0114, 0x01},
+ {0x0128, 0x00},
+ {0x012a, 0x18},
+ {0x012b, 0x00},
+ {0x0162, 0x0d},
+ {0x0163, 0x78},
+ {0x0164, 0x03},
+ {0x0165, 0xe8},
+ {0x0166, 0x08},
+ {0x0167, 0xe7},
+ {0x0168, 0x02},
+ {0x0169, 0xf0},
+ {0x016a, 0x06},
+ {0x016b, 0xaf},
+ {0x016c, 0x02},
+ {0x016d, 0x80},
+ {0x016e, 0x01},
+ {0x016f, 0xe0},
+ {0x0170, 0x01},
+ {0x0171, 0x01},
+ {0x0174, 0x03},
+ {0x0175, 0x03},
+ {0x0301, 0x05},
+ {0x0303, 0x01},
+ {0x0304, 0x03},
+ {0x0305, 0x03},
+ {0x0306, 0x00},
+ {0x0307, 0x39},
+ {0x030b, 0x01},
+ {0x030c, 0x00},
+ {0x030d, 0x72},
+ {0x0624, 0x06},
+ {0x0625, 0x68},
+ {0x0626, 0x04},
+ {0x0627, 0xd0},
+ {0x455e, 0x00},
+ {0x471e, 0x4b},
+ {0x4767, 0x0f},
+ {0x4750, 0x14},
+ {0x4540, 0x00},
+ {0x47b4, 0x14},
+ {0x4713, 0x30},
+ {0x478b, 0x10},
+ {0x478f, 0x10},
+ {0x4793, 0x10},
+ {0x4797, 0x0e},
+ {0x479b, 0x0e},
+};
+
static const struct imx219_reg raw8_framefmt_regs[] = {
{0x018c, 0x08},
{0x018d, 0x08},
@@ -431,6 +489,16 @@ static const struct imx219_mode supported_modes[] = {
.regs = mode_1640_1232_regs,
},
},
+ {
+ /* 640x480 30fps mode */
+ .width = 640,
+ .height = 480,
+ .vts_def = IMX219_VTS_30FPS_640x480,
+ .reg_list = {
+ .num_of_regs = ARRAY_SIZE(mode_640_480_regs),
+ .regs = mode_640_480_regs,
+ },
+ },
};
struct imx219 {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
2020-03-10 13:17 [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Lad Prabhakar
` (2 preceding siblings ...)
2020-03-10 13:17 ` [PATCH v4 3/3] media: i2c: imx219: Add support for cropped 640x480 resolution Lad Prabhakar
@ 2020-03-17 8:01 ` Marcus Folkesson
2020-03-17 8:03 ` Prabhakar Mahadev Lad
3 siblings, 1 reply; 7+ messages in thread
From: Marcus Folkesson @ 2020-03-17 8:01 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab, linux-media,
linux-kernel, Lad Prabhakar
Hi,
To which tree does this patchset apply?
On Tue, Mar 10, 2020 at 01:17:06PM +0000, Lad Prabhakar wrote:
> This patch series does the following:
> 1: Makes sure the sensor is LP11 state on power up
> 2: Adds support for RAW8
> 3: Adds support for 640x480 resolution
>
> Changes for v4:
> 1: Fixed review comments for patch 2/2 as request by Sakari.
>
> Changes for v3:
> 1: Only patch 3/3 was posted for review.
>
> Changes for v2:
> 1: Dropped setting the format in probe to coax the sensor to enter LP11
> state.
> 2: Fixed switching between RAW8/RAW10 modes.
> 3: Fixed fps setting for 640x480 and switched to auto mode.
>
> Lad Prabhakar (3):
> media: i2c: imx219: Fix power sequence
> media: i2c: imx219: Add support for RAW8 bit bayer format
> media: i2c: imx219: Add support for cropped 640x480 resolution
>
> drivers/media/i2c/imx219.c | 235 ++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 202 insertions(+), 33 deletions(-)
>
> --
> 2.7.4
>
Thanks,
Marcus Folkesson
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
2020-03-17 8:01 ` [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Marcus Folkesson
@ 2020-03-17 8:03 ` Prabhakar Mahadev Lad
2020-03-17 8:11 ` Marcus Folkesson
0 siblings, 1 reply; 7+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-03-17 8:03 UTC (permalink / raw)
To: Marcus Folkesson
Cc: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab, linux-media,
linux-kernel, Lad Prabhakar
Hi Marcus,
> -----Original Message-----
> From: Marcus Folkesson <marcus.folkesson@gmail.com>
> Sent: 17 March 2020 08:02
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>; Sakari Ailus
> <sakari.ailus@linux.intel.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; Lad Prabhakar <prabhakar.csengg@gmail.com>
> Subject: Re: [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
>
> Hi,
>
> To which tree does this patchset apply?
>
These patches apply to media_tree [1], btw v4 patches have been accepted and merged into master branch of media_tree.
[1] https://git.linuxtv.org//media_tree.git
Cheers,
--Prabhakar
> On Tue, Mar 10, 2020 at 01:17:06PM +0000, Lad Prabhakar wrote:
> > This patch series does the following:
> > 1: Makes sure the sensor is LP11 state on power up
> > 2: Adds support for RAW8
> > 3: Adds support for 640x480 resolution
> >
> > Changes for v4:
> > 1: Fixed review comments for patch 2/2 as request by Sakari.
> >
> > Changes for v3:
> > 1: Only patch 3/3 was posted for review.
> >
> > Changes for v2:
> > 1: Dropped setting the format in probe to coax the sensor to enter LP11
> > state.
> > 2: Fixed switching between RAW8/RAW10 modes.
> > 3: Fixed fps setting for 640x480 and switched to auto mode.
> >
> > Lad Prabhakar (3):
> > media: i2c: imx219: Fix power sequence
> > media: i2c: imx219: Add support for RAW8 bit bayer format
> > media: i2c: imx219: Add support for cropped 640x480 resolution
> >
> > drivers/media/i2c/imx219.c | 235
> ++++++++++++++++++++++++++++++++++++++-------
> > 1 file changed, 202 insertions(+), 33 deletions(-)
> >
> > --
> > 2.7.4
> >
>
>
> Thanks,
> Marcus Folkesson
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
2020-03-17 8:03 ` Prabhakar Mahadev Lad
@ 2020-03-17 8:11 ` Marcus Folkesson
0 siblings, 0 replies; 7+ messages in thread
From: Marcus Folkesson @ 2020-03-17 8:11 UTC (permalink / raw)
To: Prabhakar Mahadev Lad
Cc: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab, linux-media,
linux-kernel, Lad Prabhakar
Hi Prabhakar,
On Tue, Mar 17, 2020 at 08:03:49AM +0000, Prabhakar Mahadev Lad wrote:
> Hi Marcus,
>
> > -----Original Message-----
> > From: Marcus Folkesson <marcus.folkesson@gmail.com>
> > Sent: 17 March 2020 08:02
> > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>; Sakari Ailus
> > <sakari.ailus@linux.intel.com>; Mauro Carvalho Chehab
> > <mchehab@kernel.org>; linux-media@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Lad Prabhakar <prabhakar.csengg@gmail.com>
> > Subject: Re: [PATCH v4 0/3] media: i2c: imx219: Feature enhancements
> >
> > Hi,
> >
> > To which tree does this patchset apply?
> >
> These patches apply to media_tree [1], btw v4 patches have been accepted and merged into master branch of media_tree.
Thank you and good work!
>
> [1] https://git.linuxtv.org//media_tree.git
>
> Cheers,
> --Prabhakar
Best regards
Marcus Folkesson
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-17 8:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 13:17 [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 1/3] media: i2c: imx219: Fix power sequence Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 2/3] media: i2c: imx219: Add support for RAW8 bit bayer format Lad Prabhakar
2020-03-10 13:17 ` [PATCH v4 3/3] media: i2c: imx219: Add support for cropped 640x480 resolution Lad Prabhakar
2020-03-17 8:01 ` [PATCH v4 0/3] media: i2c: imx219: Feature enhancements Marcus Folkesson
2020-03-17 8:03 ` Prabhakar Mahadev Lad
2020-03-17 8:11 ` Marcus Folkesson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).