* [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value
@ 2020-03-17 4:54 Rayagonda Kokatanur
2020-03-17 9:29 ` Andrew Lunn
2020-03-18 4:21 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-17 4:54 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Russell King,
davem, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Arun Parameswaran, netdev, linux-arm-kernel, linux-kernel
Cc: Rayagonda Kokatanur
Check clk_prepare_enable() return value.
Fixes: 2c7230446bc9 ("net: phy: Add pm support to Broadcom iProc mdio mux driver")
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
drivers/net/phy/mdio-mux-bcm-iproc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 88d409e48c1f..aad6809ebe39 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -288,8 +288,13 @@ static int mdio_mux_iproc_suspend(struct device *dev)
static int mdio_mux_iproc_resume(struct device *dev)
{
struct iproc_mdiomux_desc *md = dev_get_drvdata(dev);
+ int rc;
- clk_prepare_enable(md->core_clk);
+ rc = clk_prepare_enable(md->core_clk);
+ if (rc) {
+ dev_err(md->dev, "failed to enable core clk\n");
+ return rc;
+ }
mdio_mux_iproc_config(md);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value
2020-03-17 4:54 [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value Rayagonda Kokatanur
@ 2020-03-17 9:29 ` Andrew Lunn
2020-03-18 4:21 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-03-17 9:29 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Florian Fainelli, Heiner Kallweit, Russell King, davem, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, Arun Parameswaran,
netdev, linux-arm-kernel, linux-kernel
On Tue, Mar 17, 2020 at 10:24:35AM +0530, Rayagonda Kokatanur wrote:
> Check clk_prepare_enable() return value.
>
> Fixes: 2c7230446bc9 ("net: phy: Add pm support to Broadcom iProc mdio mux driver")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value
2020-03-17 4:54 [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value Rayagonda Kokatanur
2020-03-17 9:29 ` Andrew Lunn
@ 2020-03-18 4:21 ` David Miller
2020-03-18 4:23 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-03-18 4:21 UTC (permalink / raw)
To: rayagonda.kokatanur
Cc: andrew, f.fainelli, hkallweit1, linux, rjui, sbranden,
bcm-kernel-feedback-list, arun.parameswaran, netdev,
linux-arm-kernel, linux-kernel
From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Date: Tue, 17 Mar 2020 10:24:35 +0530
> Check clk_prepare_enable() return value.
>
> Fixes: 2c7230446bc9 ("net: phy: Add pm support to Broadcom iProc mdio mux driver")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value
2020-03-18 4:21 ` David Miller
@ 2020-03-18 4:23 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-18 4:23 UTC (permalink / raw)
To: rayagonda.kokatanur
Cc: andrew, f.fainelli, hkallweit1, linux, rjui, sbranden,
bcm-kernel-feedback-list, arun.parameswaran, netdev,
linux-arm-kernel, linux-kernel
From: David Miller <davem@davemloft.net>
Date: Tue, 17 Mar 2020 21:21:27 -0700 (PDT)
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Date: Tue, 17 Mar 2020 10:24:35 +0530
>
>> Check clk_prepare_enable() return value.
>>
>> Fixes: 2c7230446bc9 ("net: phy: Add pm support to Broadcom iProc mdio mux driver")
>> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> Applied.
I also queued this up for -stable as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-18 4:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 4:54 [PATCH v1 1/1] net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value Rayagonda Kokatanur
2020-03-17 9:29 ` Andrew Lunn
2020-03-18 4:21 ` David Miller
2020-03-18 4:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).