From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
Cezary Rojewski <cezary.rojewski@intel.com>,
kuninori.morimoto.gx@renesas.com,
Keyon Jie <yang.jie@linux.intel.com>,
alsa-devel@alsa-project.org, curtis@malainey.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
liam.r.girdwood@linux.intel.com
Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1
Date: Thu, 19 Mar 2020 17:35:02 +0000 [thread overview]
Message-ID: <20200319173502.GC3983@sirena.org.uk> (raw)
In-Reply-To: <eef45d20-3bce-184a-842c-216c15252014@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Thu, Mar 19, 2020 at 12:21:47PM -0500, Pierre-Louis Bossart wrote:
> On 3/19/20 11:51 AM, Dominik Brodowski wrote:
> > That patch fixes the issue(s). I didn't even need to revert 64df6afa0dab
> > ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF")
> > on top of that. But you can assess better whether that patch needs care for
> > other reasons; for me, this one-liner you have suggested is perfect.
Good news!
> .ignore_suspend is set for bdw-rt5677.c and bdw-rt5650.c as well. I don't
> know if that was intentional.
The intended use case is for applications doing audio during suspend
like telephony audio between the modem and CODEC on a phone or
compressed audio playback. I guess the compressed audio playback case
could possibly apply with these systems though x86 suspend/resume is
usually sufficiently heavyweight that it's surprising.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-19 17:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 6:30 snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 Dominik Brodowski
2020-03-18 9:41 ` Cezary Rojewski
2020-03-18 9:57 ` Dominik Brodowski
2020-03-18 10:05 ` Cezary Rojewski
2020-03-18 10:19 ` Dominik Brodowski
2020-03-18 10:49 ` Keyon Jie
2020-03-18 12:39 ` Dominik Brodowski
2020-03-18 15:13 ` Pierre-Louis Bossart
2020-03-18 16:20 ` Dominik Brodowski
2020-03-18 17:08 ` Pierre-Louis Bossart
2020-03-18 17:19 ` Dominik Brodowski
2020-03-18 17:29 ` Pierre-Louis Bossart
2020-03-18 17:35 ` Cezary Rojewski
[not found] ` <CAOReqxjmUCGX18y_XW_sjcU2xWha_+wJ7L+SuzJ5ZrOddCfZkw@mail.gmail.com>
2020-03-18 19:13 ` Ross Zwisler
2020-03-18 18:27 ` Cezary Rojewski
2020-03-18 19:22 ` Dominik Brodowski
2020-03-18 20:43 ` Cezary Rojewski
2020-03-18 21:52 ` Dominik Brodowski
2020-03-18 22:20 ` Cezary Rojewski
2020-03-19 13:00 ` Dominik Brodowski
2020-03-19 13:17 ` Cezary Rojewski
2020-03-19 13:41 ` Mark Brown
2020-03-19 15:48 ` Cezary Rojewski
2020-03-19 16:51 ` Dominik Brodowski
2020-03-19 17:21 ` Pierre-Louis Bossart
2020-03-19 17:35 ` Mark Brown [this message]
2020-03-20 3:21 ` Keyon Jie
2020-03-19 17:41 ` Cezary Rojewski
2020-03-19 17:33 ` Cezary Rojewski
2020-03-19 17:45 ` Cezary Rojewski
2020-03-19 18:24 ` Dominik Brodowski
2020-03-19 18:35 ` Cezary Rojewski
2020-03-19 19:05 ` Pierre-Louis Bossart
2020-03-30 10:23 ` Dominik Brodowski
2020-03-30 11:10 ` Cezary Rojewski
2020-03-30 11:39 ` Mark Brown
2020-03-30 15:37 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319173502.GC3983@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=curtis@malainey.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).