* [PATCH] ARM: dts: oxnas: Fix clear-mask property
@ 2020-03-21 14:36 Sungbo Eo
2020-03-22 13:05 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Sungbo Eo @ 2020-03-21 14:36 UTC (permalink / raw)
To: Neil Armstrong, Rob Herring, Mark Rutland, linux-arm-kernel,
linux-oxnas, devicetree, linux-kernel
Cc: Sungbo Eo
Disable all rps-irq interrupts during driver initialization to prevent
an accidental interrupt on GIC.
Fixes: 84316f4ef141 ("ARM: boot: dts: Add Oxford Semiconductor OX810SE dtsi")
Fixes: 38d4a53733f5 ("ARM: dts: Add support for OX820 and Pogoplug V3")
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
---
arch/arm/boot/dts/ox810se.dtsi | 4 ++--
arch/arm/boot/dts/ox820.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/ox810se.dtsi b/arch/arm/boot/dts/ox810se.dtsi
index 9f6c2b660ed3..0755e5864c4a 100644
--- a/arch/arm/boot/dts/ox810se.dtsi
+++ b/arch/arm/boot/dts/ox810se.dtsi
@@ -323,8 +323,8 @@ intc: interrupt-controller@0 {
interrupt-controller;
reg = <0 0x200>;
#interrupt-cells = <1>;
- valid-mask = <0xFFFFFFFF>;
- clear-mask = <0>;
+ valid-mask = <0xffffffff>;
+ clear-mask = <0xffffffff>;
};
timer0: timer@200 {
diff --git a/arch/arm/boot/dts/ox820.dtsi b/arch/arm/boot/dts/ox820.dtsi
index c9b327732063..90846a7655b4 100644
--- a/arch/arm/boot/dts/ox820.dtsi
+++ b/arch/arm/boot/dts/ox820.dtsi
@@ -240,8 +240,8 @@ intc: interrupt-controller@0 {
reg = <0 0x200>;
interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
#interrupt-cells = <1>;
- valid-mask = <0xFFFFFFFF>;
- clear-mask = <0>;
+ valid-mask = <0xffffffff>;
+ clear-mask = <0xffffffff>;
};
timer0: timer@200 {
--
2.25.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: oxnas: Fix clear-mask property
2020-03-21 14:36 [PATCH] ARM: dts: oxnas: Fix clear-mask property Sungbo Eo
@ 2020-03-22 13:05 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2020-03-22 13:05 UTC (permalink / raw)
To: Sungbo Eo, Rob Herring, Mark Rutland, linux-arm-kernel,
linux-oxnas, devicetree, linux-kernel
Hi,
Le 21/03/2020 à 15:36, Sungbo Eo a écrit :
> Disable all rps-irq interrupts during driver initialization to prevent
> an accidental interrupt on GIC.
>
> Fixes: 84316f4ef141 ("ARM: boot: dts: Add Oxford Semiconductor OX810SE dtsi")
> Fixes: 38d4a53733f5 ("ARM: dts: Add support for OX820 and Pogoplug V3")
> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
> ---
> arch/arm/boot/dts/ox810se.dtsi | 4 ++--
> arch/arm/boot/dts/ox820.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ox810se.dtsi b/arch/arm/boot/dts/ox810se.dtsi
> index 9f6c2b660ed3..0755e5864c4a 100644
> --- a/arch/arm/boot/dts/ox810se.dtsi
> +++ b/arch/arm/boot/dts/ox810se.dtsi
> @@ -323,8 +323,8 @@ intc: interrupt-controller@0 {
> interrupt-controller;
> reg = <0 0x200>;
> #interrupt-cells = <1>;
> - valid-mask = <0xFFFFFFFF>;
> - clear-mask = <0>;
> + valid-mask = <0xffffffff>;
> + clear-mask = <0xffffffff>;
> };
>
> timer0: timer@200 {
> diff --git a/arch/arm/boot/dts/ox820.dtsi b/arch/arm/boot/dts/ox820.dtsi
> index c9b327732063..90846a7655b4 100644
> --- a/arch/arm/boot/dts/ox820.dtsi
> +++ b/arch/arm/boot/dts/ox820.dtsi
> @@ -240,8 +240,8 @@ intc: interrupt-controller@0 {
> reg = <0 0x200>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> #interrupt-cells = <1>;
> - valid-mask = <0xFFFFFFFF>;
> - clear-mask = <0>;
> + valid-mask = <0xffffffff>;
> + clear-mask = <0xffffffff>;
> };
>
> timer0: timer@200 {
>
Thanks a lot for the patch,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
I'll apply it asap and push it to arm-soc fixes.
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-22 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-21 14:36 [PATCH] ARM: dts: oxnas: Fix clear-mask property Sungbo Eo
2020-03-22 13:05 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).