* [RFC,net-next,v1, 0/1] Enable SERDES power up/down @ 2020-03-22 13:23 Voon Weifeng 2020-03-22 13:23 ` [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence Voon Weifeng 0 siblings, 1 reply; 8+ messages in thread From: Voon Weifeng @ 2020-03-22 13:23 UTC (permalink / raw) To: David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Jose Abreu, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong Boon Leong, Voon Weifeng This patch is to enable Intel SERDES power up/down sequence. The SERDES converts 8/10 bits data to SGMII signal. 1. Two new files intel_serdes.c and intel.h have been created to include the power up/down logic. 2. Platform data has_serdes is created to identify HW system that requires SERDES for SGMII mode. Expecting all Intel HW system will require it. The identification logic is added in hwif. 3. A new stmmac_serdes_ops struct is introduced as helpers to program SERDES. Voon Weifeng (1): net: stmmac: Enable SERDES power up/down sequence drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 1 + drivers/net/ethernet/stmicro/stmmac/hwif.c | 44 ++++- drivers/net/ethernet/stmicro/stmmac/hwif.h | 12 ++ .../ethernet/stmicro/stmmac/intel_serdes.c | 181 ++++++++++++++++++ .../ethernet/stmicro/stmmac/intel_serdes.h | 23 +++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 8 + .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 6 + include/linux/stmmac.h | 2 + 10 files changed, 278 insertions(+), 2 deletions(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/intel_serdes.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/intel_serdes.h -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-22 13:23 [RFC,net-next,v1, 0/1] Enable SERDES power up/down Voon Weifeng @ 2020-03-22 13:23 ` Voon Weifeng 2020-03-23 7:46 ` Jose Abreu 0 siblings, 1 reply; 8+ messages in thread From: Voon Weifeng @ 2020-03-22 13:23 UTC (permalink / raw) To: David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Jose Abreu, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong Boon Leong, Voon Weifeng This patch is to enable Intel SERDES power up/down sequence. The SERDES converts 8/10 bits data to SGMII signal. Below is an example of HW configuration for SGMII mode. The SERDES is located in the PHY IF in the diagram below. <-----------------GBE Controller---------->|<--External PHY chip--> +----------+ +----+ +---+ +----------+ | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | External | | MAC | |xPCS| |IF | | PHY | +----------+ +----+ +---+ +----------+ ^ ^ ^ ^ | | | | +---------------------MDIO-------------------------+ PHY IF configuration and status registers are accessible through mdio address 0x15 which is defined as intel_adhoc_addr. During D0, The driver will need to power up PHY IF by changing the power state to P0. Likewise, for D3, the driver sets PHY IF power state to P3. Signed-off-by: Voon Weifeng <weifeng.voon@intel.com> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> --- drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 1 + drivers/net/ethernet/stmicro/stmmac/hwif.c | 44 ++++- drivers/net/ethernet/stmicro/stmmac/hwif.h | 12 ++ .../ethernet/stmicro/stmmac/intel_serdes.c | 181 ++++++++++++++++++ .../ethernet/stmicro/stmmac/intel_serdes.h | 23 +++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 8 + .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 6 + include/linux/stmmac.h | 2 + 10 files changed, 278 insertions(+), 2 deletions(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/intel_serdes.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/intel_serdes.h diff --git a/drivers/net/ethernet/stmicro/stmmac/Makefile b/drivers/net/ethernet/stmicro/stmmac/Makefile index c59926d96bcc..3230d2673cb5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Makefile +++ b/drivers/net/ethernet/stmicro/stmmac/Makefile @@ -6,7 +6,7 @@ stmmac-objs:= stmmac_main.o stmmac_ethtool.o stmmac_mdio.o ring_mode.o \ mmc_core.o stmmac_hwtstamp.o stmmac_ptp.o dwmac4_descs.o \ dwmac4_dma.o dwmac4_lib.o dwmac4_core.o dwmac5.o hwif.o \ stmmac_tc.o dwxgmac2_core.o dwxgmac2_dma.o dwxgmac2_descs.o \ - $(stmmac-y) + intel_serdes.o $(stmmac-y) stmmac-$(CONFIG_STMMAC_SELFTESTS) += stmmac_selftests.o diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 386663208c23..2840867279a6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -452,6 +452,7 @@ struct mii_regs { struct mac_device_info { const struct stmmac_ops *mac; + const struct stmmac_serdes_ops *serdes; const struct stmmac_desc_ops *desc; const struct stmmac_dma_ops *dma; const struct stmmac_mode_ops *mode; diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index dc09d2131e40..8e772fe9d048 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -17,6 +17,7 @@ #include <net/dsa.h> #include "stmmac.h" #include "stmmac_pcs.h" +#include "intel_serdes.h" #include "dwmac4.h" #include "dwmac5.h" diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c index bb7114f970f8..817c9c1255a5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c @@ -91,12 +91,14 @@ static const struct stmmac_hwif_entry { bool gmac; bool gmac4; bool xgmac; + bool has_serdes; u32 min_id; u32 dev_id; const struct stmmac_regs_off regs; const void *desc; const void *dma; const void *mac; + const void *serdes; const void *hwtimestamp; const void *mode; const void *tc; @@ -109,6 +111,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = false, .xgmac = false, + .has_serdes = false, .min_id = 0, .regs = { .ptp_off = PTP_GMAC3_X_OFFSET, @@ -117,6 +120,7 @@ static const struct stmmac_hwif_entry { .desc = NULL, .dma = &dwmac100_dma_ops, .mac = &dwmac100_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = NULL, .tc = NULL, @@ -127,6 +131,7 @@ static const struct stmmac_hwif_entry { .gmac = true, .gmac4 = false, .xgmac = false, + .has_serdes = false, .min_id = 0, .regs = { .ptp_off = PTP_GMAC3_X_OFFSET, @@ -135,6 +140,7 @@ static const struct stmmac_hwif_entry { .desc = NULL, .dma = &dwmac1000_dma_ops, .mac = &dwmac1000_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = NULL, .tc = NULL, @@ -145,6 +151,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = true, .xgmac = false, + .has_serdes = false, .min_id = 0, .regs = { .ptp_off = PTP_GMAC4_OFFSET, @@ -152,6 +159,7 @@ static const struct stmmac_hwif_entry { }, .desc = &dwmac4_desc_ops, .dma = &dwmac4_dma_ops, + .serdes = NULL, .mac = &dwmac4_ops, .hwtimestamp = &stmmac_ptp, .mode = NULL, @@ -163,6 +171,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = true, .xgmac = false, + .has_serdes = false, .min_id = DWMAC_CORE_4_00, .regs = { .ptp_off = PTP_GMAC4_OFFSET, @@ -171,6 +180,7 @@ static const struct stmmac_hwif_entry { .desc = &dwmac4_desc_ops, .dma = &dwmac4_dma_ops, .mac = &dwmac410_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = &dwmac4_ring_mode_ops, .tc = &dwmac510_tc_ops, @@ -181,6 +191,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = true, .xgmac = false, + .has_serdes = false, .min_id = DWMAC_CORE_4_10, .regs = { .ptp_off = PTP_GMAC4_OFFSET, @@ -189,6 +200,7 @@ static const struct stmmac_hwif_entry { .desc = &dwmac4_desc_ops, .dma = &dwmac410_dma_ops, .mac = &dwmac410_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = &dwmac4_ring_mode_ops, .tc = &dwmac510_tc_ops, @@ -199,6 +211,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = true, .xgmac = false, + .has_serdes = false, .min_id = DWMAC_CORE_5_10, .regs = { .ptp_off = PTP_GMAC4_OFFSET, @@ -207,6 +220,7 @@ static const struct stmmac_hwif_entry { .desc = &dwmac4_desc_ops, .dma = &dwmac410_dma_ops, .mac = &dwmac510_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = &dwmac4_ring_mode_ops, .tc = &dwmac510_tc_ops, @@ -217,6 +231,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = false, .xgmac = true, + .has_serdes = false, .min_id = DWXGMAC_CORE_2_10, .dev_id = DWXGMAC_ID, .regs = { @@ -226,6 +241,7 @@ static const struct stmmac_hwif_entry { .desc = &dwxgmac210_desc_ops, .dma = &dwxgmac210_dma_ops, .mac = &dwxgmac210_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = NULL, .tc = &dwmac510_tc_ops, @@ -236,6 +252,7 @@ static const struct stmmac_hwif_entry { .gmac = false, .gmac4 = false, .xgmac = true, + .has_serdes = false, .min_id = DWXLGMAC_CORE_2_00, .dev_id = DWXLGMAC_ID, .regs = { @@ -245,13 +262,34 @@ static const struct stmmac_hwif_entry { .desc = &dwxgmac210_desc_ops, .dma = &dwxgmac210_dma_ops, .mac = &dwxlgmac2_ops, + .serdes = NULL, .hwtimestamp = &stmmac_ptp, .mode = NULL, .tc = &dwmac510_tc_ops, .mmc = &dwxgmac_mmc_ops, .setup = dwxlgmac2_setup, .quirks = stmmac_dwxlgmac_quirks, - }, + }, { + .gmac = false, + .gmac4 = true, + .xgmac = false, + .has_serdes = true, + .min_id = DWMAC_CORE_5_10, + .regs = { + .ptp_off = PTP_GMAC4_OFFSET, + .mmc_off = MMC_GMAC4_OFFSET, + }, + .desc = &dwmac4_desc_ops, + .dma = &dwmac410_dma_ops, + .mac = &dwmac510_ops, + .serdes = &intel_serdes_ops, + .hwtimestamp = &stmmac_ptp, + .mode = &dwmac4_ring_mode_ops, + .tc = &dwmac510_tc_ops, + .mmc = &dwmac_mmc_ops, + .setup = dwmac4_setup, + .quirks = NULL, + } }; int stmmac_hwif_init(struct stmmac_priv *priv) @@ -259,6 +297,7 @@ int stmmac_hwif_init(struct stmmac_priv *priv) bool needs_xgmac = priv->plat->has_xgmac; bool needs_gmac4 = priv->plat->has_gmac4; bool needs_gmac = priv->plat->has_gmac; + bool needs_serdes = priv->plat->has_serdes; const struct stmmac_hwif_entry *entry; struct mac_device_info *mac; bool needs_setup = true; @@ -305,6 +344,8 @@ int stmmac_hwif_init(struct stmmac_priv *priv) continue; if (needs_xgmac ^ entry->xgmac) continue; + if (needs_serdes ^ entry->has_serdes) + continue; /* Use synopsys_id var because some setups can override this */ if (priv->synopsys_id < entry->min_id) continue; @@ -315,6 +356,7 @@ int stmmac_hwif_init(struct stmmac_priv *priv) mac->desc = mac->desc ? : entry->desc; mac->dma = mac->dma ? : entry->dma; mac->mac = mac->mac ? : entry->mac; + mac->serdes = mac->serdes ? : entry->serdes; mac->ptp = mac->ptp ? : entry->hwtimestamp; mac->mode = mac->mode ? : entry->mode; mac->tc = mac->tc ? : entry->tc; diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h index fc350149ba34..e4c388124561 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.h +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h @@ -476,6 +476,17 @@ struct stmmac_ops { #define stmmac_fpe_configure(__priv, __args...) \ stmmac_do_void_callback(__priv, mac, fpe_configure, __args) +/* Helpers for serdes */ +struct stmmac_serdes_ops { + int (*serdes_powerup)(struct net_device *ndev); + int (*serdes_powerdown)(struct net_device *ndev); +}; + +#define stmmac_serdes_powerup(__priv, __args...) \ + stmmac_do_callback(__priv, serdes, serdes_powerup, __args) +#define stmmac_serdes_powerdown(__priv, __args...) \ + stmmac_do_callback(__priv, serdes, serdes_powerdown, __args) + /* PTP and HW Timer helpers */ struct stmmac_hwtimestamp { void (*config_hw_tstamping) (void __iomem *ioaddr, u32 data); @@ -595,6 +606,7 @@ struct stmmac_regs_off { }; extern const struct stmmac_ops dwmac100_ops; +extern const struct stmmac_serdes_ops intel_serdes_ops; extern const struct stmmac_dma_ops dwmac100_dma_ops; extern const struct stmmac_ops dwmac1000_ops; extern const struct stmmac_dma_ops dwmac1000_dma_ops; diff --git a/drivers/net/ethernet/stmicro/stmmac/intel_serdes.c b/drivers/net/ethernet/stmicro/stmmac/intel_serdes.c new file mode 100644 index 000000000000..47f19e3dcef7 --- /dev/null +++ b/drivers/net/ethernet/stmicro/stmmac/intel_serdes.c @@ -0,0 +1,181 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2020, Intel Corporation + * Intel Serdes + */ + +#include <linux/bitops.h> +#include <linux/delay.h> +#include <linux/mdio.h> +#include "intel_serdes.h" +#include "stmmac.h" + +static int serdes_status_poll(struct stmmac_priv *priv, int phyaddr, + int phyreg, u32 mask, u32 val) +{ + unsigned int retries = 10; + int val_rd = 0; + + do { + val_rd = mdiobus_read(priv->mii, phyaddr, phyreg); + if ((val_rd & mask) == (val & mask)) + return 0; + udelay(POLL_DELAY_US); + } while (--retries); + + return -ETIMEDOUT; +} + +static int intel_serdes_powerup(struct net_device *ndev) +{ + struct stmmac_priv *priv = netdev_priv(ndev); + int serdes_phy_addr = 0; + u32 data = 0; + + if (!priv->plat->intel_adhoc_addr) + return 0; + + serdes_phy_addr = priv->plat->intel_adhoc_addr; + + /* assert clk_req */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data |= SERDES_PLL_CLK; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* check for clk_ack assertion */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_PLL_CLK, + SERDES_PLL_CLK); + + if (data) { + dev_err(priv->device, "Serdes PLL clk request timeout\n"); + return data; + } + + /* assert lane reset */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data |= SERDES_RST; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* check for assert lane reset reflection */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_RST, + SERDES_RST); + + if (data) { + dev_err(priv->device, "Serdes assert lane reset timeout\n"); + return data; + } + + /* move power state to P0 */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data &= ~SERDES_PWR_ST_MASK; + data |= SERDES_PWR_ST_P0 << SERDES_PWR_ST_SHIFT; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* Check for P0 state */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_PWR_ST_MASK, + SERDES_PWR_ST_P0 << SERDES_PWR_ST_SHIFT); + + if (data) { + dev_err(priv->device, "Serdes power state P0 timeout.\n"); + return data; + } + + return 0; +} + +static int intel_serdes_powerdown(struct net_device *ndev) +{ + struct stmmac_priv *priv = netdev_priv(ndev); + int serdes_phy_addr = 0; + u32 data = 0; + + serdes_phy_addr = priv->plat->intel_adhoc_addr; + + if (!priv->plat->intel_adhoc_addr) + return 0; + + /* move power state to P3 */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data &= ~SERDES_PWR_ST_MASK; + data |= SERDES_PWR_ST_P3 << SERDES_PWR_ST_SHIFT; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* Check for P3 state */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_PWR_ST_MASK, + SERDES_PWR_ST_P3 << SERDES_PWR_ST_SHIFT); + + if (data) { + dev_err(priv->device, "Serdes power state P3 timeout\n"); + return data; + } + + /* de-assert clk_req */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data &= ~SERDES_PLL_CLK; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* check for clk_ack de-assert */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_PLL_CLK, + (u32)~SERDES_PLL_CLK); + + if (data) { + dev_err(priv->device, "Serdes PLL clk de-assert timeout\n"); + return data; + } + + /* de-assert lane reset */ + data = mdiobus_read(priv->mii, serdes_phy_addr, + SERDES_GCR0); + + data &= ~SERDES_RST; + + mdiobus_write(priv->mii, serdes_phy_addr, + SERDES_GCR0, data); + + /* check for de-assert lane reset reflection */ + data = serdes_status_poll(priv, serdes_phy_addr, + SERDES_GSR0, + SERDES_RST, + (u32)~SERDES_RST); + + if (data) { + dev_err(priv->device, "Serdes de-assert lane reset timeout\n"); + return data; + } + + return 0; +} + +const struct stmmac_serdes_ops intel_serdes_ops = { + .serdes_powerup = intel_serdes_powerup, + .serdes_powerdown = intel_serdes_powerdown, +}; diff --git a/drivers/net/ethernet/stmicro/stmmac/intel_serdes.h b/drivers/net/ethernet/stmicro/stmmac/intel_serdes.h new file mode 100644 index 000000000000..bf72d557d0be --- /dev/null +++ b/drivers/net/ethernet/stmicro/stmmac/intel_serdes.h @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2020, Intel Corporation + * Intel Serdes + */ + +#ifndef __INTEL_SERDES_H__ +#define __INTEL_SERDES_H__ + +#define POLL_DELAY_US 8 + +/* SERDES Register */ +#define SERDES_GSR0 0x5 /* Global Status Reg0 */ +#define SERDES_GCR0 0xb /* Global Configuration Reg0 */ + +/* SERDES defines */ +#define SERDES_PLL_CLK BIT(0) /* PLL clk valid signal */ +#define SERDES_RST BIT(2) /* Serdes Reset */ +#define SERDES_PWR_ST_MASK GENMASK(6, 4) /* Serdes Power state*/ +#define SERDES_PWR_ST_SHIFT 4 +#define SERDES_PWR_ST_P0 0x0 +#define SERDES_PWR_ST_P3 0x3 + +#endif /* __INTEL_SERDES_H__ */ diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 0e8c80f23557..11d4520e5655 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -45,6 +45,7 @@ #include "dwmac1000.h" #include "dwxgmac2.h" #include "hwif.h" +#include "intel_serdes.h" #define STMMAC_ALIGN(x) ALIGN(ALIGN(x, SMP_CACHE_BYTES), 16) #define TSO_MAX_BUFF_SIZE (SZ_16K - 1) @@ -2629,6 +2630,10 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) u32 chan; int ret; + /* Power up Serdes */ + if (priv->plat->has_serdes) + stmmac_serdes_powerup(priv, dev); + /* DMA initialization and SW reset */ ret = stmmac_init_dma_engine(priv); if (ret < 0) { @@ -5015,6 +5020,9 @@ int stmmac_dvr_remove(struct device *dev) stmmac_stop_all_dma(priv); + if (priv->plat->has_serdes) + stmmac_serdes_powerdown(priv, ndev); + stmmac_mac_set(priv, priv->ioaddr, false); netif_carrier_off(ndev); unregister_netdev(ndev); diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c index 7acbac73c29c..751f138552a6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c @@ -119,6 +119,9 @@ static int intel_mgbe_common_data(struct pci_dev *pdev, plat->force_sf_dma_mode = 0; plat->tso_en = 1; + /* intel specific adhoc (mdio) address for serdes & etc */ + plat->intel_adhoc_addr = 0x15; + plat->rx_sched_algorithm = MTL_RX_ALGORITHM_SP; for (i = 0; i < plat->rx_queues_to_use; i++) { @@ -194,6 +197,9 @@ static int intel_mgbe_common_data(struct pci_dev *pdev, /* Set the maxmtu to a default of JUMBO_LEN */ plat->maxmtu = JUMBO_LEN; + if (plat->phy_interface == PHY_INTERFACE_MODE_SGMII) + plat->has_serdes = 1; + return 0; } diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index fbafb353e9be..c1289566f4d0 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -146,6 +146,7 @@ struct stmmac_txq_cfg { struct plat_stmmacenet_data { int bus_id; int phy_addr; + int intel_adhoc_addr; int interface; phy_interface_t phy_interface; struct stmmac_mdio_bus_data *mdio_bus_data; @@ -190,6 +191,7 @@ struct plat_stmmacenet_data { struct reset_control *stmmac_rst; struct stmmac_axi *axi; int has_gmac4; + int has_serdes; bool has_sun8i; bool tso_en; int rss_en; -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-22 13:23 ` [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence Voon Weifeng @ 2020-03-23 7:46 ` Jose Abreu 2020-03-23 8:16 ` Voon, Weifeng 0 siblings, 1 reply; 8+ messages in thread From: Jose Abreu @ 2020-03-23 7:46 UTC (permalink / raw) To: Voon Weifeng, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong Boon Leong From: Voon Weifeng <weifeng.voon@intel.com> Date: Mar/22/2020, 13:23:42 (UTC+00:00) > This patch is to enable Intel SERDES power up/down sequence. The SERDES > converts 8/10 bits data to SGMII signal. Below is an example of > HW configuration for SGMII mode. The SERDES is located in the PHY IF > in the diagram below. > > <-----------------GBE Controller---------->|<--External PHY chip--> > +----------+ +----+ +---+ +----------+ > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | External | > | MAC | |xPCS| |IF | | PHY | > +----------+ +----+ +---+ +----------+ > ^ ^ ^ ^ > | | | | > +---------------------MDIO-------------------------+ > > PHY IF configuration and status registers are accessible through > mdio address 0x15 which is defined as intel_adhoc_addr. During D0, > The driver will need to power up PHY IF by changing the power state > to P0. Likewise, for D3, the driver sets PHY IF power state to P3. I don't think this is the right approach. You could just add a new "mdio-intel-serdes" to phy/ folder just like I did with XPCS because this is mostly related with PHY settings rather than EQoS. Perhaps Andrew has better insight on this. BTW, are you using the standard XPCS helpers in phy/ folder ? Is it working fine for you ? --- Thanks, Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-23 7:46 ` Jose Abreu @ 2020-03-23 8:16 ` Voon, Weifeng 2020-03-23 8:53 ` Jose Abreu 0 siblings, 1 reply; 8+ messages in thread From: Voon, Weifeng @ 2020-03-23 8:16 UTC (permalink / raw) To: Jose Abreu, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong, Boon Leong > > This patch is to enable Intel SERDES power up/down sequence. The > > SERDES converts 8/10 bits data to SGMII signal. Below is an example of > > HW configuration for SGMII mode. The SERDES is located in the PHY IF > > in the diagram below. > > > > <-----------------GBE Controller---------->|<--External PHY chip--> > > +----------+ +----+ +---+ +----------+ > > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | External | > > | MAC | |xPCS| |IF | | PHY | > > +----------+ +----+ +---+ +----------+ > > ^ ^ ^ ^ > > | | | | > > +---------------------MDIO-------------------------+ > > > > PHY IF configuration and status registers are accessible through mdio > > address 0x15 which is defined as intel_adhoc_addr. During D0, The > > driver will need to power up PHY IF by changing the power state to P0. > > Likewise, for D3, the driver sets PHY IF power state to P3. > > I don't think this is the right approach. > > You could just add a new "mdio-intel-serdes" to phy/ folder just like I > did with XPCS because this is mostly related with PHY settings rather > than EQoS. I am taking this approach to put it in stmmac folder rather than phy folder as a generic mdio-intel-serdes as this is a specific Intel serdes architecture which would only pair with DW EQos and DW xPCS HW. Since this serdes will not able to pair other MAC or other non-Intel platform, I would like you to reconsider this approach. I am open for discussion. Thanks Jose for the fast response. Regards, Weifeng > > Perhaps Andrew has better insight on this. > > BTW, are you using the standard XPCS helpers in phy/ folder ? Is it > working fine for you ? > > --- > Thanks, > Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-23 8:16 ` Voon, Weifeng @ 2020-03-23 8:53 ` Jose Abreu 2020-03-23 15:52 ` Voon, Weifeng 0 siblings, 1 reply; 8+ messages in thread From: Jose Abreu @ 2020-03-23 8:53 UTC (permalink / raw) To: Voon, Weifeng, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong, Boon Leong From: Voon, Weifeng <weifeng.voon@intel.com> Date: Mar/23/2020, 08:16:29 (UTC+00:00) > > > This patch is to enable Intel SERDES power up/down sequence. The > > > SERDES converts 8/10 bits data to SGMII signal. Below is an example of > > > HW configuration for SGMII mode. The SERDES is located in the PHY IF > > > in the diagram below. > > > > > > <-----------------GBE Controller---------->|<--External PHY chip--> > > > +----------+ +----+ +---+ +----------+ > > > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | External | > > > | MAC | |xPCS| |IF | | PHY | > > > +----------+ +----+ +---+ +----------+ > > > ^ ^ ^ ^ > > > | | | | > > > +---------------------MDIO-------------------------+ > > > > > > PHY IF configuration and status registers are accessible through mdio > > > address 0x15 which is defined as intel_adhoc_addr. During D0, The > > > driver will need to power up PHY IF by changing the power state to P0. > > > Likewise, for D3, the driver sets PHY IF power state to P3. > > > > I don't think this is the right approach. > > > > You could just add a new "mdio-intel-serdes" to phy/ folder just like I > > did with XPCS because this is mostly related with PHY settings rather > > than EQoS. > I am taking this approach to put it in stmmac folder rather than phy folder > as a generic mdio-intel-serdes as this is a specific Intel serdes architecture which > would only pair with DW EQos and DW xPCS HW. Since this serdes will not able to > pair other MAC or other non-Intel platform, I would like you to reconsider this > approach. I am open for discussion. > Thanks Jose for the fast response. OK, then I think we should use the BSP init/exit functions that are already available for platform setups (.init and .exit callback of plat_stmmacenet_data struct). We just need to extend this to PCI based setups. You can take a look at stmmac_platform.c and check what's done. Basically: - Call priv->plat->init() at probe() and resume() - Call priv->plat->exit() at remove() and suspend() --- Thanks, Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-23 8:53 ` Jose Abreu @ 2020-03-23 15:52 ` Voon, Weifeng 2020-04-01 14:23 ` Voon, Weifeng 0 siblings, 1 reply; 8+ messages in thread From: Voon, Weifeng @ 2020-03-23 15:52 UTC (permalink / raw) To: Jose Abreu, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong, Boon Leong > > > > This patch is to enable Intel SERDES power up/down sequence. The > > > > SERDES converts 8/10 bits data to SGMII signal. Below is an > > > > example of HW configuration for SGMII mode. The SERDES is located > > > > in the PHY IF in the diagram below. > > > > > > > > <-----------------GBE Controller---------->|<--External PHY > > > > chip--> > > > > +----------+ +----+ +---+ +---------- > + > > > > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | External > | > > > > | MAC | |xPCS| |IF | | PHY > | > > > > +----------+ +----+ +---+ +---------- > + > > > > ^ ^ ^ ^ > > > > | | | | > > > > +---------------------MDIO-------------------------+ > > > > > > > > PHY IF configuration and status registers are accessible through > > > > mdio address 0x15 which is defined as intel_adhoc_addr. During D0, > > > > The driver will need to power up PHY IF by changing the power > state to P0. > > > > Likewise, for D3, the driver sets PHY IF power state to P3. > > > > > > I don't think this is the right approach. > > > > > > You could just add a new "mdio-intel-serdes" to phy/ folder just > > > like I did with XPCS because this is mostly related with PHY > > > settings rather than EQoS. > > I am taking this approach to put it in stmmac folder rather than phy > > folder as a generic mdio-intel-serdes as this is a specific Intel > > serdes architecture which would only pair with DW EQos and DW xPCS HW. > > Since this serdes will not able to pair other MAC or other non-Intel > > platform, I would like you to reconsider this approach. I am open for > discussion. > > Thanks Jose for the fast response. > > OK, then I think we should use the BSP init/exit functions that are > already available for platform setups (.init and .exit callback of > plat_stmmacenet_data struct). We just need to extend this to PCI based > setups. > > You can take a look at stmmac_platform.c and check what's done. > Basically: > - Call priv->plat->init() at probe() and resume() > - Call priv->plat->exit() at remove() and suspend() > I have 2 concern if using the suggested BSP init/exit function. 1. Serdes is configured through MDIO bus. But the mdio bus register only happens in stmmac_dvr_probe() in stmmac_main.c. 2. All tx/rx packets requires serdes to be in the correct power state. If the driver power-down before stopping all the dma, it will cause tx queue timeout as packets are not able to be transmitted out. Hence, the serdes cannot be power-down before calling the stmmac_dvr_remove(). The stmmac_dvr_remove() will unregister the mdio bus. So, the driver cannot powerdown the serdes after the stmmac_dvr_remove() too. Regards, Weifeng > --- > Thanks, > Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-03-23 15:52 ` Voon, Weifeng @ 2020-04-01 14:23 ` Voon, Weifeng 2020-04-02 8:47 ` Jose Abreu 0 siblings, 1 reply; 8+ messages in thread From: Voon, Weifeng @ 2020-04-01 14:23 UTC (permalink / raw) To: Jose Abreu, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong, Boon Leong > > > > > This patch is to enable Intel SERDES power up/down sequence. The > > > > > SERDES converts 8/10 bits data to SGMII signal. Below is an > > > > > example of HW configuration for SGMII mode. The SERDES is > > > > > located in the PHY IF in the diagram below. > > > > > > > > > > <-----------------GBE Controller---------->|<--External PHY > > > > > chip--> > > > > > +----------+ +----+ +---+ +-------- > -- > > + > > > > > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | > External > > | > > > > > | MAC | |xPCS| |IF | | PHY > > | > > > > > +----------+ +----+ +---+ +-------- > -- > > + > > > > > ^ ^ ^ ^ > > > > > | | | | > > > > > +---------------------MDIO-------------------------+ > > > > > > > > > > PHY IF configuration and status registers are accessible through > > > > > mdio address 0x15 which is defined as intel_adhoc_addr. During > > > > > D0, The driver will need to power up PHY IF by changing the > > > > > power > > state to P0. > > > > > Likewise, for D3, the driver sets PHY IF power state to P3. > > > > > > > > I don't think this is the right approach. > > > > > > > > You could just add a new "mdio-intel-serdes" to phy/ folder just > > > > like I did with XPCS because this is mostly related with PHY > > > > settings rather than EQoS. > > > I am taking this approach to put it in stmmac folder rather than phy > > > folder as a generic mdio-intel-serdes as this is a specific Intel > > > serdes architecture which would only pair with DW EQos and DW xPCS > HW. > > > Since this serdes will not able to pair other MAC or other non-Intel > > > platform, I would like you to reconsider this approach. I am open > > > for > > discussion. > > > Thanks Jose for the fast response. > > > > OK, then I think we should use the BSP init/exit functions that are > > already available for platform setups (.init and .exit callback of > > plat_stmmacenet_data struct). We just need to extend this to PCI based > > setups. > > > > You can take a look at stmmac_platform.c and check what's done. > > Basically: > > - Call priv->plat->init() at probe() and resume() > > - Call priv->plat->exit() at remove() and suspend() > > > I have 2 concern if using the suggested BSP init/exit function. > 1. Serdes is configured through MDIO bus. But the mdio bus register only > happens in stmmac_dvr_probe() in stmmac_main.c. > > 2. All tx/rx packets requires serdes to be in the correct power state. > If the driver power-down before stopping all the dma, it will cause tx > queue timeout as packets are not able to be transmitted out. Hence, the > serdes cannot be power-down before calling the stmmac_dvr_remove(). The > stmmac_dvr_remove() will unregister the mdio bus. So, the > driver cannot powerdown the serdes after the stmmac_dvr_remove() too. I went through the code again, I understand that your intention is to keep the platform specific setup in its own file and keep the main dwmac logic clean. But, I did not see any way to separate this SERDES configuration from the stmmac_main logic cleanly. Hope to get more ideas and discussion. Thanks. Weifeng > > Regards, > Weifeng > > > --- > > Thanks, > > Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence 2020-04-01 14:23 ` Voon, Weifeng @ 2020-04-02 8:47 ` Jose Abreu 0 siblings, 0 replies; 8+ messages in thread From: Jose Abreu @ 2020-04-02 8:47 UTC (permalink / raw) To: Voon, Weifeng, David S . Miller, Maxime Coquelin Cc: netdev, linux-kernel, Giuseppe Cavallaro, Andrew Lunn, Alexandre Torgue, Ong, Boon Leong From: Voon, Weifeng <weifeng.voon@intel.com> Date: Apr/01/2020, 15:23:09 (UTC+00:00) > > > > > > This patch is to enable Intel SERDES power up/down sequence. The > > > > > > SERDES converts 8/10 bits data to SGMII signal. Below is an > > > > > > example of HW configuration for SGMII mode. The SERDES is > > > > > > located in the PHY IF in the diagram below. > > > > > > > > > > > > <-----------------GBE Controller---------->|<--External PHY > > > > > > chip--> > > > > > > +----------+ +----+ +---+ +-------- > > -- > > > + > > > > > > | EQoS | <-GMII->| DW | < ------ > |PHY| <-SGMII-> | > > External > > > | > > > > > > | MAC | |xPCS| |IF | | PHY > > > | > > > > > > +----------+ +----+ +---+ +-------- > > -- > > > + > > > > > > ^ ^ ^ ^ > > > > > > | | | | > > > > > > +---------------------MDIO-------------------------+ > > > > > > > > > > > > PHY IF configuration and status registers are accessible through > > > > > > mdio address 0x15 which is defined as intel_adhoc_addr. During > > > > > > D0, The driver will need to power up PHY IF by changing the > > > > > > power > > > state to P0. > > > > > > Likewise, for D3, the driver sets PHY IF power state to P3. > > > > > > > > > > I don't think this is the right approach. > > > > > > > > > > You could just add a new "mdio-intel-serdes" to phy/ folder just > > > > > like I did with XPCS because this is mostly related with PHY > > > > > settings rather than EQoS. > > > > I am taking this approach to put it in stmmac folder rather than phy > > > > folder as a generic mdio-intel-serdes as this is a specific Intel > > > > serdes architecture which would only pair with DW EQos and DW xPCS > > HW. > > > > Since this serdes will not able to pair other MAC or other non-Intel > > > > platform, I would like you to reconsider this approach. I am open > > > > for > > > discussion. > > > > Thanks Jose for the fast response. > > > > > > OK, then I think we should use the BSP init/exit functions that are > > > already available for platform setups (.init and .exit callback of > > > plat_stmmacenet_data struct). We just need to extend this to PCI based > > > setups. > > > > > > You can take a look at stmmac_platform.c and check what's done. > > > Basically: > > > - Call priv->plat->init() at probe() and resume() > > > - Call priv->plat->exit() at remove() and suspend() > > > > > I have 2 concern if using the suggested BSP init/exit function. > > 1. Serdes is configured through MDIO bus. But the mdio bus register only > > happens in stmmac_dvr_probe() in stmmac_main.c. > > > > 2. All tx/rx packets requires serdes to be in the correct power state. > > If the driver power-down before stopping all the dma, it will cause tx > > queue timeout as packets are not able to be transmitted out. Hence, the > > serdes cannot be power-down before calling the stmmac_dvr_remove(). The > > stmmac_dvr_remove() will unregister the mdio bus. So, the > > driver cannot powerdown the serdes after the stmmac_dvr_remove() too. > > I went through the code again, I understand that your intention is to keep the > platform specific setup in its own file and keep the main dwmac logic clean. > But, I did not see any way to separate this SERDES configuration from the > stmmac_main logic cleanly. > Hope to get more ideas and discussion. Thanks. Sorry for the late reply! Yes, that's exactly my intention. Maybe we can add a new set of callbacks for BSP. Something like ->start(), ->stop() ? --- Thanks, Jose Miguel Abreu ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-02 8:47 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-22 13:23 [RFC,net-next,v1, 0/1] Enable SERDES power up/down Voon Weifeng 2020-03-22 13:23 ` [RFC,net-next,v1, 1/1] net: stmmac: Enable SERDES power up/down sequence Voon Weifeng 2020-03-23 7:46 ` Jose Abreu 2020-03-23 8:16 ` Voon, Weifeng 2020-03-23 8:53 ` Jose Abreu 2020-03-23 15:52 ` Voon, Weifeng 2020-04-01 14:23 ` Voon, Weifeng 2020-04-02 8:47 ` Jose Abreu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).