* [PATCH net] net: dsa: Fix duplicate frames flooded by learning
@ 2020-03-22 20:58 Florian Fainelli
2020-03-23 18:23 ` Vivien Didelot
2020-03-24 4:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-03-22 20:58 UTC (permalink / raw)
To: netdev
Cc: mbizon, Florian Fainelli, Andrew Lunn, Vivien Didelot,
David S. Miller, Jakub Kicinski, open list
When both the switch and the bridge are learning about new addresses,
switch ports attached to the bridge would see duplicate ARP frames
because both entities would attempt to send them.
Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/tag_brcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
index 9c3114179690..9169b63a89e3 100644
--- a/net/dsa/tag_brcm.c
+++ b/net/dsa/tag_brcm.c
@@ -140,6 +140,8 @@ static struct sk_buff *brcm_tag_rcv_ll(struct sk_buff *skb,
/* Remove Broadcom tag and update checksum */
skb_pull_rcsum(skb, BRCM_TAG_LEN);
+ skb->offload_fwd_mark = 1;
+
return skb;
}
#endif
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: Fix duplicate frames flooded by learning
2020-03-22 20:58 [PATCH net] net: dsa: Fix duplicate frames flooded by learning Florian Fainelli
@ 2020-03-23 18:23 ` Vivien Didelot
2020-03-24 4:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2020-03-23 18:23 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, mbizon, Florian Fainelli, Andrew Lunn, David S. Miller,
Jakub Kicinski, open list
On Sun, 22 Mar 2020 13:58:50 -0700, Florian Fainelli <f.fainelli@gmail.com> wrote:
> When both the switch and the bridge are learning about new addresses,
> switch ports attached to the bridge would see duplicate ARP frames
> because both entities would attempt to send them.
>
> Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
> Reported-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: Fix duplicate frames flooded by learning
2020-03-22 20:58 [PATCH net] net: dsa: Fix duplicate frames flooded by learning Florian Fainelli
2020-03-23 18:23 ` Vivien Didelot
@ 2020-03-24 4:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-24 4:46 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, mbizon, andrew, vivien.didelot, kuba, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sun, 22 Mar 2020 13:58:50 -0700
> When both the switch and the bridge are learning about new addresses,
> switch ports attached to the bridge would see duplicate ARP frames
> because both entities would attempt to send them.
>
> Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
> Reported-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-24 4:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 20:58 [PATCH net] net: dsa: Fix duplicate frames flooded by learning Florian Fainelli
2020-03-23 18:23 ` Vivien Didelot
2020-03-24 4:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).