From: Dejin Zheng <zhengdejin5@gmail.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net,
mchehab+samsung@kernel.org, gregkh@linuxfoundation.org,
broonie@kernel.org, tglx@linutronix.de, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dejin Zheng <zhengdejin5@gmail.com>
Subject: [PATCH net-next v6 03/10] net: phy: introduce phy_read_mmd_poll_timeout macro
Date: Mon, 23 Mar 2020 10:56:26 +0800 [thread overview]
Message-ID: <20200323025633.6069-4-zhengdejin5@gmail.com> (raw)
In-Reply-To: <20200323025633.6069-1-zhengdejin5@gmail.com>
it is sometimes necessary to poll a phy register by phy_read_mmd()
function until its value satisfies some condition. introduce
phy_read_mmd_poll_timeout() macros that do this.
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
v5 -> v6:
- no changed
v4 -> v5:
- no changed
v3 -> v4:
- deal with precedence issues for parameter cond.
v2 -> v3:
- modify the parameter order of newly added functions.
phy_read_mmd_poll_timeout(val, cond, sleep_us, timeout_us, \
phydev, devaddr, regnum)
||
\/
phy_read_mmd_poll_timeout(phydev, devaddr regnum, val, cond, \
sleep_us, timeout_us)
v1 -> v2:
- passed a phydev, device address and a reg to replace args...
parameter in phy_read_mmd_poll_timeout() by Andrew Lunn 's
suggestion. Andrew Lunn <andrew@lunn.ch>, Thanks very much for
your help!
- handle phy_read_mmd return an error(the return value < 0) in
phy_read_mmd_poll_timeout(). Thanks Andrew again.
include/linux/phy.h | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 36d9dea04016..42a5ec9288d5 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -24,6 +24,7 @@
#include <linux/mod_devicetable.h>
#include <linux/u64_stats_sync.h>
#include <linux/irqreturn.h>
+#include <linux/iopoll.h>
#include <linux/atomic.h>
@@ -784,6 +785,20 @@ static inline int __phy_modify_changed(struct phy_device *phydev, u32 regnum,
*/
int phy_read_mmd(struct phy_device *phydev, int devad, u32 regnum);
+#define phy_read_mmd_poll_timeout(phydev, devaddr, regnum, val, cond, \
+ sleep_us, timeout_us) \
+({ \
+ int ret = 0; \
+ ret = read_poll_timeout(phy_read_mmd, val, (cond) || val < 0, \
+ sleep_us, timeout_us, phydev, devaddr, \
+ regnum); \
+ if (val < 0) \
+ ret = val; \
+ if (ret) \
+ phydev_err(phydev, "%s failed: %d\n", __func__, ret); \
+ ret; \
+})
+
/**
* __phy_read_mmd - Convenience function for reading a register
* from an MMD on a given PHY.
--
2.25.0
next prev parent reply other threads:[~2020-03-23 2:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 2:56 [PATCH net-next v6 00/10] introduce read_poll_timeout Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 01/10] iopoll: introduce read_poll_timeout macro Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 02/10] iopoll: redefined readx_poll_timeout macro to simplify the code Dejin Zheng
2020-03-23 2:56 ` Dejin Zheng [this message]
2020-03-23 3:21 ` [PATCH net-next v6 03/10] net: phy: introduce phy_read_mmd_poll_timeout macro Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 04/10] net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 3:20 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 05/10] net: phy: aquantia: " Dejin Zheng
2020-03-23 3:20 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 06/10] net: phy: marvell10g: " Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 07/10] net: phy: introduce phy_read_poll_timeout macro Dejin Zheng
2020-03-23 3:19 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 08/10] net: phy: use phy_read_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 3:22 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 09/10] net: phy: smsc: " Dejin Zheng
2020-03-23 3:17 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 10/10] net: phy: tja11xx: " Dejin Zheng
2020-03-23 3:17 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323025633.6069-4-zhengdejin5@gmail.com \
--to=zhengdejin5@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).