From: Florian Fainelli <f.fainelli@gmail.com>
To: Dejin Zheng <zhengdejin5@gmail.com>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, mchehab+samsung@kernel.org,
gregkh@linuxfoundation.org, broonie@kernel.org,
tglx@linutronix.de, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 08/10] net: phy: use phy_read_poll_timeout() to simplify the code
Date: Sun, 22 Mar 2020 20:22:30 -0700 [thread overview]
Message-ID: <61c8c11d-2aa8-cb6e-9e7a-99aea94d78b9@gmail.com> (raw)
In-Reply-To: <20200323025633.6069-9-zhengdejin5@gmail.com>
On 3/22/2020 7:56 PM, Dejin Zheng wrote:
> use phy_read_poll_timeout() to replace the poll codes for
> simplify the code in phy_poll_reset() function.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
> v5 -> v6:
> - add some check for keep the code more similar.
> v4 -> v5:
> - it can add msleep before call phy_read_poll_timeout()
> to keep the code more similar. so add it.
> v3 -> v4:
> - drop it.
> v2 -> v3:
> - adapt to it after modifying the parameter order of the
> newly added function
> v1 -> v2:
> - remove the handle of phy_read()'s return error.
>
> drivers/net/phy/phy_device.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index a585faf8b844..eb1b177a9878 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1059,18 +1059,13 @@ EXPORT_SYMBOL(phy_disconnect);
> static int phy_poll_reset(struct phy_device *phydev)
> {
> /* Poll until the reset bit clears (50ms per retry == 0.6 sec) */
> - unsigned int retries = 12;
> - int ret;
> -
> - do {
> - msleep(50);
> - ret = phy_read(phydev, MII_BMCR);
> - if (ret < 0)
> - return ret;
> - } while (ret & BMCR_RESET && --retries);
> - if (ret & BMCR_RESET)
> - return -ETIMEDOUT;
> + int ret, val;
>
> + msleep(50);
> + ret = phy_read_poll_timeout(phydev, MII_BMCR, val, !(val & BMCR_RESET),
> + 50000, 550000);
> + if (ret)
> + return ret;
You may consider creating a special variant of phy_read_poll_timeout()
which sleeps before checking the condition, since there are at least two
occurrences of this here and within marvell10g.c?
--
Florian
next prev parent reply other threads:[~2020-03-23 3:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 2:56 [PATCH net-next v6 00/10] introduce read_poll_timeout Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 01/10] iopoll: introduce read_poll_timeout macro Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 02/10] iopoll: redefined readx_poll_timeout macro to simplify the code Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 03/10] net: phy: introduce phy_read_mmd_poll_timeout macro Dejin Zheng
2020-03-23 3:21 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 04/10] net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 3:20 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 05/10] net: phy: aquantia: " Dejin Zheng
2020-03-23 3:20 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 06/10] net: phy: marvell10g: " Dejin Zheng
2020-03-23 2:56 ` [PATCH net-next v6 07/10] net: phy: introduce phy_read_poll_timeout macro Dejin Zheng
2020-03-23 3:19 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 08/10] net: phy: use phy_read_poll_timeout() to simplify the code Dejin Zheng
2020-03-23 3:22 ` Florian Fainelli [this message]
2020-03-23 2:56 ` [PATCH net-next v6 09/10] net: phy: smsc: " Dejin Zheng
2020-03-23 3:17 ` Florian Fainelli
2020-03-23 2:56 ` [PATCH net-next v6 10/10] net: phy: tja11xx: " Dejin Zheng
2020-03-23 3:17 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c8c11d-2aa8-cb6e-9e7a-99aea94d78b9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).