[PATCH] clocksource/drivers/timer-vf-pit: Fix build error

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] clocksource/drivers/timer-vf-pit: Fix build error
       [not found] <202003230153.VzOyvdbR%lkp@intel.com>
@ 2020-03-23  6:11 ` afzal mohammed
  2020-03-23 10:02   ` Daniel Lezcano
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: afzal mohammed @ 2020-03-23  6:11 UTC (permalink / raw)
  To: Daniel Lezcano; +Cc: kbuild test robot, kbuild-all, linux-kernel

Recently all usages of setup_irq() was replaced by request_irq(). The
replacement in timer-vf-pit.c missed closing parentheses resulting in
build error (vf610m4_defconfig). Fix it.

Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---
 drivers/clocksource/timer-vf-pit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
index 7ad4a8b008c2..1a86a4e7e344 100644
--- a/drivers/clocksource/timer-vf-pit.c
+++ b/drivers/clocksource/timer-vf-pit.c
@@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
 	__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
 
 	BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
-			   "VF pit timer", &clockevent_pit);
+			   "VF pit timer", &clockevent_pit));
 
 	clockevent_pit.cpumask = cpumask_of(0);
 	clockevent_pit.irq = irq;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error
  2020-03-23  6:11 ` [PATCH] clocksource/drivers/timer-vf-pit: Fix build error afzal mohammed
@ 2020-03-23 10:02   ` Daniel Lezcano
  2020-03-31 11:40   ` Daniel Lezcano
  2020-04-05  7:32   ` [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis tip-bot2 for afzal mohammed
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2020-03-23 10:02 UTC (permalink / raw)
  To: afzal mohammed; +Cc: kbuild test robot, kbuild-all, linux-kernel

On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq(). The
> replacement in timer-vf-pit.c missed closing parentheses resulting in
> build error (vf610m4_defconfig). Fix it.
> 
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
>  drivers/clocksource/timer-vf-pit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 7ad4a8b008c2..1a86a4e7e344 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
>  	__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>  
>  	BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> -			   "VF pit timer", &clockevent_pit);
> +			   "VF pit timer", &clockevent_pit));

Applied


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error
  2020-03-23  6:11 ` [PATCH] clocksource/drivers/timer-vf-pit: Fix build error afzal mohammed
  2020-03-23 10:02   ` Daniel Lezcano
@ 2020-03-31 11:40   ` Daniel Lezcano
  2020-04-05  5:38     ` afzal mohammed
  2020-04-05  7:32   ` [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis tip-bot2 for afzal mohammed
  2 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2020-03-31 11:40 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: afzal mohammed, kbuild test robot, kbuild-all, linux-kernel


Hi Thomas,

I was about to send a PR with the revert and this patch. As you picked
up the revert, do you mind to pick also this one?

Thanks

  -- Daniel


On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> The replacement in timer-vf-pit.c missed closing parentheses
> resulting in build error (vf610m4_defconfig). Fix it.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by
> request_irq()") Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> ---
> drivers/clocksource/timer-vf-pit.c | 2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-vf-pit.c
> b/drivers/clocksource/timer-vf-pit.c index
> 7ad4a8b008c2..1a86a4e7e344 100644 ---
> a/drivers/clocksource/timer-vf-pit.c +++
> b/drivers/clocksource/timer-vf-pit.c @@ -129,7 +129,7 @@ static int
> __init pit_clockevent_init(unsigned long rate, int irq)
> __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>
> BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER |
> IRQF_IRQPOLL, -			   "VF pit timer", &clockevent_pit); +			   "VF
> pit timer", &clockevent_pit));
>
> clockevent_pit.cpumask = cpumask_of(0); clockevent_pit.irq = irq;
>


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error
  2020-03-31 11:40   ` Daniel Lezcano
@ 2020-04-05  5:38     ` afzal mohammed
  0 siblings, 0 replies; 5+ messages in thread
From: afzal mohammed @ 2020-04-05  5:38 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner; +Cc: kbuild test robot, linux-kernel

Hi Daniel, Thomas,

On Tue, Mar 31, 2020 at 01:40:36PM +0200, Daniel Lezcano wrote:

> Hi Thomas,
> 
> I was about to send a PR with the revert and this patch. As you picked
> up the revert, do you mind to pick also this one?

Mainline is broken w/o this change for ARM vf610m4_defconfig, Stephen
Rothwell also reported it today, please do the needful so as to let it
reach mainline.

Regards
afzal

> On 23/03/2020 07:11, afzal mohammed wrote:
> > Recently all usages of setup_irq() was replaced by request_irq().
> > The replacement in timer-vf-pit.c missed closing parentheses
> > resulting in build error (vf610m4_defconfig). Fix it.
> >
> > Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by
> > request_irq()") Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> ---
> > drivers/clocksource/timer-vf-pit.c | 2 +- 1 file changed, 1
> > insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/timer-vf-pit.c
> > b/drivers/clocksource/timer-vf-pit.c index
> > 7ad4a8b008c2..1a86a4e7e344 100644 ---
> > a/drivers/clocksource/timer-vf-pit.c +++
> > b/drivers/clocksource/timer-vf-pit.c @@ -129,7 +129,7 @@ static int
> > __init pit_clockevent_init(unsigned long rate, int irq)
> > __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
> >
> > BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER |
> > IRQF_IRQPOLL, -			   "VF pit timer", &clockevent_pit); +			   "VF
> > pit timer", &clockevent_pit));
> >
> > clockevent_pit.cpumask = cpumask_of(0); clockevent_pit.irq = irq;
> >
> 
> 
> -- 
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis
  2020-03-23  6:11 ` [PATCH] clocksource/drivers/timer-vf-pit: Fix build error afzal mohammed
  2020-03-23 10:02   ` Daniel Lezcano
  2020-03-31 11:40   ` Daniel Lezcano
@ 2020-04-05  7:32   ` tip-bot2 for afzal mohammed
  2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for afzal mohammed @ 2020-04-05  7:32 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: kbuild test robot, afzal mohammed, Thomas Gleixner, x86, LKML

The following commit has been merged into the timers/urgent branch of tip:

Commit-ID:     760a53768610d427990192b5cfdb71310e1373db
Gitweb:        https://git.kernel.org/tip/760a53768610d427990192b5cfdb71310e1373db
Author:        afzal mohammed <afzal.mohd.ma@gmail.com>
AuthorDate:    Mon, 23 Mar 2020 11:41:30 +05:30
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sun, 05 Apr 2020 09:24:58 +02:00

clocksource/drivers/timer-vf-pit: Add missing parenthesis

Recently all usage of setup_irq() was replaced by request_irq(). The
replacement in timer-vf-pit.c missed closing parentheses resulting in a build
error (vf610m4_defconfig). Fix it.

Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20200323061130.GA6286@afzalpc

---
 drivers/clocksource/timer-vf-pit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
index 7ad4a8b..1a86a4e 100644
--- a/drivers/clocksource/timer-vf-pit.c
+++ b/drivers/clocksource/timer-vf-pit.c
@@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
 	__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
 
 	BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
-			   "VF pit timer", &clockevent_pit);
+			   "VF pit timer", &clockevent_pit));
 
 	clockevent_pit.cpumask = cpumask_of(0);
 	clockevent_pit.irq = irq;

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-04-05  7:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <202003230153.VzOyvdbR%lkp@intel.com>
2020-03-23  6:11 ` [PATCH] clocksource/drivers/timer-vf-pit: Fix build error afzal mohammed
2020-03-23 10:02   ` Daniel Lezcano
2020-03-31 11:40   ` Daniel Lezcano
2020-04-05  5:38     ` afzal mohammed
2020-04-05  7:32   ` [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis tip-bot2 for afzal mohammed

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).