* [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment
@ 2020-03-23 7:02 Rayagonda Kokatanur
0 siblings, 0 replies; 4+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-23 7:02 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, linux-kernel, BCM Kernel Feedback
Cc: Rayagonda Kokatanur
Remove unused variable assignment.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);
/* Fill additional invoke cmd params */
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment
@ 2020-03-23 7:07 Rayagonda Kokatanur
0 siblings, 0 replies; 4+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-23 7:07 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, linux-kernel, BCM Kernel Feedback
Cc: Rayagonda Kokatanur
Remove unused variable assignment.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
Changes from v1:
-Address code review comments from Sergei Shtylyov,
correct the commit message and subject line.
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);
/* Fill additional invoke cmd params */
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment
@ 2020-03-17 9:50 Rayagonda Kokatanur
2020-03-17 19:32 ` Tyler Hicks
0 siblings, 1 reply; 4+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-17 9:50 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, linux-kernel, BCM Kernel Feedback
Cc: Rayagonda Kokatanur
Remove unused variable assignment.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
Changes from v1:
- Address code review comment from Sergei Shtylyov,
Correct the commit message.
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);
/* Fill additional invoke cmd params */
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment
2020-03-17 9:50 Rayagonda Kokatanur
@ 2020-03-17 19:32 ` Tyler Hicks
0 siblings, 0 replies; 4+ messages in thread
From: Tyler Hicks @ 2020-03-17 19:32 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Rafał Miłecki, linux-mips, linux-kernel, BCM Kernel Feedback
On 2020-03-17 15:20:37, Rayagonda Kokatanur wrote:
> Remove unused variable assignment.
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Tyler
> ---
> Changes from v1:
> - Address code review comment from Sergei Shtylyov,
> Correct the commit message.
>
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>
> while (rbytes) {
> - nbytes = rbytes;
> -
> nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>
> /* Fill additional invoke cmd params */
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-23 7:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 7:02 [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment Rayagonda Kokatanur
-- strict thread matches above, loose matches on Subject: below --
2020-03-23 7:07 Rayagonda Kokatanur
2020-03-17 9:50 Rayagonda Kokatanur
2020-03-17 19:32 ` Tyler Hicks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).