* [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules
@ 2020-03-24 19:06 Vadym Kochan
2020-03-25 13:58 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Vadym Kochan @ 2020-03-24 19:06 UTC (permalink / raw)
To: Gregory CLEMENT, linux-kernel; +Cc: Vadym Kochan
Allow to add/del remap window by external modules at runtime.
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
drivers/bus/mvebu-mbus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 5b2a11a88951..3b443748a469 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -914,6 +914,7 @@ int mvebu_mbus_add_window_remap_by_id(unsigned int target,
return mvebu_mbus_alloc_window(s, base, size, remap, target, attribute);
}
+EXPORT_SYMBOL_GPL(mvebu_mbus_add_window_remap_by_id);
int mvebu_mbus_add_window_by_id(unsigned int target, unsigned int attribute,
phys_addr_t base, size_t size)
@@ -933,6 +934,7 @@ int mvebu_mbus_del_window(phys_addr_t base, size_t size)
mvebu_mbus_disable_window(&mbus_state, win);
return 0;
}
+EXPORT_SYMBOL_GPL(mvebu_mbus_del_window);
void mvebu_mbus_get_pcie_mem_aperture(struct resource *res)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules
2020-03-24 19:06 [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules Vadym Kochan
@ 2020-03-25 13:58 ` Christoph Hellwig
2020-04-07 15:12 ` Vadym Kochan
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2020-03-25 13:58 UTC (permalink / raw)
To: Vadym Kochan; +Cc: Gregory CLEMENT, linux-kernel
On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> Allow to add/del remap window by external modules at runtime.
Please send this together with your driver submission.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules
2020-03-25 13:58 ` Christoph Hellwig
@ 2020-04-07 15:12 ` Vadym Kochan
2020-04-08 6:15 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Vadym Kochan @ 2020-04-07 15:12 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Gregory CLEMENT, linux-kernel
Hi Christoph,
On Wed, Mar 25, 2020 at 06:58:01AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> > Allow to add/del remap window by external modules at runtime.
>
> Please send this together with your driver submission.
The driver itself is just servicing user process to configure io
windows via ioctl, so I think it is not so useful ?
Thanks,
Vadym Kochan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules
2020-04-07 15:12 ` Vadym Kochan
@ 2020-04-08 6:15 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-04-08 6:15 UTC (permalink / raw)
To: Vadym Kochan; +Cc: Christoph Hellwig, Gregory CLEMENT, linux-kernel
On Tue, Apr 07, 2020 at 06:12:19PM +0300, Vadym Kochan wrote:
> Hi Christoph,
>
> On Wed, Mar 25, 2020 at 06:58:01AM -0700, Christoph Hellwig wrote:
> > On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> > > Allow to add/del remap window by external modules at runtime.
> >
> > Please send this together with your driver submission.
>
> The driver itself is just servicing user process to configure io
> windows via ioctl, so I think it is not so useful ?
If you want the export in mainline your driver needs to be as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 6:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 19:06 [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules Vadym Kochan
2020-03-25 13:58 ` Christoph Hellwig
2020-04-07 15:12 ` Vadym Kochan
2020-04-08 6:15 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).