* [PATCH -next] f2fs: xattr.h: Make stub helpers inline
@ 2020-03-28 11:27 YueHaibing
2020-03-30 8:39 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-03-28 11:27 UTC (permalink / raw)
To: jaegeuk, chao, qkrwngud825; +Cc: linux-f2fs-devel, linux-kernel, YueHaibing
Fix gcc warnings:
In file included from fs/f2fs/dir.c:15:0:
fs/f2fs/xattr.h:157:13: warning: 'f2fs_destroy_xattr_caches' defined but not used [-Wunused-function]
static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { }
^~~~~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/xattr.h:156:12: warning: 'f2fs_init_xattr_caches' defined but not used [-Wunused-function]
static int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: a999150f4fe3 ("f2fs: use kmem_cache pool during inline xattr lookups")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/f2fs/xattr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/xattr.h b/fs/f2fs/xattr.h
index e471be77f8f0..938fcd20565d 100644
--- a/fs/f2fs/xattr.h
+++ b/fs/f2fs/xattr.h
@@ -153,8 +153,8 @@ static inline ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer,
{
return -EOPNOTSUPP;
}
-static int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
-static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { }
+static inline int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
+static inline void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { }
#endif
#ifdef CONFIG_F2FS_FS_SECURITY
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: xattr.h: Make stub helpers inline
2020-03-28 11:27 [PATCH -next] f2fs: xattr.h: Make stub helpers inline YueHaibing
@ 2020-03-30 8:39 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-03-30 8:39 UTC (permalink / raw)
To: YueHaibing, jaegeuk, chao, qkrwngud825; +Cc: linux-kernel, linux-f2fs-devel
On 2020/3/28 19:27, YueHaibing wrote:
> Fix gcc warnings:
>
> In file included from fs/f2fs/dir.c:15:0:
> fs/f2fs/xattr.h:157:13: warning: 'f2fs_destroy_xattr_caches' defined but not used [-Wunused-function]
> static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { }
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> fs/f2fs/xattr.h:156:12: warning: 'f2fs_init_xattr_caches' defined but not used [-Wunused-function]
> static int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: a999150f4fe3 ("f2fs: use kmem_cache pool during inline xattr lookups")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-30 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28 11:27 [PATCH -next] f2fs: xattr.h: Make stub helpers inline YueHaibing
2020-03-30 8:39 ` [f2fs-dev] " Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).