* [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask
@ 2020-03-29 2:42 Wei Yang
2020-03-29 4:00 ` John Hubbard
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yang @ 2020-03-29 2:42 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, jgg, david, jhubbard, bhe, Wei Yang
For all 0 nodemask_t, we have already define macro NODE_MASK_NONE.
Leverage this to define an all clear nodemask.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
v3: adjust the commit log a little
v2: use NODE_MASK_NONE as suggested by David Hildenbrand
---
mm/page_alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ef790dfad6aa..dfcf2682ed40 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
{
static int node_order[MAX_NUMNODES];
int node, load, nr_nodes = 0;
- nodemask_t used_mask;
+ nodemask_t used_mask = NODE_MASK_NONE;
int local_node, prev_node;
/* NUMA-aware ordering of nodes */
local_node = pgdat->node_id;
load = nr_online_nodes;
prev_node = local_node;
- nodes_clear(used_mask);
memset(node_order, 0, sizeof(node_order));
while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask
2020-03-29 2:42 [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask Wei Yang
@ 2020-03-29 4:00 ` John Hubbard
2020-03-29 6:09 ` Wei Yang
2020-03-30 15:00 ` David Hildenbrand
0 siblings, 2 replies; 4+ messages in thread
From: John Hubbard @ 2020-03-29 4:00 UTC (permalink / raw)
To: Wei Yang, akpm; +Cc: linux-mm, linux-kernel, jgg, david, bhe
On 3/28/20 7:42 PM, Wei Yang wrote:
> For all 0 nodemask_t, we have already define macro NODE_MASK_NONE.
> Leverage this to define an all clear nodemask.
It would be a little clearer if you used wording more like this:
Subject: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
Slightly simplify the code by initializing user_mask with
NODE_MASK_NONE, instead of later calling nodes_clear(). This saves
a line of code.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>
> ---
> v3: adjust the commit log a little
> v2: use NODE_MASK_NONE as suggested by David Hildenbrand
> ---
> mm/page_alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ef790dfad6aa..dfcf2682ed40 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
> {
> static int node_order[MAX_NUMNODES];
> int node, load, nr_nodes = 0;
> - nodemask_t used_mask;
> + nodemask_t used_mask = NODE_MASK_NONE;
> int local_node, prev_node;
>
> /* NUMA-aware ordering of nodes */
> local_node = pgdat->node_id;
> load = nr_online_nodes;
> prev_node = local_node;
> - nodes_clear(used_mask);
>
> memset(node_order, 0, sizeof(node_order));
> while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
>
Honestly, I don't think it's really worth doing a patch for this, but
there's nothing wrong with the diff, so:
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask
2020-03-29 4:00 ` John Hubbard
@ 2020-03-29 6:09 ` Wei Yang
2020-03-30 15:00 ` David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: Wei Yang @ 2020-03-29 6:09 UTC (permalink / raw)
To: John Hubbard; +Cc: Wei Yang, akpm, linux-mm, linux-kernel, jgg, david, bhe
On Sat, Mar 28, 2020 at 09:00:26PM -0700, John Hubbard wrote:
>On 3/28/20 7:42 PM, Wei Yang wrote:
>> For all 0 nodemask_t, we have already define macro NODE_MASK_NONE.
>> Leverage this to define an all clear nodemask.
>
>It would be a little clearer if you used wording more like this:
>
>Subject: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
>
>Slightly simplify the code by initializing user_mask with
>NODE_MASK_NONE, instead of later calling nodes_clear(). This saves
>a line of code.
>
Thanks, the wording is better.
>
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>>
>> ---
>> v3: adjust the commit log a little
>> v2: use NODE_MASK_NONE as suggested by David Hildenbrand
>> ---
>> mm/page_alloc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index ef790dfad6aa..dfcf2682ed40 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
>> {
>> static int node_order[MAX_NUMNODES];
>> int node, load, nr_nodes = 0;
>> - nodemask_t used_mask;
>> + nodemask_t used_mask = NODE_MASK_NONE;
>> int local_node, prev_node;
>> /* NUMA-aware ordering of nodes */
>> local_node = pgdat->node_id;
>> load = nr_online_nodes;
>> prev_node = local_node;
>> - nodes_clear(used_mask);
>> memset(node_order, 0, sizeof(node_order));
>> while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
>>
>
>Honestly, I don't think it's really worth doing a patch for this, but
>there's nothing wrong with the diff, so:
>
>Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>
Thanks.
>
>thanks,
>--
>John Hubbard
>NVIDIA
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask
2020-03-29 4:00 ` John Hubbard
2020-03-29 6:09 ` Wei Yang
@ 2020-03-30 15:00 ` David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-03-30 15:00 UTC (permalink / raw)
To: John Hubbard, Wei Yang, akpm; +Cc: linux-mm, linux-kernel, jgg, bhe
On 29.03.20 06:00, John Hubbard wrote:
> On 3/28/20 7:42 PM, Wei Yang wrote:
>> For all 0 nodemask_t, we have already define macro NODE_MASK_NONE.
>> Leverage this to define an all clear nodemask.
>
> It would be a little clearer if you used wording more like this:
>
> Subject: [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
>
> Slightly simplify the code by initializing user_mask with
> NODE_MASK_NONE, instead of later calling nodes_clear(). This saves
> a line of code.
>
>
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>>
>> ---
>> v3: adjust the commit log a little
>> v2: use NODE_MASK_NONE as suggested by David Hildenbrand
>> ---
>> mm/page_alloc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index ef790dfad6aa..dfcf2682ed40 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
>> {
>> static int node_order[MAX_NUMNODES];
>> int node, load, nr_nodes = 0;
>> - nodemask_t used_mask;
>> + nodemask_t used_mask = NODE_MASK_NONE;
>> int local_node, prev_node;
>>
>> /* NUMA-aware ordering of nodes */
>> local_node = pgdat->node_id;
>> load = nr_online_nodes;
>> prev_node = local_node;
>> - nodes_clear(used_mask);
>>
>> memset(node_order, 0, sizeof(node_order));
>> while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
>>
>
> Honestly, I don't think it's really worth doing a patch for this, but
> there's nothing wrong with the diff, so:
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
With the changed subject/description
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-30 15:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-29 2:42 [Patch v3] mm/page_alloc.c: use NODE_MASK_NONE define used_mask Wei Yang
2020-03-29 4:00 ` John Hubbard
2020-03-29 6:09 ` Wei Yang
2020-03-30 15:00 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).