* [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector
@ 2020-03-29 22:22 Vasily Khoruzhick
2020-03-29 23:29 ` Jernej Škrabec
2020-04-14 17:53 ` Jernej Škrabec
0 siblings, 2 replies; 3+ messages in thread
From: Vasily Khoruzhick @ 2020-03-29 22:22 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Torsten Duwe,
Maxime Ripard, Icenowy Zheng, Sam Ravnborg, Stephen Rothwell,
Samuel Holland, dri-devel, linux-kernel
Cc: Vasily Khoruzhick
Some drivers (e.g. sun4i-drm) need this info to decide whether they
need to enable dithering. Currently driver reports what panel supports
and if panel supports 8 we don't get dithering enabled.
Hardcode BPC to 6 for now since that's the only BPC
that driver supports.
Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index d7cb10c599a3..ea5de9395662 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector *connector)
num_modes += drm_add_edid_modes(connector, anx6345->edid);
+ /* Driver currently supports only 6bpc */
+ connector->display_info.bpc = 6;
+
unlock:
if (power_off)
anx6345_poweroff(anx6345);
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector
2020-03-29 22:22 [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector Vasily Khoruzhick
@ 2020-03-29 23:29 ` Jernej Škrabec
2020-04-14 17:53 ` Jernej Škrabec
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2020-03-29 23:29 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
David Airlie, Daniel Vetter, Torsten Duwe, Maxime Ripard,
Icenowy Zheng, Sam Ravnborg, Stephen Rothwell, Samuel Holland,
dri-devel, linux-kernel, Vasily Khoruzhick
Cc: Vasily Khoruzhick
Hi!
Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BPC to 6 for now since that's the only BPC
> that driver supports.
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index
> d7cb10c599a3..ea5de9395662 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector
> *connector)
>
> num_modes += drm_add_edid_modes(connector, anx6345->edid);
>
> + /* Driver currently supports only 6bpc */
> + connector->display_info.bpc = 6;
> +
> unlock:
> if (power_off)
> anx6345_poweroff(anx6345);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drm/bridge: anx6345: set correct BPC for display_info of connector
2020-03-29 22:22 [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector Vasily Khoruzhick
2020-03-29 23:29 ` Jernej Škrabec
@ 2020-04-14 17:53 ` Jernej Škrabec
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2020-04-14 17:53 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
David Airlie, Daniel Vetter, Torsten Duwe, Maxime Ripard,
Icenowy Zheng, Sam Ravnborg, Stephen Rothwell, Samuel Holland,
dri-devel, linux-kernel, Vasily Khoruzhick
Cc: Vasily Khoruzhick
Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BPC to 6 for now since that's the only BPC
> that driver supports.
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Applied to drm-misc-fixes. Thanks!
Best regards,
Jernej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-29 22:22 [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector Vasily Khoruzhick
2020-03-29 23:29 ` Jernej Škrabec
2020-04-14 17:53 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).