* [PATCH] staging: android: ion: Fix parenthesis alignment
@ 2020-04-02 1:25 John B. Wyatt IV
2020-04-02 1:45 ` [Outreachy kernel] " Stefano Brivio
2020-04-02 7:11 ` Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: John B. Wyatt IV @ 2020-04-02 1:25 UTC (permalink / raw)
To: outreachy-kernel, Laura Abbott, Sumit Semwal, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, devel, dri-devel,
linaro-mm-sig, linux-kernel
Cc: John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
drivers/staging/android/ion/ion_page_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index f85ec5b16b65..0198b886d906 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -37,7 +37,7 @@ static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page)
}
mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
- 1 << pool->order);
+ 1 << pool->order);
mutex_unlock(&pool->mutex);
}
@@ -57,7 +57,7 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)
list_del(&page->lru);
mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
- -(1 << pool->order));
+ -(1 << pool->order));
return page;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: android: ion: Fix parenthesis alignment
2020-04-02 1:25 [PATCH] staging: android: ion: Fix parenthesis alignment John B. Wyatt IV
@ 2020-04-02 1:45 ` Stefano Brivio
2020-04-02 7:11 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2020-04-02 1:45 UTC (permalink / raw)
To: John B. Wyatt IV
Cc: outreachy-kernel, Laura Abbott, Sumit Semwal, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, devel, dri-devel,
linaro-mm-sig, linux-kernel
On Wed, 1 Apr 2020 18:25:15 -0700
"John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: android: ion: Fix parenthesis alignment
2020-04-02 1:25 [PATCH] staging: android: ion: Fix parenthesis alignment John B. Wyatt IV
2020-04-02 1:45 ` [Outreachy kernel] " Stefano Brivio
@ 2020-04-02 7:11 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2020-04-02 7:11 UTC (permalink / raw)
To: John B. Wyatt IV
Cc: outreachy-kernel, Laura Abbott, Sumit Semwal, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, devel, dri-devel,
linaro-mm-sig, linux-kernel
On Wed, 1 Apr 2020, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?
julia
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> drivers/staging/android/ion/ion_page_pool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index f85ec5b16b65..0198b886d906 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -37,7 +37,7 @@ static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page)
> }
>
> mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
> - 1 << pool->order);
> + 1 << pool->order);
> mutex_unlock(&pool->mutex);
> }
>
> @@ -57,7 +57,7 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)
>
> list_del(&page->lru);
> mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
> - -(1 << pool->order));
> + -(1 << pool->order));
> return page;
> }
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200402012515.429329-1-jbwyatt4%40gmail.com.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-02 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 1:25 [PATCH] staging: android: ion: Fix parenthesis alignment John B. Wyatt IV
2020-04-02 1:45 ` [Outreachy kernel] " Stefano Brivio
2020-04-02 7:11 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).