linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, hsinyi@chromium.org,
	geert+renesas@glider.be, swboyd@chromium.org, robh@kernel.org,
	tytso@mit.edu
Subject: Re: [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen
Date: Thu, 2 Apr 2020 09:13:47 +0100	[thread overview]
Message-ID: <20200402081346.GA2548@willie-the-truck> (raw)
In-Reply-To: <20200402033640.12465-1-f.fainelli@gmail.com>

Hi Florian,

On Wed, Apr 01, 2020 at 08:36:40PM -0700, Florian Fainelli wrote:
> The /chosen node can have a 'rng-seed' property read as a u32 quantity
> which would contain a random number provided by the boot agent. This is
> useful in configurations where the kernel does not have access to a
> random number generator.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  Documentation/devicetree/bindings/chosen.txt | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Thanks for doing this; I realised it was undocumented the other day when I
tried to look it up myself.

> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
> index 45e79172a646..126b31eecfeb 100644
> --- a/Documentation/devicetree/bindings/chosen.txt
> +++ b/Documentation/devicetree/bindings/chosen.txt
> @@ -28,6 +28,19 @@ mode) when EFI_RNG_PROTOCOL is supported, it will be overwritten by
>  the Linux EFI stub (which will populate the property itself, using
>  EFI_RNG_PROTOCOL).
>  
> +rng-seed
> +--------
> +
> +This property is used to initialize the kernel's entropy pool from a
> +trusted boot agent capable of providing a random number. It is parsed
> +as a u32 value, e.g.

Are you sure about this being limited to a u32 value? I thought you could
pass an arbitrary-length value here.

Will

  reply	other threads:[~2020-04-02  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  3:36 [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen Florian Fainelli
2020-04-02  8:13 ` Will Deacon [this message]
2020-04-02 13:35   ` Rob Herring
2020-04-02 18:07   ` Florian Fainelli
2020-04-03 16:21     ` Hsin-Yi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200402081346.GA2548@willie-the-truck \
    --to=will@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=hsinyi@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).