From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Will Deacon <will@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
geert+renesas@glider.be, Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh@kernel.org>, "Theodore Y. Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen
Date: Sat, 4 Apr 2020 00:21:13 +0800 [thread overview]
Message-ID: <CAJMQK-i06+zG30tzPMgKGrrC4gcrUOcnecaBLP+uMTzfaFZu7A@mail.gmail.com> (raw)
In-Reply-To: <c380729c-9cba-6639-de9b-64d3d0896110@gmail.com>
On Fri, Apr 3, 2020 at 2:07 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > Are you sure about this being limited to a u32 value? I thought you could
> > pass an arbitrary-length value here.
>
> Humm indeed, we can pass an arbitrary value, I completely conflated the
> type of "l" here:
>
> int l;
> ...
> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>
> with how much we would be reading from the property, which is complete
> nonsense. Out of curiosity, what property length do platforms typically
> populate?
> --
> Florian
64 bytes should be able to init crng. (pass CRNG_INIT_CNT_THRESH)
prev parent reply other threads:[~2020-04-03 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 3:36 [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen Florian Fainelli
2020-04-02 8:13 ` Will Deacon
2020-04-02 13:35 ` Rob Herring
2020-04-02 18:07 ` Florian Fainelli
2020-04-03 16:21 ` Hsin-Yi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMQK-i06+zG30tzPMgKGrrC4gcrUOcnecaBLP+uMTzfaFZu7A@mail.gmail.com \
--to=hsinyi@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).