* [PATCH] MIPS: TXx9::x Fix Kconfig warnings:
@ 2020-04-03 9:42 YueHaibing
2020-04-03 9:49 ` [PATCH v2] MIPS: TXx9: Fix Kconfig warnings YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-04-03 9:42 UTC (permalink / raw)
To: tsbogend, yuehaibing; +Cc: linux-mips, linux-kernel, ralf
If TTY and SND is not n, we got this warnings:
WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SOC_TX3927 [=y]
WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SOC_TX4938 [=y]
Only dependencies is enabled, they can be enabled, so
use 'imply' instead of 'select' to fix this.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/mips/txx9/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/mips/txx9/Kconfig b/arch/mips/txx9/Kconfig
index 9a22a182b7a4..85c4c121c71f 100644
--- a/arch/mips/txx9/Kconfig
+++ b/arch/mips/txx9/Kconfig
@@ -58,7 +58,7 @@ config TOSHIBA_RBTX4939
config SOC_TX3927
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select GPIO_TXX9
@@ -66,30 +66,30 @@ config SOC_TX3927
config SOC_TX4927
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select PCI_TX4927
select GPIO_TXX9
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config SOC_TX4938
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select PCI_TX4927
select GPIO_TXX9
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config SOC_TX4939
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select PCI_TX4927
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config TXX9_7SEGLED
bool
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] MIPS: TXx9: Fix Kconfig warnings
2020-04-03 9:42 [PATCH] MIPS: TXx9::x Fix Kconfig warnings: YueHaibing
@ 2020-04-03 9:49 ` YueHaibing
2020-04-16 16:36 ` Thomas Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-04-03 9:49 UTC (permalink / raw)
To: tsbogend, yuehaibing; +Cc: linux-mips, linux-kernel, ralf
If TTY and SND is not n, we got this warnings:
WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SOC_TX3927 [=y]
WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SOC_TX4938 [=y]
Only dependencies is enabled, they can be enabled, so
use 'imply' instead of 'select' to fix this.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix patch title
---
arch/mips/txx9/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/mips/txx9/Kconfig b/arch/mips/txx9/Kconfig
index 9a22a182b7a4..85c4c121c71f 100644
--- a/arch/mips/txx9/Kconfig
+++ b/arch/mips/txx9/Kconfig
@@ -58,7 +58,7 @@ config TOSHIBA_RBTX4939
config SOC_TX3927
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select GPIO_TXX9
@@ -66,30 +66,30 @@ config SOC_TX3927
config SOC_TX4927
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select PCI_TX4927
select GPIO_TXX9
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config SOC_TX4938
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select IRQ_TXX9
select PCI_TX4927
select GPIO_TXX9
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config SOC_TX4939
bool
select CEVT_TXX9
- select HAS_TXX9_SERIAL
+ imply HAS_TXX9_SERIAL
select HAVE_PCI
select PCI_TX4927
- select HAS_TXX9_ACLC
+ imply HAS_TXX9_ACLC
config TXX9_7SEGLED
bool
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MIPS: TXx9: Fix Kconfig warnings
2020-04-03 9:49 ` [PATCH v2] MIPS: TXx9: Fix Kconfig warnings YueHaibing
@ 2020-04-16 16:36 ` Thomas Bogendoerfer
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2020-04-16 16:36 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-mips, linux-kernel, ralf
On Fri, Apr 03, 2020 at 05:49:04PM +0800, YueHaibing wrote:
> If TTY and SND is not n, we got this warnings:
>
> WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
> Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - SOC_TX3927 [=y]
>
> WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL
> Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - SOC_TX4938 [=y]
>
> Only dependencies is enabled, they can be enabled, so
> use 'imply' instead of 'select' to fix this.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: fix patch title
> ---
> arch/mips/txx9/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 9:42 [PATCH] MIPS: TXx9::x Fix Kconfig warnings: YueHaibing
2020-04-03 9:49 ` [PATCH v2] MIPS: TXx9: Fix Kconfig warnings YueHaibing
2020-04-16 16:36 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).