From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Julien Thierry <jthierry@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
raphael.gault@arm.com
Subject: Re: [PATCH v2 10/10] objtool: Support multiple stack_op per instruction
Date: Fri, 3 Apr 2020 09:55:15 -0500 [thread overview]
Message-ID: <20200403145515.ywubrfbg44a22orf@treble> (raw)
In-Reply-To: <3b3f07b3-172b-0560-96c7-d9386e3cab23@redhat.com>
On Fri, Apr 03, 2020 at 09:01:46AM +0100, Julien Thierry wrote:
>
>
> On 4/2/20 6:54 PM, Josh Poimboeuf wrote:
> > On Fri, Mar 27, 2020 at 03:28:47PM +0000, Julien Thierry wrote:
> > > @@ -127,6 +129,10 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
> > > if (insn.sib.nbytes)
> > > sib = insn.sib.bytes[0];
> > > + op = calloc(1, sizeof(*op));
> > > + if (!op)
> > > + return -1;
> > > +
> >
> > Why not malloc()?
> >
>
> It's just that previsously, stack_op was part of the instruction structure
> and was initialized to all 0 in decode_instructions(). Now that it's created
> here, I assumed it would be better to have the same thing here and
> initialized the new stack_op to all 0.
>
> Do you prefer to have an explicit malloc() + memset()?
Maybe just add a comment that calloc() is equivalent to malloc() +
memset() zero, for us user-space neophytes :-)
--
Josh
next prev parent reply other threads:[~2020-04-03 14:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 15:28 [PATCH v2 00/10] Objtool updates for easier portability Julien Thierry
2020-03-27 15:28 ` [PATCH v2 01/10] objtool: Move header sync-check ealier in build Julien Thierry
2020-04-01 12:32 ` Miroslav Benes
2020-04-01 12:44 ` Julien Thierry
2020-04-01 12:55 ` Miroslav Benes
2020-04-02 17:12 ` Josh Poimboeuf
2020-04-02 17:17 ` Josh Poimboeuf
2020-03-27 15:28 ` [PATCH v2 02/10] objtool: check: Remove redundant checks on operand type Julien Thierry
2020-03-27 15:28 ` [PATCH v2 03/10] objtool: check: Clean instruction state before each function validation Julien Thierry
2020-03-27 15:28 ` [PATCH v2 04/10] objtool: check: Ignore empty alternative groups Julien Thierry
2020-04-01 12:53 ` Miroslav Benes
2020-04-01 13:43 ` Julien Thierry
2020-04-01 13:48 ` Miroslav Benes
2020-03-27 15:28 ` [PATCH v2 05/10] objtool: check: Remove check preventing branches within alternative Julien Thierry
2020-05-01 18:22 ` [tip: objtool/core] objtool: " tip-bot2 for Julien Thierry
2020-03-27 15:28 ` [PATCH v2 06/10] objtool: check: Use arch specific values in restore_reg() Julien Thierry
2020-03-27 15:28 ` [PATCH v2 07/10] objtool: check: Allow save/restore hint in non standard function symbols Julien Thierry
2020-04-01 13:54 ` Miroslav Benes
2020-04-01 14:06 ` Julien Thierry
2020-03-27 15:28 ` [PATCH v2 08/10] objtool: Add abstraction for computation of symbols offsets Julien Thierry
2020-03-27 15:28 ` [PATCH v2 09/10] objtool: Split generic and arch specific CFI definitions Julien Thierry
2020-03-27 15:28 ` [PATCH v2 10/10] objtool: Support multiple stack_op per instruction Julien Thierry
2020-04-02 17:54 ` Josh Poimboeuf
2020-04-02 18:25 ` Peter Zijlstra
2020-04-03 8:01 ` Julien Thierry
2020-04-03 14:55 ` Josh Poimboeuf [this message]
2020-04-22 22:24 ` [tip: objtool/core] " tip-bot2 for Julien Thierry
2020-04-23 7:49 ` tip-bot2 for Julien Thierry
2020-04-23 11:15 ` Peter Zijlstra
2020-04-02 17:58 ` [PATCH v2 00/10] Objtool updates for easier portability Josh Poimboeuf
2020-04-02 18:30 ` Peter Zijlstra
2020-04-03 7:17 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403145515.ywubrfbg44a22orf@treble \
--to=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=raphael.gault@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).