From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] clocksource: Add Tegra186 timers support
Date: Fri, 3 Apr 2020 22:15:41 +0200 [thread overview]
Message-ID: <20200403201541.GC282587@ulmo> (raw)
In-Reply-To: <a982d831-fc59-f705-8f8a-9370b897adb8@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
On Fri, Apr 03, 2020 at 07:33:24PM +0300, Dmitry Osipenko wrote:
> 01.04.2020 01:19, Thierry Reding пишет:
> ...
> > +static int tegra186_timer_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct tegra186_timer *tegra;
> > + int err;
> > +
> > + tegra = devm_kzalloc(dev, sizeof(*tegra), GFP_KERNEL);
> > + if (!tegra)
> > + return -ENOMEM;
> > +
> > + tegra->soc = of_device_get_match_data(dev);
> > + dev_set_drvdata(dev, tegra);
> > + tegra->dev = dev;
> > +
> > + tegra->regs = devm_platform_ioremap_resource(pdev, 0);
> > + if (IS_ERR(tegra->regs))
> > + return PTR_ERR(tegra->regs);
> > +
> > + err = platform_get_irq(pdev, 0);
> > + if (err < 0) {
> > + dev_err(dev, "failed to get interrupt #0: %d\n", err);
> > + return err;
> > + }
> > +
> > + tegra->irq = err;
> > +
> > + err = devm_request_irq(dev, tegra->irq, tegra186_timer_irq,
> > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> > + "tegra186-timer", tegra);
>
> Looks like there is no need to store tegra->irq in the struct
> tegra186_timer.
After moving devm_request_irq() to a later point in ->probe() we now
have to store it somewhere because err is being reused. But I can store
it in a local variable instead.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-03 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 22:19 [PATCH v2 0/7] clocksource: Add NVIDIA Tegra186 timers support Thierry Reding
2020-03-31 22:19 ` [PATCH v2 1/7] dt-bindings: timer: Add bindings for NVIDIA Tegra186 timers Thierry Reding
2020-03-31 22:19 ` [PATCH v2 2/7] clocksource: Add Tegra186 timers support Thierry Reding
2020-04-03 16:14 ` Dmitry Osipenko
2020-04-03 20:13 ` Thierry Reding
2020-04-03 16:24 ` Dmitry Osipenko
2020-04-03 20:14 ` Thierry Reding
2020-04-03 16:33 ` Dmitry Osipenko
2020-04-03 20:15 ` Thierry Reding [this message]
2020-03-31 22:19 ` [PATCH v2 3/7] arm64: tegra: Order nodes by unit-address on Tegra194 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 4/7] arm64: tegra: Add native timer support on Tegra186 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 5/7] arm64: tegra: Enable native timers on Jetson TX2 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 6/7] arm64: tegra: Add native timer support on Tegra194 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 7/7] arm64: tegra: Enable native timers on Jetson AGX Xavier Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403201541.GC282587@ulmo \
--to=thierry.reding@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).