From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] clocksource: Add Tegra186 timers support
Date: Fri, 3 Apr 2020 19:14:33 +0300 [thread overview]
Message-ID: <de97ce0c-3fa3-9f13-2b0e-f4369f94e113@gmail.com> (raw)
In-Reply-To: <20200331221914.2966407-3-thierry.reding@gmail.com>
01.04.2020 01:19, Thierry Reding пишет:
...
> +static void tmr_writel(struct tegra186_tmr *tmr, u32 value, unsigned int offset)
> +{
> + writel(value, tmr->regs + offset);
relaxed?
> +}
> +
> +static void wdt_writel(struct tegra186_wdt *wdt, u32 value, unsigned int offset)
> +{
> + writel(value, wdt->regs + offset);
relaxed?
> +}
> +
> +static u32 wdt_readl(struct tegra186_wdt *wdt, unsigned int offset)
> +{
> + return readl(wdt->regs + offset);
relaxed?
> +}
...
> +static irqreturn_t tegra186_timer_irq(int irq, void *data)
> +{
> + struct tegra186_timer *tegra = data;
> +
> + if (tegra->wdt) {
Why this check is needed? Please see more below in regards to
devm_request_irq().
> + tegra186_wdt_disable(tegra->wdt);
> + tegra186_wdt_enable(tegra->wdt);
> + }
> +
> + return IRQ_HANDLED;
> +}
> +
> +static int tegra186_timer_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct tegra186_timer *tegra;
> + int err;
> +
> + tegra = devm_kzalloc(dev, sizeof(*tegra), GFP_KERNEL);
> + if (!tegra)
> + return -ENOMEM;
> +
> + tegra->soc = of_device_get_match_data(dev);
> + dev_set_drvdata(dev, tegra);
> + tegra->dev = dev;
> +
> + tegra->regs = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(tegra->regs))
> + return PTR_ERR(tegra->regs);
> +
> + err = platform_get_irq(pdev, 0);
> + if (err < 0) {
> + dev_err(dev, "failed to get interrupt #0: %d\n", err);
Duplicated error message isn't needed for platform_get_irq().
> + return err;
> + }
> +
> + tegra->irq = err;
> +
> + err = devm_request_irq(dev, tegra->irq, tegra186_timer_irq,
> + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
Why IRQF_ONESHOT?
And IRQF_TRIGGER_HIGH?.. the interrupt-level should come from the
device-tree.
> + "tegra186-timer", tegra);
> + if (err < 0) {
> + dev_err(dev, "failed to request IRQ#%u: %d\n", tegra->irq, err);
> + return err;
> + }
Interrupt should be requested at the end of tegra186_timer_probe(),
otherwise probe order isn't correct, leading to a potential race conditions.
> + /* create a watchdog using a preconfigured timer */
> + tegra->wdt = tegra186_wdt_create(tegra, 0);
> + if (IS_ERR(tegra->wdt)) {
> + err = PTR_ERR(tegra->wdt);
> + dev_err(dev, "failed to create WDT: %d\n", err);
> + return err;
> + }
> +
> + err = tegra186_timer_tsc_init(tegra);
> + if (err < 0) {
> + dev_err(dev, "failed to register TSC counter: %d\n", err);
> + return err;
> + }
> +
> + err = tegra186_timer_osc_init(tegra);
> + if (err < 0) {
> + dev_err(dev, "failed to register OSC counter: %d\n", err);
> + goto unregister_tsc;
> + }
> +
> + err = tegra186_timer_usec_init(tegra);
> + if (err < 0) {
> + dev_err(dev, "failed to register USEC counter: %d\n", err);
> + goto unregister_osc;
> + }
> +
> + return 0;
> +
> +unregister_osc:
> + clocksource_unregister(&tegra->osc);
> +unregister_tsc:
> + clocksource_unregister(&tegra->tsc);
Looks like there is an opportunity for devm_clocksource_register_hz().
> + return err;
> +}
> +
> +static int tegra186_timer_remove(struct platform_device *pdev)
> +{
> + struct tegra186_timer *tegra = platform_get_drvdata(pdev);
> +
> + clocksource_unregister(&tegra->usec);
> + clocksource_unregister(&tegra->osc);
> + clocksource_unregister(&tegra->tsc);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused tegra186_timer_suspend(struct device *dev)
> +{
> + struct tegra186_timer *tegra = dev_get_drvdata(dev);
> +
> + if (tegra->wdt)
> + tegra186_wdt_disable(tegra->wdt);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused tegra186_timer_resume(struct device *dev)
> +{
> + struct tegra186_timer *tegra = dev_get_drvdata(dev);
> +
> + if (tegra->wdt)
Could tegra->wdt ever be NULL?
> + tegra186_wdt_enable(tegra->wdt);
> +
> + return 0;
> +}
next prev parent reply other threads:[~2020-04-03 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 22:19 [PATCH v2 0/7] clocksource: Add NVIDIA Tegra186 timers support Thierry Reding
2020-03-31 22:19 ` [PATCH v2 1/7] dt-bindings: timer: Add bindings for NVIDIA Tegra186 timers Thierry Reding
2020-03-31 22:19 ` [PATCH v2 2/7] clocksource: Add Tegra186 timers support Thierry Reding
2020-04-03 16:14 ` Dmitry Osipenko [this message]
2020-04-03 20:13 ` Thierry Reding
2020-04-03 16:24 ` Dmitry Osipenko
2020-04-03 20:14 ` Thierry Reding
2020-04-03 16:33 ` Dmitry Osipenko
2020-04-03 20:15 ` Thierry Reding
2020-03-31 22:19 ` [PATCH v2 3/7] arm64: tegra: Order nodes by unit-address on Tegra194 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 4/7] arm64: tegra: Add native timer support on Tegra186 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 5/7] arm64: tegra: Enable native timers on Jetson TX2 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 6/7] arm64: tegra: Add native timer support on Tegra194 Thierry Reding
2020-03-31 22:19 ` [PATCH v2 7/7] arm64: tegra: Enable native timers on Jetson AGX Xavier Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de97ce0c-3fa3-9f13-2b0e-f4369f94e113@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).