* [PATCH] qtnfmac: Simplify code in _attach functions
@ 2020-04-07 19:32 Christophe JAILLET
2020-04-07 19:48 ` Sergey Matyukevich
2020-04-14 15:09 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-04-07 19:32 UTC (permalink / raw)
To: imitsyanko, avinashp, smatyukevich, kvalo, davem, huangfq.daxian
Cc: linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
Keep the code simple.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 +-
drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c
index dbb241106d8a..eb67b66b846b 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c
@@ -286,7 +286,7 @@ static int pearl_skb2rbd_attach(struct qtnf_pcie_pearl_state *ps, u16 index)
struct sk_buff *skb;
dma_addr_t paddr;
- skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC);
+ skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE);
if (!skb) {
priv->rx_skb[index] = NULL;
return -ENOMEM;
diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c
index dbf3c5fd751f..d1b850aa4657 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c
@@ -247,7 +247,7 @@ topaz_skb2rbd_attach(struct qtnf_pcie_topaz_state *ts, u16 index, u32 wrap)
struct sk_buff *skb;
dma_addr_t paddr;
- skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC);
+ skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE);
if (!skb) {
ts->base.rx_skb[index] = NULL;
return -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qtnfmac: Simplify code in _attach functions
2020-04-07 19:32 [PATCH] qtnfmac: Simplify code in _attach functions Christophe JAILLET
@ 2020-04-07 19:48 ` Sergey Matyukevich
2020-04-14 15:09 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matyukevich @ 2020-04-07 19:48 UTC (permalink / raw)
To: Christophe JAILLET
Cc: imitsyanko, avinashp, smatyukevich, kvalo, davem, huangfq.daxian,
linux-wireless, netdev, linux-kernel, kernel-janitors
Hello Christophe,
> There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
> Keep the code simple.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks for cleaning this up!
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards,
Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qtnfmac: Simplify code in _attach functions
2020-04-07 19:32 [PATCH] qtnfmac: Simplify code in _attach functions Christophe JAILLET
2020-04-07 19:48 ` Sergey Matyukevich
@ 2020-04-14 15:09 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-04-14 15:09 UTC (permalink / raw)
To: Christophe JAILLET
Cc: imitsyanko, avinashp, smatyukevich, davem, huangfq.daxian,
linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
> Keep the code simple.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
c960e2b384ef qtnfmac: Simplify code in _attach functions
--
https://patchwork.kernel.org/patch/11478939/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 19:32 [PATCH] qtnfmac: Simplify code in _attach functions Christophe JAILLET
2020-04-07 19:48 ` Sergey Matyukevich
2020-04-14 15:09 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).