From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Hui Song <hui.song_1@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1] gpio: mpc8xxx: Add shutdown function.
Date: Wed, 8 Apr 2020 11:55:30 +0100 [thread overview]
Message-ID: <20200408105530.GR25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200408102118.17572-1-hui.song_1@nxp.com>
On Wed, Apr 08, 2020 at 06:21:17PM +0800, Hui Song wrote:
> From: Song Hui <hui.song_1@nxp.com>
>
> The shutdown function needed to make interrupt handler to be NULL
> when kexec execute.
>
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
Please improve the commit message. You describe what change the patch
is making (which we can see from reading the patch), but you don't
explain why it is necessary, or really what problem the patch is
solving. I'm not aware of other implementations needing this for
kexec to work.
Thanks.
> ---
> drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index 604dfec..a24e6c5 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static int mpc8xxx_shutdown(struct platform_device *pdev)
> +{
> + struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
> +
> + if (mpc8xxx_gc->irq) {
> + irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
> + irq_domain_remove(mpc8xxx_gc->irq);
> + }
> +
> + return 0;
> +}
> static struct platform_driver mpc8xxx_plat_driver = {
> .probe = mpc8xxx_probe,
> .remove = mpc8xxx_remove,
> + .shutdown = mpc8xxx_shutdown,
> .driver = {
> .name = "gpio-mpc8xxx",
> .of_match_table = mpc8xxx_gpio_ids,
> --
> 2.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-04-08 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 10:21 [PATCH v1] gpio: mpc8xxx: Add shutdown function Hui Song
2020-04-08 10:21 ` [PATCH] " Hui Song
2020-04-08 10:55 ` Russell King - ARM Linux admin [this message]
2020-04-08 10:55 [PATCH v1] " Hui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408105530.GR25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.song_1@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).