* [PATCH v1] gpio: mpc8xxx: Add shutdown function.
@ 2020-04-08 10:21 Hui Song
2020-04-08 10:21 ` [PATCH] " Hui Song
2020-04-08 10:55 ` [PATCH v1] " Russell King - ARM Linux admin
0 siblings, 2 replies; 4+ messages in thread
From: Hui Song @ 2020-04-08 10:21 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Linus Walleij,
Bartosz Golaszewski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio, Song Hui
From: Song Hui <hui.song_1@nxp.com>
The shutdown function needed to make interrupt handler to be NULL
when kexec execute.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..a24e6c5 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev)
return 0;
}
+static int mpc8xxx_shutdown(struct platform_device *pdev)
+{
+ struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
+
+ if (mpc8xxx_gc->irq) {
+ irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
+ irq_domain_remove(mpc8xxx_gc->irq);
+ }
+
+ return 0;
+}
static struct platform_driver mpc8xxx_plat_driver = {
.probe = mpc8xxx_probe,
.remove = mpc8xxx_remove,
+ .shutdown = mpc8xxx_shutdown,
.driver = {
.name = "gpio-mpc8xxx",
.of_match_table = mpc8xxx_gpio_ids,
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] gpio: mpc8xxx: Add shutdown function.
2020-04-08 10:21 [PATCH v1] gpio: mpc8xxx: Add shutdown function Hui Song
@ 2020-04-08 10:21 ` Hui Song
2020-04-08 10:55 ` [PATCH v1] " Russell King - ARM Linux admin
1 sibling, 0 replies; 4+ messages in thread
From: Hui Song @ 2020-04-08 10:21 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Linus Walleij,
Bartosz Golaszewski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio, Song Hui
From: Song Hui <hui.song_1@nxp.com>
The shutdown function needed to make interrupt handler to be NULL
when kexec execute.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..a24e6c5 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev)
return 0;
}
+static int mpc8xxx_shutdown(struct platform_device *pdev)
+{
+ struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
+
+ if (mpc8xxx_gc->irq) {
+ irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
+ irq_domain_remove(mpc8xxx_gc->irq);
+ }
+
+ return 0;
+}
static struct platform_driver mpc8xxx_plat_driver = {
.probe = mpc8xxx_probe,
.remove = mpc8xxx_remove,
+ .shutdown = mpc8xxx_shutdown,
.driver = {
.name = "gpio-mpc8xxx",
.of_match_table = mpc8xxx_gpio_ids,
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio: mpc8xxx: Add shutdown function.
2020-04-08 10:21 [PATCH v1] gpio: mpc8xxx: Add shutdown function Hui Song
2020-04-08 10:21 ` [PATCH] " Hui Song
@ 2020-04-08 10:55 ` Russell King - ARM Linux admin
1 sibling, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux admin @ 2020-04-08 10:55 UTC (permalink / raw)
To: Hui Song
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-kernel, linux-arm-kernel,
linux-gpio
On Wed, Apr 08, 2020 at 06:21:17PM +0800, Hui Song wrote:
> From: Song Hui <hui.song_1@nxp.com>
>
> The shutdown function needed to make interrupt handler to be NULL
> when kexec execute.
>
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
Please improve the commit message. You describe what change the patch
is making (which we can see from reading the patch), but you don't
explain why it is necessary, or really what problem the patch is
solving. I'm not aware of other implementations needing this for
kexec to work.
Thanks.
> ---
> drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index 604dfec..a24e6c5 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static int mpc8xxx_shutdown(struct platform_device *pdev)
> +{
> + struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
> +
> + if (mpc8xxx_gc->irq) {
> + irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
> + irq_domain_remove(mpc8xxx_gc->irq);
> + }
> +
> + return 0;
> +}
> static struct platform_driver mpc8xxx_plat_driver = {
> .probe = mpc8xxx_probe,
> .remove = mpc8xxx_remove,
> + .shutdown = mpc8xxx_shutdown,
> .driver = {
> .name = "gpio-mpc8xxx",
> .of_match_table = mpc8xxx_gpio_ids,
> --
> 2.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] gpio: mpc8xxx: Add shutdown function.
@ 2020-04-08 10:55 Hui Song
0 siblings, 0 replies; 4+ messages in thread
From: Hui Song @ 2020-04-08 10:55 UTC (permalink / raw)
To: linux-devel
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio, Song Hui
From: Song Hui <hui.song_1@nxp.com>
The shutdown function needed to make interrupt handler to be NULL
when kexec execute.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..a24e6c5 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev)
return 0;
}
+static int mpc8xxx_shutdown(struct platform_device *pdev)
+{
+ struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
+
+ if (mpc8xxx_gc->irq) {
+ irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
+ irq_domain_remove(mpc8xxx_gc->irq);
+ }
+
+ return 0;
+}
static struct platform_driver mpc8xxx_plat_driver = {
.probe = mpc8xxx_probe,
.remove = mpc8xxx_remove,
+ .shutdown = mpc8xxx_shutdown,
.driver = {
.name = "gpio-mpc8xxx",
.of_match_table = mpc8xxx_gpio_ids,
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 11:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-08 10:21 [PATCH v1] gpio: mpc8xxx: Add shutdown function Hui Song
2020-04-08 10:21 ` [PATCH] " Hui Song
2020-04-08 10:55 ` [PATCH v1] " Russell King - ARM Linux admin
2020-04-08 10:55 Hui Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).