* [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling
@ 2020-04-08 19:05 Arnd Bergmann
2020-04-08 19:05 ` [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Arnd Bergmann
2020-04-09 8:50 ` [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2020-04-08 19:05 UTC (permalink / raw)
To: Kalle Valo, David S. Miller, Pradeep Kumar Chitrapu
Cc: Arnd Bergmann, ath11k, linux-wireless, netdev, linux-kernel
The empty stub version of this function causes a compile-time
warning:
In file included from drivers/net/wireless/ath/ath11k/core.h:23,
from drivers/net/wireless/ath/ath11k/dp_rx.h:8,
from drivers/net/wireless/ath/ath11k/ce.c:6:
drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling':
drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type]
Just return success here.
Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/ath/ath11k/thermal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
index 459b8d49c184..f1395a14748c 100644
--- a/drivers/net/wireless/ath/ath11k/thermal.h
+++ b/drivers/net/wireless/ath/ath11k/thermal.h
@@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar)
static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state)
{
+ return 0;
}
static inline void ath11k_thermal_event_temperature(struct ath11k *ar,
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype
2020-04-08 19:05 [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Arnd Bergmann
@ 2020-04-08 19:05 ` Arnd Bergmann
2020-04-09 8:50 ` Kalle Valo
2020-04-09 8:50 ` [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2020-04-08 19:05 UTC (permalink / raw)
To: Kalle Valo, David S. Miller, Pradeep Kumar Chitrapu
Cc: Arnd Bergmann, ath11k, linux-wireless, netdev, linux-kernel
The stub function has the wrong prototype, causing a warning:
drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy':
drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types]
Change it to take the same arguments as the normal implementation.
Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/ath/ath11k/thermal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
index f1395a14748c..ea9a58bf6a93 100644
--- a/drivers/net/wireless/ath/ath11k/thermal.h
+++ b/drivers/net/wireless/ath/ath11k/thermal.h
@@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc)
return 0;
}
-static inline void ath11k_thermal_unregister(struct ath11k *ar)
+static inline void ath11k_thermal_unregister(struct ath11k_base *ar)
{
}
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype
2020-04-08 19:05 ` [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Arnd Bergmann
@ 2020-04-09 8:50 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-09 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Pradeep Kumar Chitrapu, netdev, linux-wireless,
ath11k, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The stub function has the wrong prototype, causing a warning:
>
> drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy':
> drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types]
>
> Change it to take the same arguments as the normal implementation.
>
> Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ath/ath11k/thermal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
> index f1395a14748c..ea9a58bf6a93 100644
> --- a/drivers/net/wireless/ath/ath11k/thermal.h
> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc)
> return 0;
> }
>
> -static inline void ath11k_thermal_unregister(struct ath11k *ar)
> +static inline void ath11k_thermal_unregister(struct ath11k_base *ar)
> {
> }
Already fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling
2020-04-08 19:05 [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Arnd Bergmann
2020-04-08 19:05 ` [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Arnd Bergmann
@ 2020-04-09 8:50 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-09 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Pradeep Kumar Chitrapu, netdev, linux-wireless,
ath11k, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The empty stub version of this function causes a compile-time
> warning:
>
> In file included from drivers/net/wireless/ath/ath11k/core.h:23,
> from drivers/net/wireless/ath/ath11k/dp_rx.h:8,
> from drivers/net/wireless/ath/ath11k/ce.c:6:
> drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling':
> drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type]
>
> Just return success here.
>
> Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ath/ath11k/thermal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
> index 459b8d49c184..f1395a14748c 100644
> --- a/drivers/net/wireless/ath/ath11k/thermal.h
> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar)
>
> static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state)
> {
> + return 0;
> }
Already fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-09 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-08 19:05 [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Arnd Bergmann
2020-04-08 19:05 ` [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Arnd Bergmann
2020-04-09 8:50 ` Kalle Valo
2020-04-09 8:50 ` [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).