From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: check for missing \n at the end of logging message
Date: Thu, 9 Apr 2020 13:40:13 +0300 [thread overview]
Message-ID: <20200409103049.GA14081@kadam> (raw)
In-Reply-To: <efb5a518fdc47f0120b94a7e8a95d275c0f4ad43.camel@perches.com>
On Wed, Apr 08, 2020 at 08:10:23PM -0700, Joe Perches wrote:
> Some types of false positives:
>
> o Many of the formats seem to end in a ':' or a ' '
> maybe those should be excluded
> #86: FILE: drivers/android/binder_alloc_selftest.c:86:
> + pr_err("free seq: ");
>
Yeah. I also ignored strings that end in a space in my version.
> o Split string formats should be excluded better
> as only the first string fragment is checked:
> #1001: FILE: drivers/ata/pata_octeon_cf.c:1001:
> + dev_info(&pdev->dev, "version " DRV_VERSION" %d bit%s.\n",
I ignored anything with a newline in it anywhere.
> + is_16bit ? 16 : 8,
> + cf_port->is_true_ide ? ", True IDE" : "");
>
> probably a few others, including a desire to check
> if a pr_cont is below the use within a few lines.
Seems tricky to implement... I think if you can't make it work it's
still usefull even with a some false positives.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-09 10:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 20:49 [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-08 0:33 ` Joe Perches
2020-04-08 20:19 ` Marion & Christophe JAILLET
2020-04-08 2:14 ` Joe Perches
2020-04-08 20:23 ` Marion & Christophe JAILLET
2020-04-09 3:10 ` Joe Perches
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 15:29 ` Joe Perches
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:50 ` Joe Perches
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 21:40 ` Joe Perches
2020-04-09 10:40 ` Dan Carpenter [this message]
2020-04-10 17:35 ` Christophe JAILLET
2020-04-10 19:46 ` Joe Perches
2020-04-10 19:53 ` Joe Perches
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 10:10 ` Andy? checkpatch $stat question (was: Re: [PATCH] checkpatch: check for missing \n at the end of logging message) Joe Perches
2020-04-11 7:12 ` [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-11 7:12 ` Christophe JAILLET
2020-04-11 7:13 ` Marion & Christophe JAILLET
2020-04-11 10:17 ` Joe Perches
2020-04-11 10:27 ` Christophe JAILLET
2020-04-11 10:27 ` Christophe JAILLET
2020-04-10 19:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409103049.GA14081@kadam \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).