From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: check for missing \n at the end of logging message
Date: Sat, 11 Apr 2020 12:27:32 +0200 [thread overview]
Message-ID: <0b05744d-7379-fa23-5070-c09fd10db45d@wanadoo.fr> (raw)
Message-ID: <20200411102732.tNHDVCSBpm7N2RmoArbsIEemQPlsp5h4m_nhQdxDubs@z> (raw)
In-Reply-To: <159680bb287fc43bb2129d3b731e15931bd9979c.camel@perches.com>
Le 11/04/2020 à 12:17, Joe Perches a écrit :
> On Sat, 2020-04-11 at 09:12 +0200, Christophe JAILLET wrote:
>> ./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
>>
>> is missing line 189, even if it looks like a construction correctly spotted in some other files:
>> if (foo) {
>> dev_err(...);
>> ...
>> };
> Hi Christophe, many thanks for doing more testing
>
> Are you sure about this one? I get:
>
> $ ./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
> WARNING: Possible missing '\n' at the end of a logging message format string
> #189: FILE: drivers/soc/kendryte/k210-sysctl.c:189:
> + dev_err(&pdev->dev, "failed to register clk");
No, this one is correctly spotted.
(I added the missing \n, then ran checkpatch.pl, then wondered why it
was not spotting the issue!)
CJ
next prev parent reply other threads:[~2020-04-11 10:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 20:49 [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-08 0:33 ` Joe Perches
2020-04-08 20:19 ` Marion & Christophe JAILLET
2020-04-08 2:14 ` Joe Perches
2020-04-08 20:23 ` Marion & Christophe JAILLET
2020-04-09 3:10 ` Joe Perches
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 15:29 ` Joe Perches
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:50 ` Joe Perches
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 21:40 ` Joe Perches
2020-04-09 10:40 ` Dan Carpenter
2020-04-10 17:35 ` Christophe JAILLET
2020-04-10 19:46 ` Joe Perches
2020-04-10 19:53 ` Joe Perches
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 10:10 ` Andy? checkpatch $stat question (was: Re: [PATCH] checkpatch: check for missing \n at the end of logging message) Joe Perches
2020-04-11 7:12 ` [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-11 7:12 ` Christophe JAILLET
2020-04-11 7:13 ` Marion & Christophe JAILLET
2020-04-11 10:17 ` Joe Perches
2020-04-11 10:27 ` Christophe JAILLET [this message]
2020-04-11 10:27 ` Christophe JAILLET
2020-04-10 19:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b05744d-7379-fa23-5070-c09fd10db45d@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).