From: Jessica Yu <jeyu@kernel.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
keescook@chromium.org
Subject: Re: [PATCH] module: Harden STRICT_MODULE_RWX
Date: Fri, 10 Apr 2020 11:04:08 +0200 [thread overview]
Message-ID: <20200410090407.GA8723@linux-8ccs.fritz.box> (raw)
In-Reply-To: <alpine.LSU.2.21.2004091854280.31635@pobox.suse.cz>
+++ Miroslav Benes [09/04/20 18:55 +0200]:
>> I am still wondering if there are modules out there with sections flags
>> combination which would cause the same problem with layout_sections() and
>> move_module() logic I described earlier. But that it is a separate issue.
>
>And of course I misread the condition in layout_sections() and all should
>be fine. Oh well...
Me too :-( For some reason I misread it as an exact mask match, ugh.
In any case, it looks like we are fine since we'd catch all SHF_ALLOC
sections at the minimum and they would have sh_entsize set, and we
appropriately ignore non-SHF_ALLOC sections in move_module(), so
the hypothetical problem I described earlier was incorrect.
next prev parent reply other threads:[~2020-04-10 9:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:37 [PATCH] module: Harden STRICT_MODULE_RWX Peter Zijlstra
2020-04-03 16:56 ` Josh Poimboeuf
2020-04-03 17:08 ` Peter Zijlstra
2020-04-06 9:55 ` Miroslav Benes
2020-04-06 10:46 ` Jessica Yu
2020-04-06 11:27 ` Peter Zijlstra
2020-04-06 12:53 ` Jessica Yu
2020-04-06 14:11 ` Peter Zijlstra
2020-04-07 7:43 ` Miroslav Benes
2020-04-09 16:55 ` Miroslav Benes
2020-04-10 9:04 ` Jessica Yu [this message]
2020-04-03 16:59 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410090407.GA8723@linux-8ccs.fritz.box \
--to=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).