* [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource
@ 2020-04-09 15:13 Aishwarya R
2020-04-12 10:25 ` Jonathan Cameron
2020-04-12 13:50 ` Aishwarya R
0 siblings, 2 replies; 4+ messages in thread
From: Aishwarya R @ 2020-04-09 15:13 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Stephen Boyd, Enrico Weigelt, Greg Kroah-Hartman, Aishwarya R,
Kate Stewart, Thomas Gleixner, linux-iio, linux-arm-kernel,
linux-kernel
Use the helper function that wraps the calls to
platform_get_resource() and devm_ioremap_resource()
together.
Signed-off-by: Aishwarya R <aishwaryarj100@gmail.com>
---
drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index fa71489195c6..b0a4dc88ba9b 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
struct mx25_gcq_priv *priv;
struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
struct device *dev = &pdev->dev;
- struct resource *res;
void __iomem *mem;
int ret;
int i;
@@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
priv = iio_priv(indio_dev);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mem = devm_ioremap_resource(dev, res);
+ mem = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mem))
return PTR_ERR(mem);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource
2020-04-09 15:13 [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource Aishwarya R
@ 2020-04-12 10:25 ` Jonathan Cameron
2020-04-12 13:50 ` Aishwarya R
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-04-12 10:25 UTC (permalink / raw)
To: Aishwarya R
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Stephen Boyd, Enrico Weigelt, Greg Kroah-Hartman,
Kate Stewart, Thomas Gleixner, linux-iio, linux-arm-kernel,
linux-kernel
On Thu, 9 Apr 2020 20:43:05 +0530
Aishwarya R <aishwaryarj100@gmail.com> wrote:
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.
>
> Signed-off-by: Aishwarya R <aishwaryarj100@gmail.com>
Please update the commit message for v2. In particular if an automated
tool was used to identify this location then mention that. If not just
say 'by inspection' or similar!
Also, same thing about the signed-off-by as in previous patch.
Thanks,
Jonathan
> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index fa71489195c6..b0a4dc88ba9b 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> struct mx25_gcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
> struct device *dev = &pdev->dev;
> - struct resource *res;
> void __iomem *mem;
> int ret;
> int i;
> @@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
>
> priv = iio_priv(indio_dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource
2020-04-09 15:13 [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource Aishwarya R
2020-04-12 10:25 ` Jonathan Cameron
@ 2020-04-12 13:50 ` Aishwarya R
2020-04-13 15:37 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Aishwarya R @ 2020-04-12 13:50 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Enrico Weigelt, Thomas Gleixner, Greg Kroah-Hartman,
Stephen Boyd, Aishwarya R, linux-iio, linux-arm-kernel,
linux-kernel
From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Use the helper function that wraps the calls to
platform_get_resource() and devm_ioremap_resource()
together.It reduces boilerplate and suggested by coccinelle.
Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
---
drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index fa71489195c6..b0a4dc88ba9b 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
struct mx25_gcq_priv *priv;
struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
struct device *dev = &pdev->dev;
- struct resource *res;
void __iomem *mem;
int ret;
int i;
@@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
priv = iio_priv(indio_dev);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mem = devm_ioremap_resource(dev, res);
+ mem = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mem))
return PTR_ERR(mem);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource
2020-04-12 13:50 ` Aishwarya R
@ 2020-04-13 15:37 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-04-13 15:37 UTC (permalink / raw)
To: Aishwarya R
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Enrico Weigelt, Thomas Gleixner,
Greg Kroah-Hartman, Stephen Boyd, linux-iio, linux-arm-kernel,
linux-kernel
On Sun, 12 Apr 2020 19:20:20 +0530
Aishwarya R <aishwaryarj100@gmail.com> wrote:
> From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
>
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.It reduces boilerplate and suggested by coccinelle.
>
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Again see earlier patches for comments but applied anyway to
save myself time.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index fa71489195c6..b0a4dc88ba9b 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> struct mx25_gcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
> struct device *dev = &pdev->dev;
> - struct resource *res;
> void __iomem *mem;
> int ret;
> int i;
> @@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
>
> priv = iio_priv(indio_dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-13 15:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 15:13 [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource Aishwarya R
2020-04-12 10:25 ` Jonathan Cameron
2020-04-12 13:50 ` Aishwarya R
2020-04-13 15:37 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).