From: Steven Rostedt <rostedt@goodmis.org>
To: 宋牧春 <songmuchun@bytedance.com>
Cc: mingo@kernel.org, peterz@infradead.org, juri.lelli@redhat.com,
Vincent Guittot <vincent.guittot@linaro.org>,
dietmar.eggemann@arm.com, Benjamin Segall <bsegall@google.com>,
mgorman@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity functions
Date: Mon, 13 Apr 2020 11:44:44 -0400 [thread overview]
Message-ID: <20200413114444.5db76182@gandalf.local.home> (raw)
In-Reply-To: <CAMZfGtUY_GLXZ4jV4s0UZqsVF0W57dzUh0wVGynXYCy3CMN4iA@mail.gmail.com>
On Mon, 13 Apr 2020 23:07:03 +0800
宋牧春 <songmuchun@bytedance.com> wrote:
> > -void sched_init_granularity(void)
> > +void __init sched_init_granularity(void)
> > {
> > update_sysctl();
> > }
> > --
> > 2.11.0
> >
>
> Ping guys. Any suggestions?
Seems fine, but not that big of an issue as it's a very small function.
ffffffff81136880 <sched_init_granularity>:
ffffffff81136880: e8 7b b3 ac 00 callq ffffffff81c01c00 <__fentry__>
ffffffff81136881: R_X86_64_PLT32 __fentry__-0x4
ffffffff81136885: e9 86 86 ff ff jmpq ffffffff8112ef10 <update_sysctl>
ffffffff8113688a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1)
But anyway, it can save 16 bytes of memory in the running kernel.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2020-04-13 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 7:47 [PATCH] sched/fair: add __init to sched_init_granularity functions Muchun Song
2020-04-13 15:07 ` 宋牧春
2020-04-13 15:44 ` Steven Rostedt [this message]
2020-05-01 18:22 ` [tip: sched/core] sched/fair: Mark sched_init_granularity __init tip-bot2 for Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413114444.5db76182@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).