* [PATCH resend v2] sched/debug: fix trival print task format
@ 2020-04-14 12:57 Xie XiuQi
2020-05-01 18:22 ` [tip: sched/core] sched/debug: Fix trival print_task() format tip-bot2 for Xie XiuQi
0 siblings, 1 reply; 2+ messages in thread
From: Xie XiuQi @ 2020-04-14 12:57 UTC (permalink / raw)
To: mingo, peterz, vincent.guittot, dietmar.eggemann, rostedt; +Cc: linux-kernel
Ensure leave one space between state and task name.
w/o patch:
runnable tasks:
S task PID tree-key switches prio wait
-----------------------------------------------------------------
I kworker/0:2 656 87693.884557 8255 120
Sirq/10-ACPI:Ged 829 0.000000 3 49
Sirq/11-ACPI:Ged 830 0.000000 3 49
Sirq/50-arm-smmu 945 0.000000 3 49
with patch:
runnable tasks:
S task PID tree-key switches prio wait
------------------------------------------------------------------
I kworker/0:2 656 87693.884557 8255 120
S irq/10-ACPI:Ged 829 0.000000 3 49
S irq/11-ACPI:Ged 830 0.000000 3 49
S irq/50-arm-smmu 945 0.000000 3 49
v2:
- fix a typo
- simpler to add one space before print format
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
---
kernel/sched/debug.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 879d3ccf3806..626d6c19c94b 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -438,7 +438,7 @@ print_task(struct seq_file *m, struct rq *rq, struct task_struct *p)
else
SEQ_printf(m, " %c", task_state_to_char(p));
- SEQ_printf(m, "%15s %5d %9Ld.%06ld %9Ld %5d ",
+ SEQ_printf(m, " %15s %5d %9Ld.%06ld %9Ld %5d ",
p->comm, task_pid_nr(p),
SPLIT_NS(p->se.vruntime),
(long long)(p->nvcsw + p->nivcsw),
@@ -465,10 +465,10 @@ static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
SEQ_printf(m, "\n");
SEQ_printf(m, "runnable tasks:\n");
- SEQ_printf(m, " S task PID tree-key switches prio"
+ SEQ_printf(m, " S task PID tree-key switches prio"
" wait-time sum-exec sum-sleep\n");
SEQ_printf(m, "-------------------------------------------------------"
- "----------------------------------------------------\n");
+ "------------------------------------------------------\n");
rcu_read_lock();
for_each_process_thread(g, p) {
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: sched/core] sched/debug: Fix trival print_task() format
2020-04-14 12:57 [PATCH resend v2] sched/debug: fix trival print task format Xie XiuQi
@ 2020-05-01 18:22 ` tip-bot2 for Xie XiuQi
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Xie XiuQi @ 2020-05-01 18:22 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Peter Zijlstra (Intel), x86, LKML
The following commit has been merged into the sched/core branch of tip:
Commit-ID: f080d93e1d419099a99d7473ed532289ca8dc717
Gitweb: https://git.kernel.org/tip/f080d93e1d419099a99d7473ed532289ca8dc717
Author: Xie XiuQi <xiexiuqi@huawei.com>
AuthorDate: Tue, 14 Apr 2020 20:57:21 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 30 Apr 2020 20:14:37 +02:00
sched/debug: Fix trival print_task() format
Ensure leave one space between state and task name.
w/o patch:
runnable tasks:
S task PID tree-key switches prio wait
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200414125721.195801-1-xiexiuqi@huawei.com
---
kernel/sched/debug.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index a562df5..b3ac1c1 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -437,7 +437,7 @@ print_task(struct seq_file *m, struct rq *rq, struct task_struct *p)
else
SEQ_printf(m, " %c", task_state_to_char(p));
- SEQ_printf(m, "%15s %5d %9Ld.%06ld %9Ld %5d ",
+ SEQ_printf(m, " %15s %5d %9Ld.%06ld %9Ld %5d ",
p->comm, task_pid_nr(p),
SPLIT_NS(p->se.vruntime),
(long long)(p->nvcsw + p->nivcsw),
@@ -464,10 +464,10 @@ static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
SEQ_printf(m, "\n");
SEQ_printf(m, "runnable tasks:\n");
- SEQ_printf(m, " S task PID tree-key switches prio"
+ SEQ_printf(m, " S task PID tree-key switches prio"
" wait-time sum-exec sum-sleep\n");
SEQ_printf(m, "-------------------------------------------------------"
- "----------------------------------------------------\n");
+ "------------------------------------------------------\n");
rcu_read_lock();
for_each_process_thread(g, p) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-01 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 12:57 [PATCH resend v2] sched/debug: fix trival print task format Xie XiuQi
2020-05-01 18:22 ` [tip: sched/core] sched/debug: Fix trival print_task() format tip-bot2 for Xie XiuQi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).