* [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region
@ 2020-04-01 3:21 Masahiro Yamada
2020-04-14 14:21 ` Rob Herring
2020-04-15 16:17 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-04-01 3:21 UTC (permalink / raw)
To: Vinod Koul, dmaengine
Cc: Masahiro Yamada, Kunihiko Hayashi, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>"
is wrong. The register region of this controller is much smaller,
and there is no other hardware register interleaved. There is no
good reason to split it into two regions.
Just use a single, contiguous register region.
While I am here, I made the 'dma-channels' property mandatory because
otherwise there is no way to determine the number of the channels.
Please note the original binding was merged recently. Since there
is no user yet, this change has no actual impact.
Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
We do not need to touch the driver either because the second
region is not used.
.../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
index 86cfb599256e..371f18773198 100644
--- a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
+++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
@@ -22,9 +22,7 @@ properties:
const: socionext,uniphier-xdmac
reg:
- items:
- - description: XDMAC base register region (offset and length)
- - description: XDMAC extension register region (offset and length)
+ maxItems: 1
interrupts:
maxItems: 1
@@ -49,12 +47,13 @@ required:
- reg
- interrupts
- "#dma-cells"
+ - dma-channels
examples:
- |
xdmac: dma-controller@5fc10000 {
compatible = "socionext,uniphier-xdmac";
- reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>;
+ reg = <0x5fc10000 0x5300>;
interrupts = <0 188 4>;
#dma-cells = <2>;
dma-channels = <16>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region
2020-04-01 3:21 [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region Masahiro Yamada
@ 2020-04-14 14:21 ` Rob Herring
2020-04-15 16:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-04-14 14:21 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Vinod Koul, dmaengine, Masahiro Yamada, Kunihiko Hayashi,
devicetree, linux-arm-kernel, linux-kernel
On Wed, 1 Apr 2020 12:21:50 +0900, Masahiro Yamada wrote:
> The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>"
> is wrong. The register region of this controller is much smaller,
> and there is no other hardware register interleaved. There is no
> good reason to split it into two regions.
>
> Just use a single, contiguous register region.
>
> While I am here, I made the 'dma-channels' property mandatory because
> otherwise there is no way to determine the number of the channels.
>
> Please note the original binding was merged recently. Since there
> is no user yet, this change has no actual impact.
>
> Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> We do not need to touch the driver either because the second
> region is not used.
>
>
> .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region
2020-04-01 3:21 [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region Masahiro Yamada
2020-04-14 14:21 ` Rob Herring
@ 2020-04-15 16:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-04-15 16:17 UTC (permalink / raw)
To: Masahiro Yamada
Cc: dmaengine, Kunihiko Hayashi, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
On 01-04-20, 12:21, Masahiro Yamada wrote:
> The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>"
> is wrong. The register region of this controller is much smaller,
> and there is no other hardware register interleaved. There is no
> good reason to split it into two regions.
>
> Just use a single, contiguous register region.
>
> While I am here, I made the 'dma-channels' property mandatory because
> otherwise there is no way to determine the number of the channels.
>
> Please note the original binding was merged recently. Since there
> is no user yet, this change has no actual impact.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-15 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 3:21 [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region Masahiro Yamada
2020-04-14 14:21 ` Rob Herring
2020-04-15 16:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).