* [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() in bt_bmc_config_irq()
@ 2020-04-14 14:19 Tang Bin
2020-04-14 19:44 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Tang Bin @ 2020-04-14 14:19 UTC (permalink / raw)
To: minyard, arnd, gregkh
Cc: openipmi-developer, linux-kernel, Tang Bin, Shengju Zhang
The priority of dev_warm() is higher than dev_info(),so if the
function bt_bmc_probe() uses dev_info() to print error message,
the dev_warm() is redundant.Thus should be removed.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
---
drivers/char/ipmi/bt-bmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index cd0349bff..1d4bf5c65 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -406,7 +406,6 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc,
rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED,
DEVICE_NAME, bt_bmc);
if (rc < 0) {
- dev_warn(dev, "Unable to request IRQ %d\n", bt_bmc->irq);
bt_bmc->irq = 0;
return rc;
}
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() in bt_bmc_config_irq()
2020-04-14 14:19 [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() in bt_bmc_config_irq() Tang Bin
@ 2020-04-14 19:44 ` Corey Minyard
2020-04-15 1:28 ` [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() inbt_bmc_config_irq() Tang Bin
0 siblings, 1 reply; 3+ messages in thread
From: Corey Minyard @ 2020-04-14 19:44 UTC (permalink / raw)
To: Tang Bin; +Cc: arnd, gregkh, openipmi-developer, linux-kernel, Shengju Zhang
On Tue, Apr 14, 2020 at 10:19:51PM +0800, Tang Bin wrote:
> The priority of dev_warm() is higher than dev_info(),so if the
> function bt_bmc_probe() uses dev_info() to print error message,
> the dev_warm() is redundant.Thus should be removed.
Actually, this needs to be left in. That error is not just a that irqs
were not configured, that's an error that something else went wrong.
-corey
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
> ---
> drivers/char/ipmi/bt-bmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index cd0349bff..1d4bf5c65 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -406,7 +406,6 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc,
> rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED,
> DEVICE_NAME, bt_bmc);
> if (rc < 0) {
> - dev_warn(dev, "Unable to request IRQ %d\n", bt_bmc->irq);
> bt_bmc->irq = 0;
> return rc;
> }
> --
> 2.20.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() inbt_bmc_config_irq()
2020-04-14 19:44 ` Corey Minyard
@ 2020-04-15 1:28 ` Tang Bin
0 siblings, 0 replies; 3+ messages in thread
From: Tang Bin @ 2020-04-15 1:28 UTC (permalink / raw)
To: minyard; +Cc: arnd, gregkh, openipmi-developer, linux-kernel, Shengju Zhang
Hi Corey:
On 2020/4/15 3:44, Corey Minyard wrote:
> On Tue, Apr 14, 2020 at 10:19:51PM +0800, Tang Bin wrote:
>> The priority of dev_warm() is higher than dev_info(),so if the
>> function bt_bmc_probe() uses dev_info() to print error message,
>> the dev_warm() is redundant.Thus should be removed.
> Actually, this needs to be left in. That error is not just a that irqs
> were not configured, that's an error that something else went wrong.
Oh ,It's my fault.
I had read the previous email with you again, and mistook it as that you
agreed with my point of view. I feel humiliated now.
Thanks,
Tang Bin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-15 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 14:19 [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() in bt_bmc_config_irq() Tang Bin
2020-04-14 19:44 ` Corey Minyard
2020-04-15 1:28 ` [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() inbt_bmc_config_irq() Tang Bin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).