* [PATCH v3] iio: patch set ltc2632
@ 2020-04-14 23:56 Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Chris Ruehl @ 2020-04-14 23:56 UTC (permalink / raw)
To: chris.ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Uwe Kleine-König,
Greg Kroah-Hartman, Alexios Zavras, Thomas Gleixner, linux-iio,
linux-kernel
Patchset to extend ltc2632 spi driver to support the similar chip set
ltc2634.
* Patch v3 1/3 update documentation struct ltc2632_chip_info
* Patch v3 2/3 patch ltc2632.c,Kconfig,ltc2632.txt(devtree)
* Patch v3 3/3 convert ltc2632.txt to yaml format named lltc,ltc2632.yaml
* Patch v3 2/3 : correct help text
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels
2020-04-14 23:56 [PATCH v3] iio: patch set ltc2632 Chris Ruehl
@ 2020-04-14 23:56 ` Chris Ruehl
2020-04-15 6:53 ` Uwe Kleine-König
2020-04-14 23:56 ` [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml Chris Ruehl
2 siblings, 1 reply; 7+ messages in thread
From: Chris Ruehl @ 2020-04-14 23:56 UTC (permalink / raw)
To: chris.ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Uwe Kleine-König, Richard Fontana,
Allison Randal, Thomas Gleixner, linux-iio, linux-kernel
The documentation for ltc_2632_chip_info missed the desciption for the
num_channels. This privial patch add it.
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
drivers/iio/dac/ltc2632.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
index 7adc91056aa1..2a84ea654645 100644
--- a/drivers/iio/dac/ltc2632.c
+++ b/drivers/iio/dac/ltc2632.c
@@ -24,6 +24,7 @@
/**
* struct ltc2632_chip_info - chip specific information
* @channels: channel spec for the DAC
+ * @num_channels: DAC channel count of the chip
* @vref_mv: internal reference voltage
*/
struct ltc2632_chip_info {
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8
2020-04-14 23:56 [PATCH v3] iio: patch set ltc2632 Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
@ 2020-04-14 23:56 ` Chris Ruehl
2020-04-15 7:00 ` Uwe Kleine-König
2020-04-14 23:56 ` [PATCH v3 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml Chris Ruehl
2 siblings, 1 reply; 7+ messages in thread
From: Chris Ruehl @ 2020-04-14 23:56 UTC (permalink / raw)
To: chris.ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Uwe Kleine-König,
Alexandru Ardelean, Alexandru Tachici, Greg Kroah-Hartman,
Thomas Gleixner, Stefan Popa, Allison Randal, Alexios Zavras,
linux-iio, linux-kernel
This patch add support for Analog Devices (Linear Technology)
LTC2634 Quad 12-/10-/8-Bit Rail-to-Rail DAC.
The SPI functionality based on them from LTC2632 therefor
add the definitions only and update the Kconfig.
V2:
Send the documentation fix in a extra patch
Kconfig simplify the driver description, details to the help text
ltc2632.txt add to this patch-set (prepare to convert to yaml)
V3:
Consistens decimal separator in help text
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
.../devicetree/bindings/iio/dac/ltc2632.txt | 8 ++-
drivers/iio/dac/Kconfig | 6 +-
drivers/iio/dac/ltc2632.c | 60 +++++++++++++++++++
3 files changed, 70 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
index 338c3220f01a..1ab9570cf219 100644
--- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
+++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
@@ -1,4 +1,4 @@
-Linear Technology LTC2632/2636 DAC
+Linear Technology LTC2632/2634/2636 DAC
Required properties:
- compatible: Has to contain one of the following:
@@ -8,6 +8,12 @@ Required properties:
lltc,ltc2632-h12
lltc,ltc2632-h10
lltc,ltc2632-h8
+ lltc,ltc2634-l12
+ lltc,ltc2634-l10
+ lltc,ltc2634-l8
+ lltc,ltc2634-h12
+ lltc,ltc2634-h10
+ lltc,ltc2634-h8
lltc,ltc2636-l12
lltc,ltc2636-l10
lltc,ltc2636-l8
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 93744011b63f..aee13ced6ddf 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -279,12 +279,12 @@ config LTC1660
module will be called ltc1660.
config LTC2632
- tristate "Linear Technology LTC2632-12/10/8 and LTC2636-12/10/8 DAC spi driver"
+ tristate "Linear Technology LTC2632-12/10/8 and similar DAC spi driver"
depends on SPI
help
Say yes here to build support for Linear Technology
- LTC2632-12, LTC2632-10, LTC2632-8, LTC2636-12, LTC2636-10 and
- LTC2636-8 converters (DAC).
+ LTC2632, LTC2634 and LTC2636 DAC resolution 12/10/8 bit
+ low 0-2.5V and high 0-4.096V range converters.
To compile this driver as a module, choose M here: the
module will be called ltc2632.
diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
index 2a84ea654645..e939d7f81014 100644
--- a/drivers/iio/dac/ltc2632.c
+++ b/drivers/iio/dac/ltc2632.c
@@ -54,6 +54,12 @@ enum ltc2632_supported_device_ids {
ID_LTC2632H12,
ID_LTC2632H10,
ID_LTC2632H8,
+ ID_LTC2634L12,
+ ID_LTC2634L10,
+ ID_LTC2634L8,
+ ID_LTC2634H12,
+ ID_LTC2634H10,
+ ID_LTC2634H8,
ID_LTC2636L12,
ID_LTC2636L10,
ID_LTC2636L8,
@@ -236,6 +242,36 @@ static const struct ltc2632_chip_info ltc2632_chip_info_tbl[] = {
.num_channels = 2,
.vref_mv = 4096,
},
+ [ID_LTC2634L12] = {
+ .channels = ltc2632x12_channels,
+ .num_channels = 4,
+ .vref_mv = 2500,
+ },
+ [ID_LTC2634L10] = {
+ .channels = ltc2632x10_channels,
+ .num_channels = 4,
+ .vref_mv = 2500,
+ },
+ [ID_LTC2634L8] = {
+ .channels = ltc2632x8_channels,
+ .num_channels = 4,
+ .vref_mv = 2500,
+ },
+ [ID_LTC2634H12] = {
+ .channels = ltc2632x12_channels,
+ .num_channels = 4,
+ .vref_mv = 4096,
+ },
+ [ID_LTC2634H10] = {
+ .channels = ltc2632x10_channels,
+ .num_channels = 4,
+ .vref_mv = 4096,
+ },
+ [ID_LTC2634H8] = {
+ .channels = ltc2632x8_channels,
+ .num_channels = 4,
+ .vref_mv = 4096,
+ },
[ID_LTC2636L12] = {
.channels = ltc2632x12_channels,
.num_channels = 8,
@@ -357,6 +393,12 @@ static const struct spi_device_id ltc2632_id[] = {
{ "ltc2632-h12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H12] },
{ "ltc2632-h10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H10] },
{ "ltc2632-h8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H8] },
+ { "ltc2634-l12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L12] },
+ { "ltc2634-l10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L10] },
+ { "ltc2634-l8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L8] },
+ { "ltc2634-h12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H12] },
+ { "ltc2634-h10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H10] },
+ { "ltc2634-h8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H8] },
{ "ltc2636-l12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L12] },
{ "ltc2636-l10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L10] },
{ "ltc2636-l8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L8] },
@@ -386,6 +428,24 @@ static const struct of_device_id ltc2632_of_match[] = {
}, {
.compatible = "lltc,ltc2632-h8",
.data = <c2632_chip_info_tbl[ID_LTC2632H8]
+ }, {
+ .compatible = "lltc,ltc2634-l12",
+ .data = <c2632_chip_info_tbl[ID_LTC2634L12]
+ }, {
+ .compatible = "lltc,ltc2634-l10",
+ .data = <c2632_chip_info_tbl[ID_LTC2634L10]
+ }, {
+ .compatible = "lltc,ltc2634-l8",
+ .data = <c2632_chip_info_tbl[ID_LTC2634L8]
+ }, {
+ .compatible = "lltc,ltc2634-h12",
+ .data = <c2632_chip_info_tbl[ID_LTC2634H12]
+ }, {
+ .compatible = "lltc,ltc2634-h10",
+ .data = <c2632_chip_info_tbl[ID_LTC2634H10]
+ }, {
+ .compatible = "lltc,ltc2634-h8",
+ .data = <c2632_chip_info_tbl[ID_LTC2634H8]
}, {
.compatible = "lltc,ltc2636-l12",
.data = <c2632_chip_info_tbl[ID_LTC2636L12]
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml
2020-04-14 23:56 [PATCH v3] iio: patch set ltc2632 Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
@ 2020-04-14 23:56 ` Chris Ruehl
2 siblings, 0 replies; 7+ messages in thread
From: Chris Ruehl @ 2020-04-14 23:56 UTC (permalink / raw)
To: chris.ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Uwe Kleine-König,
Steve Winslow, Alexios Zavras, Thomas Gleixner, linux-iio,
linux-kernel
Conversion of the ltc2632 to yaml format and name the file 'lltc,ltc2632.yaml'.
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
.../bindings/iio/dac/lltc,ltc2632.yaml | 78 +++++++++++++++++++
.../devicetree/bindings/iio/dac/ltc2632.txt | 49 ------------
2 files changed, 78 insertions(+), 49 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
delete mode 100644 Documentation/devicetree/bindings/iio/dac/ltc2632.txt
diff --git a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
new file mode 100644
index 000000000000..314bf700d934
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+# Copyright 2020 Christopher Ruehl <chris.ruehl@gtsys.com.hk>
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/iio/dac/lltc,ltc2632.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Linear Technology LTC263x 12-/10-/8-Bit Rail-to-Rail DAC
+
+maintainers:
+ - Jonathan Cameron <jic23@kernel.org>
+
+description: |
+ Bindings for the Linear Technology LTC2632/2634/2636 DAC
+ Datasheet can be found here: https://www.analog.com/media/en/technical-documentation/data-sheets/LTC263[246].pdf
+
+properties:
+ compatible:
+ enum:
+ - lltc,ltc2632-l12
+ - lltc,ltc2632-l10
+ - lltc,ltc2632-l8
+ - lltc,ltc2632-h12
+ - lltc,ltc2632-h10
+ - lltc,ltc2632-h8
+ - lltc,ltc2634-l12
+ - lltc,ltc2634-l10
+ - lltc,ltc2634-l8
+ - lltc,ltc2634-h12
+ - lltc,ltc2634-h10
+ - lltc,ltc2634-h8
+ - lltc,ltc2636-l12
+ - lltc,ltc2636-l10
+ - lltc,ltc2636-l8
+ - lltc,ltc2636-h12
+ - lltc,ltc2636-h10
+ - lltc,ltc2636-h8
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 2000000
+
+ vref-supply:
+ description:
+ Phandle to the external reference voltage supply. This should
+ only be set if there is an external reference voltage connected to the VREF
+ pin. If the property is not set the internal reference is used.
+
+required:
+ - compatible
+ - reg
+ - vref-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ vref: regulator-vref {
+ compatible = "regulator-fixed";
+ regulator-name = "vref-ltc2632";
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-always-on;
+ };
+
+ spi_master {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dac: ltc2632@0 {
+ compatible = "lltc,ltc2632";
+ reg = <0>; /* CS0 */
+ spi-max-frequency = <1000000>;
+ vref-supply = <&vref>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
deleted file mode 100644
index 1ab9570cf219..000000000000
--- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
+++ /dev/null
@@ -1,49 +0,0 @@
-Linear Technology LTC2632/2634/2636 DAC
-
-Required properties:
- - compatible: Has to contain one of the following:
- lltc,ltc2632-l12
- lltc,ltc2632-l10
- lltc,ltc2632-l8
- lltc,ltc2632-h12
- lltc,ltc2632-h10
- lltc,ltc2632-h8
- lltc,ltc2634-l12
- lltc,ltc2634-l10
- lltc,ltc2634-l8
- lltc,ltc2634-h12
- lltc,ltc2634-h10
- lltc,ltc2634-h8
- lltc,ltc2636-l12
- lltc,ltc2636-l10
- lltc,ltc2636-l8
- lltc,ltc2636-h12
- lltc,ltc2636-h10
- lltc,ltc2636-h8
-
-Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
-apply. In particular, "reg" and "spi-max-frequency" properties must be given.
-
-Optional properties:
- - vref-supply: Phandle to the external reference voltage supply. This should
- only be set if there is an external reference voltage connected to the VREF
- pin. If the property is not set the internal reference is used.
-
-Example:
-
- vref: regulator-vref {
- compatible = "regulator-fixed";
- regulator-name = "vref-ltc2632";
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <1250000>;
- regulator-always-on;
- };
-
- spi_master {
- dac: ltc2632@0 {
- compatible = "lltc,ltc2632-l12";
- reg = <0>; /* CS0 */
- spi-max-frequency = <1000000>;
- vref-supply = <&vref>; /* optional */
- };
- };
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels
2020-04-14 23:56 ` [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
@ 2020-04-15 6:53 ` Uwe Kleine-König
0 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2020-04-15 6:53 UTC (permalink / raw)
To: Chris Ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Richard Fontana, Allison Randal,
Thomas Gleixner, linux-iio, linux-kernel
On Wed, Apr 15, 2020 at 07:56:02AM +0800, Chris Ruehl wrote:
> The documentation for ltc_2632_chip_info missed the desciption for the
> num_channels. This privial patch add it.
I don't know the work privial. Did you mean trivial? s/add/adds/
Other than that:
Fixes: 9f15a4a0adc9 ("iio: dac: ltc2632: add support for LTC2636 family")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8
2020-04-14 23:56 ` [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
@ 2020-04-15 7:00 ` Uwe Kleine-König
2020-04-15 8:51 ` Chris Ruehl
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2020-04-15 7:00 UTC (permalink / raw)
To: Chris Ruehl
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Alexandru Ardelean,
Alexandru Tachici, Greg Kroah-Hartman, Thomas Gleixner,
Stefan Popa, Allison Randal, Alexios Zavras, linux-iio,
linux-kernel
On Wed, Apr 15, 2020 at 07:56:03AM +0800, Chris Ruehl wrote:
> This patch add support for Analog Devices (Linear Technology)
> LTC2634 Quad 12-/10-/8-Bit Rail-to-Rail DAC.
> The SPI functionality based on them from LTC2632 therefor
> add the definitions only and update the Kconfig.
>
> V2:
> Send the documentation fix in a extra patch
> Kconfig simplify the driver description, details to the help text
> ltc2632.txt add to this patch-set (prepare to convert to yaml)
>
> V3:
> Consistens decimal separator in help text
The description about how the patch evolves usually goes below the ---
and S-o-b area. This way it doesn't make it into the commit history.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> .../devicetree/bindings/iio/dac/ltc2632.txt | 8 ++-
> drivers/iio/dac/Kconfig | 6 +-
> drivers/iio/dac/ltc2632.c | 60 +++++++++++++++++++
> 3 files changed, 70 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> index 338c3220f01a..1ab9570cf219 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> @@ -1,4 +1,4 @@
> -Linear Technology LTC2632/2636 DAC
> +Linear Technology LTC2632/2634/2636 DAC
>
> Required properties:
> - compatible: Has to contain one of the following:
> @@ -8,6 +8,12 @@ Required properties:
> lltc,ltc2632-h12
> lltc,ltc2632-h10
> lltc,ltc2632-h8
> + lltc,ltc2634-l12
> + lltc,ltc2634-l10
> + lltc,ltc2634-l8
> + lltc,ltc2634-h12
> + lltc,ltc2634-h10
> + lltc,ltc2634-h8
> lltc,ltc2636-l12
> lltc,ltc2636-l10
> lltc,ltc2636-l8
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 93744011b63f..aee13ced6ddf 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -279,12 +279,12 @@ config LTC1660
> module will be called ltc1660.
>
> config LTC2632
> - tristate "Linear Technology LTC2632-12/10/8 and LTC2636-12/10/8 DAC spi driver"
> + tristate "Linear Technology LTC2632-12/10/8 and similar DAC spi driver"
> depends on SPI
> help
> Say yes here to build support for Linear Technology
> - LTC2632-12, LTC2632-10, LTC2632-8, LTC2636-12, LTC2636-10 and
> - LTC2636-8 converters (DAC).
> + LTC2632, LTC2634 and LTC2636 DAC resolution 12/10/8 bit
> + low 0-2.5V and high 0-4.096V range converters.
>
The naming pattern seems to be:
LTC263ab-cc
with:
a = 2 -> 2 channels
a = 4 -> 4 channels
a = 6 -> 8 channels
b = L -> Vref = 2.5V
b = H -> Vref = 4.096V
cc = 8 -> 8 bit precision
cc = 10 -> 10 bit precision
cc = 12 -> 12 bit precision
Would it make sense to document this somewhere?
But as this is (somewhat) orthogonal to this patch:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8
2020-04-15 7:00 ` Uwe Kleine-König
@ 2020-04-15 8:51 ` Chris Ruehl
0 siblings, 0 replies; 7+ messages in thread
From: Chris Ruehl @ 2020-04-15 8:51 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: devicetree, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Alexandru Ardelean,
Alexandru Tachici, Greg Kroah-Hartman, Thomas Gleixner,
Stefan Popa, Allison Randal, Alexios Zavras, linux-iio,
linux-kernel
Uwe,
On 15/4/2020 3:00 pm, Uwe Kleine-König wrote:
> On Wed, Apr 15, 2020 at 07:56:03AM +0800, Chris Ruehl wrote:
>> This patch add support for Analog Devices (Linear Technology)
>> LTC2634 Quad 12-/10-/8-Bit Rail-to-Rail DAC.
>> The SPI functionality based on them from LTC2632 therefor
>> add the definitions only and update the Kconfig.
>>
>> V2:
>> Send the documentation fix in a extra patch
>> Kconfig simplify the driver description, details to the help text
>> ltc2632.txt add to this patch-set (prepare to convert to yaml)
>>
>> V3:
>> Consistens decimal separator in help text
>
> The description about how the patch evolves usually goes below the ---
> and S-o-b area. This way it doesn't make it into the commit history.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>> ---
>> .../devicetree/bindings/iio/dac/ltc2632.txt | 8 ++-
>> drivers/iio/dac/Kconfig | 6 +-
>> drivers/iio/dac/ltc2632.c | 60 +++++++++++++++++++
>> 3 files changed, 70 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> index 338c3220f01a..1ab9570cf219 100644
>> --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> @@ -1,4 +1,4 @@
>> -Linear Technology LTC2632/2636 DAC
>> +Linear Technology LTC2632/2634/2636 DAC
>>
>> Required properties:
>> - compatible: Has to contain one of the following:
>> @@ -8,6 +8,12 @@ Required properties:
>> lltc,ltc2632-h12
>> lltc,ltc2632-h10
>> lltc,ltc2632-h8
>> + lltc,ltc2634-l12
>> + lltc,ltc2634-l10
>> + lltc,ltc2634-l8
>> + lltc,ltc2634-h12
>> + lltc,ltc2634-h10
>> + lltc,ltc2634-h8
>> lltc,ltc2636-l12
>> lltc,ltc2636-l10
>> lltc,ltc2636-l8
>> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
>> index 93744011b63f..aee13ced6ddf 100644
>> --- a/drivers/iio/dac/Kconfig
>> +++ b/drivers/iio/dac/Kconfig
>> @@ -279,12 +279,12 @@ config LTC1660
>> module will be called ltc1660.
>>
>> config LTC2632
>> - tristate "Linear Technology LTC2632-12/10/8 and LTC2636-12/10/8 DAC spi driver"
>> + tristate "Linear Technology LTC2632-12/10/8 and similar DAC spi driver"
>> depends on SPI
>> help
>> Say yes here to build support for Linear Technology
>> - LTC2632-12, LTC2632-10, LTC2632-8, LTC2636-12, LTC2636-10 and
>> - LTC2636-8 converters (DAC).
>> + LTC2632, LTC2634 and LTC2636 DAC resolution 12/10/8 bit
>> + low 0-2.5V and high 0-4.096V range converters.
>>
>
> The naming pattern seems to be:
>
> LTC263ab-cc
>
> with:
>
> a = 2 -> 2 channels
> a = 4 -> 4 channels
> a = 6 -> 8 channels
>
> b = L -> Vref = 2.5V
> b = H -> Vref = 4.096V
>
> cc = 8 -> 8 bit precision
> cc = 10 -> 10 bit precision
> cc = 12 -> 12 bit precision
>
> Would it make sense to document this somewhere?
>
> But as this is (somewhat) orthogonal to this patch:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Best regards
> Uwe
>
General I think that is a good solution to be precise in the description.
Update the device-tree lltc,ltc2632.yaml with this kind of
information, its logically the better place - IMHO
Kind regards
Chris
--
GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521
Disclaimer: https://www.gtsys.com.hk/email/classified.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-15 8:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 23:56 [PATCH v3] iio: patch set ltc2632 Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
2020-04-15 6:53 ` Uwe Kleine-König
2020-04-14 23:56 ` [PATCH v3 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
2020-04-15 7:00 ` Uwe Kleine-König
2020-04-15 8:51 ` Chris Ruehl
2020-04-14 23:56 ` [PATCH v3 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml Chris Ruehl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).