* [PATCH] scsi: qedi: make qedi_ll2_buf_size static
@ 2020-04-15 8:50 Jason Yan
2020-04-17 21:32 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-15 8:50 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following sparse warning:
drivers/scsi/qedi/qedi_main.c:44:6: warning: symbol 'qedi_ll2_buf_size'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/qedi/qedi_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index b9a5c842a76e..4dd965860c98 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -45,7 +45,7 @@ module_param(qedi_io_tracing, uint, 0644);
MODULE_PARM_DESC(qedi_io_tracing,
" Enable logging of SCSI requests/completions into trace buffer. (default off).");
-uint qedi_ll2_buf_size = 0x400;
+static uint qedi_ll2_buf_size = 0x400;
module_param(qedi_ll2_buf_size, uint, 0644);
MODULE_PARM_DESC(qedi_ll2_buf_size,
"parameter to set ping packet size, default - 0x400, Jumbo packets - 0x2400.");
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qedi: make qedi_ll2_buf_size static
2020-04-15 8:50 [PATCH] scsi: qedi: make qedi_ll2_buf_size static Jason Yan
@ 2020-04-17 21:32 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-04-17 21:32 UTC (permalink / raw)
To: Jason Yan
Cc: QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Hulk Robot
Jason,
> Fix the following sparse warning:
>
> drivers/scsi/qedi/qedi_main.c:44:6: warning: symbol 'qedi_ll2_buf_size'
> was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:50 [PATCH] scsi: qedi: make qedi_ll2_buf_size static Jason Yan
2020-04-17 21:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).