* [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro
@ 2020-04-15 10:10 Lars Engebretsen
2020-04-15 11:41 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: Lars Engebretsen @ 2020-04-15 10:10 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23, Lars Engebretsen
This change removes the semi-colon from the devm_iio_device_register()
macro which seems to have been added by accident via commit 63b19547cc3d9
("iio: Use macro magic to avoid manual assign of driver_module").
Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
---
Changelog v1 -> v2:
* added commit change description
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index d63884a54939..76ba7c9fd3e0 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
* 0 on success, negative error number on failure.
*/
#define devm_iio_device_register(dev, indio_dev) \
- __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
+ __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
struct module *this_mod);
int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro
2020-04-15 10:10 [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
@ 2020-04-15 11:41 ` Ardelean, Alexandru
2020-04-18 16:13 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2020-04-15 11:41 UTC (permalink / raw)
To: lars, linux-kernel, linux-iio; +Cc: jic23
On Wed, 2020-04-15 at 12:10 +0200, Lars Engebretsen wrote:
> This change removes the semi-colon from the devm_iio_device_register()
> macro which seems to have been added by accident via commit 63b19547cc3d9
> ("iio: Use macro magic to avoid manual assign of driver_module").
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> ---
> Changelog v1 -> v2:
> * added commit change description
>
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index d63884a54939..76ba7c9fd3e0 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> * 0 on success, negative error number on failure.
> */
> #define devm_iio_device_register(dev, indio_dev) \
> - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> struct module *this_mod);
> int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro
2020-04-15 11:41 ` Ardelean, Alexandru
@ 2020-04-18 16:13 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-04-18 16:13 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: lars, linux-kernel, linux-iio
On Wed, 15 Apr 2020 11:41:24 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Wed, 2020-04-15 at 12:10 +0200, Lars Engebretsen wrote:
> > This change removes the semi-colon from the devm_iio_device_register()
> > macro which seems to have been added by accident via commit 63b19547cc3d9
> > ("iio: Use macro magic to avoid manual assign of driver_module").
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
The above reference to where the bug was introduced should have been
a Fixes: tag as that guides where this is backported to.
I made it so whilst applying.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> > ---
> > Changelog v1 -> v2:
> > * added commit change description
> >
> > include/linux/iio/iio.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index d63884a54939..76ba7c9fd3e0 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> > * 0 on success, negative error number on failure.
> > */
> > #define devm_iio_device_register(dev, indio_dev) \
> > - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> > + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> > int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> > struct module *this_mod);
> > int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-18 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 10:10 [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
2020-04-15 11:41 ` Ardelean, Alexandru
2020-04-18 16:13 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).