From: Wolfram Sang <wsa@the-dreams.de>
To: Alain Volmat <alain.volmat@st.com>
Cc: pierre-yves.mordret@st.com, alexandre.torgue@st.com,
linux-i2c@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@st.com
Subject: Re: [PATCH] i2c: stm32: don't print an error on probe deferral
Date: Wed, 15 Apr 2020 13:01:45 +0200 [thread overview]
Message-ID: <20200415110145.GN1141@ninjato> (raw)
In-Reply-To: <1584642136-15418-1-git-send-email-alain.volmat@st.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
> if (IS_ERR(dma->chan_tx)) {
> - dev_dbg(dev, "can't request DMA tx channel\n");
> ret = PTR_ERR(dma->chan_tx);
> + if (ret != -EPROBE_DEFER)
> + dev_dbg(dev, "can't request DMA tx channel\n");
dev_dbg for tx...
> goto fail_al;
> }
>
> @@ -44,8 +45,10 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C RX dma channel */
> dma->chan_rx = dma_request_chan(dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> - dev_err(dev, "can't request DMA rx channel\n");
> ret = PTR_ERR(dma->chan_rx);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "can't request DMA rx channel\n");
... and dev_err for rx? Intentional?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-15 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:22 [PATCH] i2c: stm32: don't print an error on probe deferral Alain Volmat
2020-03-30 8:40 ` Pierre Yves MORDRET
2020-04-15 11:01 ` Wolfram Sang [this message]
2020-04-20 15:11 ` Alain Volmat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415110145.GN1141@ninjato \
--to=wsa@the-dreams.de \
--cc=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pierre-yves.mordret@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).