From: Alain Volmat <alain.volmat@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: <pierre-yves.mordret@st.com>, <alexandre.torgue@st.com>,
<linux-i2c@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <fabrice.gasnier@st.com>
Subject: Re: [PATCH] i2c: stm32: don't print an error on probe deferral
Date: Mon, 20 Apr 2020 17:11:52 +0200 [thread overview]
Message-ID: <20200420151152.GA10855@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20200415110145.GN1141@ninjato>
Hi Wolfram,
On Wed, Apr 15, 2020 at 01:01:45PM +0200, Wolfram Sang wrote:
> > if (IS_ERR(dma->chan_tx)) {
> > - dev_dbg(dev, "can't request DMA tx channel\n");
> > ret = PTR_ERR(dma->chan_tx);
> > + if (ret != -EPROBE_DEFER)
> > + dev_dbg(dev, "can't request DMA tx channel\n");
>
> dev_dbg for tx...
Intention was to not change too much the original code when introducing this
check and fixing this message level in another patch. But I guess indeed this
can be done all at once.
I am pushing a v2 fixing this in this patch and having dev_err for both tx & rx
dma requests.
>
> > goto fail_al;
> > }
> >
> > @@ -44,8 +45,10 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> > /* Request and configure I2C RX dma channel */
> > dma->chan_rx = dma_request_chan(dev, "rx");
> > if (IS_ERR(dma->chan_rx)) {
> > - dev_err(dev, "can't request DMA rx channel\n");
> > ret = PTR_ERR(dma->chan_rx);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(dev, "can't request DMA rx channel\n");
>
> ... and dev_err for rx? Intentional?
>
prev parent reply other threads:[~2020-04-20 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:22 [PATCH] i2c: stm32: don't print an error on probe deferral Alain Volmat
2020-03-30 8:40 ` Pierre Yves MORDRET
2020-04-15 11:01 ` Wolfram Sang
2020-04-20 15:11 ` Alain Volmat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420151152.GA10855@gnbcxd0016.gnb.st.com \
--to=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pierre-yves.mordret@st.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).