* [PATCH -next] kcsan: Use GFP_ATOMIC under spin lock
@ 2020-04-17 2:58 Wei Yongjun
2020-04-17 9:23 ` Marco Elver
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2020-04-17 2:58 UTC (permalink / raw)
To: Marco Elver, Dmitry Vyukov
Cc: Wei Yongjun, kasan-dev, linux-kernel, kernel-janitors
A spin lock is taken here so we should use GFP_ATOMIC.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
kernel/kcsan/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
index 1a08664a7fab..023e49c58d55 100644
--- a/kernel/kcsan/debugfs.c
+++ b/kernel/kcsan/debugfs.c
@@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)
/* initial allocation */
report_filterlist.addrs =
kmalloc_array(report_filterlist.size,
- sizeof(unsigned long), GFP_KERNEL);
+ sizeof(unsigned long), GFP_ATOMIC);
if (report_filterlist.addrs == NULL) {
ret = -ENOMEM;
goto out;
@@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)
size_t new_size = report_filterlist.size * 2;
unsigned long *new_addrs =
krealloc(report_filterlist.addrs,
- new_size * sizeof(unsigned long), GFP_KERNEL);
+ new_size * sizeof(unsigned long), GFP_ATOMIC);
if (new_addrs == NULL) {
/* leave filterlist itself untouched */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] kcsan: Use GFP_ATOMIC under spin lock
2020-04-17 2:58 [PATCH -next] kcsan: Use GFP_ATOMIC under spin lock Wei Yongjun
@ 2020-04-17 9:23 ` Marco Elver
2020-04-17 15:03 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Marco Elver @ 2020-04-17 9:23 UTC (permalink / raw)
To: Wei Yongjun, Paul E. McKenney
Cc: Dmitry Vyukov, kasan-dev, LKML, kernel-janitors
On Fri, 17 Apr 2020 at 04:56, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Good catch, thank you!
Reviewed-by: Marco Elver <elver@google.com>
> ---
> kernel/kcsan/debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
> index 1a08664a7fab..023e49c58d55 100644
> --- a/kernel/kcsan/debugfs.c
> +++ b/kernel/kcsan/debugfs.c
> @@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)
> /* initial allocation */
> report_filterlist.addrs =
> kmalloc_array(report_filterlist.size,
> - sizeof(unsigned long), GFP_KERNEL);
> + sizeof(unsigned long), GFP_ATOMIC);
> if (report_filterlist.addrs == NULL) {
> ret = -ENOMEM;
> goto out;
> @@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)
> size_t new_size = report_filterlist.size * 2;
> unsigned long *new_addrs =
> krealloc(report_filterlist.addrs,
> - new_size * sizeof(unsigned long), GFP_KERNEL);
> + new_size * sizeof(unsigned long), GFP_ATOMIC);
>
> if (new_addrs == NULL) {
> /* leave filterlist itself untouched */
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] kcsan: Use GFP_ATOMIC under spin lock
2020-04-17 9:23 ` Marco Elver
@ 2020-04-17 15:03 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2020-04-17 15:03 UTC (permalink / raw)
To: Marco Elver; +Cc: Wei Yongjun, Dmitry Vyukov, kasan-dev, LKML, kernel-janitors
On Fri, Apr 17, 2020 at 11:23:05AM +0200, Marco Elver wrote:
> On Fri, 17 Apr 2020 at 04:56, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> >
> > A spin lock is taken here so we should use GFP_ATOMIC.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Good catch, thank you!
>
> Reviewed-by: Marco Elver <elver@google.com>
Queued and pushed, thank you both!
Thanx, Paul
> > ---
> > kernel/kcsan/debugfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
> > index 1a08664a7fab..023e49c58d55 100644
> > --- a/kernel/kcsan/debugfs.c
> > +++ b/kernel/kcsan/debugfs.c
> > @@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)
> > /* initial allocation */
> > report_filterlist.addrs =
> > kmalloc_array(report_filterlist.size,
> > - sizeof(unsigned long), GFP_KERNEL);
> > + sizeof(unsigned long), GFP_ATOMIC);
> > if (report_filterlist.addrs == NULL) {
> > ret = -ENOMEM;
> > goto out;
> > @@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)
> > size_t new_size = report_filterlist.size * 2;
> > unsigned long *new_addrs =
> > krealloc(report_filterlist.addrs,
> > - new_size * sizeof(unsigned long), GFP_KERNEL);
> > + new_size * sizeof(unsigned long), GFP_ATOMIC);
> >
> > if (new_addrs == NULL) {
> > /* leave filterlist itself untouched */
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-17 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 2:58 [PATCH -next] kcsan: Use GFP_ATOMIC under spin lock Wei Yongjun
2020-04-17 9:23 ` Marco Elver
2020-04-17 15:03 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).