* [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins'
@ 2020-04-17 7:34 Jason Yan
2020-04-28 9:41 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-17 7:34 UTC (permalink / raw)
To: linus.walleij, linux-arm-kernel, linux-gpio, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following gcc warning:
drivers/pinctrl/nomadik/pinctrl-ab8505.c:137:23: warning:
‘gpio50_a_1_pins’ defined but not used [-Wunused-const-variable=]
static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
^~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/pinctrl/nomadik/pinctrl-ab8505.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-ab8505.c b/drivers/pinctrl/nomadik/pinctrl-ab8505.c
index 5e6e7d28390a..ed23f1274709 100644
--- a/drivers/pinctrl/nomadik/pinctrl-ab8505.c
+++ b/drivers/pinctrl/nomadik/pinctrl-ab8505.c
@@ -134,7 +134,6 @@ static const unsigned gpio34_a_1_pins[] = { AB8505_PIN_H14 };
static const unsigned gpio40_a_1_pins[] = { AB8505_PIN_J15 };
static const unsigned gpio41_a_1_pins[] = { AB8505_PIN_J14 };
static const unsigned uartrxdata_a_1_pins[] = { AB8505_PIN_J14 };
-static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
static const unsigned gpio52_a_1_pins[] = { AB8505_PIN_D16 };
static const unsigned gpio53_a_1_pins[] = { AB8505_PIN_D15 };
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins'
2020-04-17 7:34 [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins' Jason Yan
@ 2020-04-28 9:41 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-04-28 9:41 UTC (permalink / raw)
To: Jason Yan, Patrice CHOTARD
Cc: Linux ARM, open list:GPIO SUBSYSTEM, linux-kernel, Hulk Robot
On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-ab8505.c:137:23: warning:
> ‘gpio50_a_1_pins’ defined but not used [-Wunused-const-variable=]
> static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
> ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
This should not be deleted, it should be used. I will send an alternative
patch with you as Reported-by.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 7:34 [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins' Jason Yan
2020-04-28 9:41 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).