* [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'
@ 2020-04-17 10:10 YueHaibing
2020-04-17 15:24 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-04-17 10:10 UTC (permalink / raw)
To: patrik.r.jakobsson, airlied, daniel; +Cc: dri-devel, linux-kernel, YueHaibing
drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]
static const struct pci_device_id hdmi_ids[] = {
^~~~~~~~
It is never used, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
index b25086f252ae..a097a59a9eae 100644
--- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
+++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
@@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
kfree(gma_encoder);
}
-static const struct pci_device_id hdmi_ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
- { 0 }
-};
-
void oaktrail_hdmi_setup(struct drm_device *dev)
{
struct drm_psb_private *dev_priv = dev->dev_private;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'
2020-04-17 10:10 [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids' YueHaibing
@ 2020-04-17 15:24 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-04-17 15:24 UTC (permalink / raw)
To: YueHaibing; +Cc: patrik.r.jakobsson, airlied, daniel, dri-devel, linux-kernel
On Fri, Apr 17, 2020 at 06:10:32PM +0800, YueHaibing wrote:
> drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]
> static const struct pci_device_id hdmi_ids[] = {
> ^~~~~~~~
>
> It is never used, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Queued for 5.8, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index b25086f252ae..a097a59a9eae 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
> kfree(gma_encoder);
> }
>
> -static const struct pci_device_id hdmi_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
> - { 0 }
> -};
> -
> void oaktrail_hdmi_setup(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv = dev->dev_private;
> --
> 2.17.1
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 10:10 [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids' YueHaibing
2020-04-17 15:24 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).