linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates'
@ 2020-04-17 10:12 YueHaibing
  2020-04-17 13:59 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-04-17 10:12 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	David1.Zhou, airlied, daniel
  Cc: amd-gfx, dri-devel, linux-kernel, YueHaibing

drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1017:50:
 warning: ‘video_optimized_pixel_rates’ defined but not used [-Wunused-const-variable=]
 static const struct pixel_rate_range_table_entry video_optimized_pixel_rates[] = {
                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~

commit d8cd587d2bfd ("drm/amd/display: removing MODULO change for dcn2")
left behind this unused vairable, remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 .../drm/amd/display/dc/dce/dce_clock_source.c | 33 -------------------
 1 file changed, 33 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
index 2e992fbc0d71..d2ad0504b0de 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
@@ -1014,39 +1014,6 @@ struct pixel_rate_range_table_entry {
 	unsigned short div_factor;
 };
 
-static const struct pixel_rate_range_table_entry video_optimized_pixel_rates[] = {
-	// /1.001 rates
-	{25170, 25180, 25200, 1000, 1001},	//25.2MHz   ->   25.17
-	{59340, 59350, 59400, 1000, 1001},	//59.4Mhz   ->   59.340
-	{74170, 74180, 74250, 1000, 1001},	//74.25Mhz  ->   74.1758
-	{125870, 125880, 126000, 1000, 1001},	//126Mhz    ->  125.87
-	{148350, 148360, 148500, 1000, 1001},	//148.5Mhz  ->  148.3516
-	{167830, 167840, 168000, 1000, 1001},	//168Mhz    ->  167.83
-	{222520, 222530, 222750, 1000, 1001},	//222.75Mhz ->  222.527
-	{257140, 257150, 257400, 1000, 1001},	//257.4Mhz  ->  257.1429
-	{296700, 296710, 297000, 1000, 1001},	//297Mhz    ->  296.7033
-	{342850, 342860, 343200, 1000, 1001},	//343.2Mhz  ->  342.857
-	{395600, 395610, 396000, 1000, 1001},	//396Mhz    ->  395.6
-	{409090, 409100, 409500, 1000, 1001},	//409.5Mhz  ->  409.091
-	{445050, 445060, 445500, 1000, 1001},	//445.5Mhz  ->  445.055
-	{467530, 467540, 468000, 1000, 1001},	//468Mhz    ->  467.5325
-	{519230, 519240, 519750, 1000, 1001},	//519.75Mhz ->  519.231
-	{525970, 525980, 526500, 1000, 1001},	//526.5Mhz  ->  525.974
-	{545450, 545460, 546000, 1000, 1001},	//546Mhz    ->  545.455
-	{593400, 593410, 594000, 1000, 1001},	//594Mhz    ->  593.4066
-	{623370, 623380, 624000, 1000, 1001},	//624Mhz    ->  623.377
-	{692300, 692310, 693000, 1000, 1001},	//693Mhz    ->  692.308
-	{701290, 701300, 702000, 1000, 1001},	//702Mhz    ->  701.2987
-	{791200, 791210, 792000, 1000, 1001},	//792Mhz    ->  791.209
-	{890100, 890110, 891000, 1000, 1001},	//891Mhz    ->  890.1099
-	{1186810, 1186820, 1188000, 1000, 1001},//1188Mhz   -> 1186.8131
-
-	// *1.001 rates
-	{27020, 27030, 27000, 1001, 1000}, //27Mhz
-	{54050, 54060, 54000, 1001, 1000}, //54Mhz
-	{108100, 108110, 108000, 1001, 1000},//108Mhz
-};
-
 static bool dcn20_program_pix_clk(
 		struct clock_source *clock_source,
 		struct pixel_clk_params *pix_clk_params,
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates'
  2020-04-17 10:12 [PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates' YueHaibing
@ 2020-04-17 13:59 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-04-17 13:59 UTC (permalink / raw)
  To: YueHaibing
  Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
	Christian Koenig, Chunming Zhou, Dave Airlie, Daniel Vetter,
	Maling list - DRI developers, amd-gfx list, LKML

On Fri, Apr 17, 2020 at 9:16 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1017:50:
>  warning: ‘video_optimized_pixel_rates’ defined but not used [-Wunused-const-variable=]
>  static const struct pixel_rate_range_table_entry video_optimized_pixel_rates[] = {
>                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> commit d8cd587d2bfd ("drm/amd/display: removing MODULO change for dcn2")
> left behind this unused vairable, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.  Thanks!

Alex

> ---
>  .../drm/amd/display/dc/dce/dce_clock_source.c | 33 -------------------
>  1 file changed, 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> index 2e992fbc0d71..d2ad0504b0de 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> @@ -1014,39 +1014,6 @@ struct pixel_rate_range_table_entry {
>         unsigned short div_factor;
>  };
>
> -static const struct pixel_rate_range_table_entry video_optimized_pixel_rates[] = {
> -       // /1.001 rates
> -       {25170, 25180, 25200, 1000, 1001},      //25.2MHz   ->   25.17
> -       {59340, 59350, 59400, 1000, 1001},      //59.4Mhz   ->   59.340
> -       {74170, 74180, 74250, 1000, 1001},      //74.25Mhz  ->   74.1758
> -       {125870, 125880, 126000, 1000, 1001},   //126Mhz    ->  125.87
> -       {148350, 148360, 148500, 1000, 1001},   //148.5Mhz  ->  148.3516
> -       {167830, 167840, 168000, 1000, 1001},   //168Mhz    ->  167.83
> -       {222520, 222530, 222750, 1000, 1001},   //222.75Mhz ->  222.527
> -       {257140, 257150, 257400, 1000, 1001},   //257.4Mhz  ->  257.1429
> -       {296700, 296710, 297000, 1000, 1001},   //297Mhz    ->  296.7033
> -       {342850, 342860, 343200, 1000, 1001},   //343.2Mhz  ->  342.857
> -       {395600, 395610, 396000, 1000, 1001},   //396Mhz    ->  395.6
> -       {409090, 409100, 409500, 1000, 1001},   //409.5Mhz  ->  409.091
> -       {445050, 445060, 445500, 1000, 1001},   //445.5Mhz  ->  445.055
> -       {467530, 467540, 468000, 1000, 1001},   //468Mhz    ->  467.5325
> -       {519230, 519240, 519750, 1000, 1001},   //519.75Mhz ->  519.231
> -       {525970, 525980, 526500, 1000, 1001},   //526.5Mhz  ->  525.974
> -       {545450, 545460, 546000, 1000, 1001},   //546Mhz    ->  545.455
> -       {593400, 593410, 594000, 1000, 1001},   //594Mhz    ->  593.4066
> -       {623370, 623380, 624000, 1000, 1001},   //624Mhz    ->  623.377
> -       {692300, 692310, 693000, 1000, 1001},   //693Mhz    ->  692.308
> -       {701290, 701300, 702000, 1000, 1001},   //702Mhz    ->  701.2987
> -       {791200, 791210, 792000, 1000, 1001},   //792Mhz    ->  791.209
> -       {890100, 890110, 891000, 1000, 1001},   //891Mhz    ->  890.1099
> -       {1186810, 1186820, 1188000, 1000, 1001},//1188Mhz   -> 1186.8131
> -
> -       // *1.001 rates
> -       {27020, 27030, 27000, 1001, 1000}, //27Mhz
> -       {54050, 54060, 54000, 1001, 1000}, //54Mhz
> -       {108100, 108110, 108000, 1001, 1000},//108Mhz
> -};
> -
>  static bool dcn20_program_pix_clk(
>                 struct clock_source *clock_source,
>                 struct pixel_clk_params *pix_clk_params,
> --
> 2.17.1
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-17 13:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 10:12 [PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates' YueHaibing
2020-04-17 13:59 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).