* [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret'
@ 2020-04-18 7:06 Jason Yan
2020-04-18 7:13 ` Bjorn Andersson
2020-04-22 4:06 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-18 7:06 UTC (permalink / raw)
To: agross, bjorn.andersson, alim.akhtar, avri.altman, jejb,
martin.petersen, p.zabel, cang, linux-arm-msm, linux-scsi,
linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following coccicheck warning:
drivers/scsi/ufs/ufs-qcom.c:575:5-8: Unneeded variable: "ret". Return
"0" on line 590
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/ufs/ufs-qcom.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 19aa5c44e0da..701e9184adff 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -572,7 +572,6 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
{
struct ufs_qcom_host *host = ufshcd_get_variant(hba);
struct phy *phy = host->generic_phy;
- int ret = 0;
if (ufs_qcom_is_link_off(hba)) {
/*
@@ -587,7 +586,7 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
ufs_qcom_disable_lane_clks(host);
}
- return ret;
+ return 0;
}
static int ufs_qcom_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret'
2020-04-18 7:06 [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret' Jason Yan
@ 2020-04-18 7:13 ` Bjorn Andersson
2020-04-22 4:06 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-04-18 7:13 UTC (permalink / raw)
To: Jason Yan
Cc: agross, alim.akhtar, avri.altman, jejb, martin.petersen, p.zabel,
cang, linux-arm-msm, linux-scsi, linux-kernel, Hulk Robot
On Sat 18 Apr 00:06 PDT 2020, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/ufs/ufs-qcom.c:575:5-8: Unneeded variable: "ret". Return
> "0" on line 590
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 19aa5c44e0da..701e9184adff 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -572,7 +572,6 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> {
> struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> struct phy *phy = host->generic_phy;
> - int ret = 0;
>
> if (ufs_qcom_is_link_off(hba)) {
> /*
> @@ -587,7 +586,7 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> ufs_qcom_disable_lane_clks(host);
> }
>
> - return ret;
> + return 0;
> }
>
> static int ufs_qcom_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret'
2020-04-18 7:06 [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret' Jason Yan
2020-04-18 7:13 ` Bjorn Andersson
@ 2020-04-22 4:06 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-04-22 4:06 UTC (permalink / raw)
To: Jason Yan
Cc: agross, bjorn.andersson, alim.akhtar, avri.altman, jejb,
martin.petersen, p.zabel, cang, linux-arm-msm, linux-scsi,
linux-kernel, Hulk Robot
Jason,
> Fix the following coccicheck warning:
>
> drivers/scsi/ufs/ufs-qcom.c:575:5-8: Unneeded variable: "ret". Return
> "0" on line 590
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 4:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 7:06 [PATCH] scsi: ufs-qcom: remove unneeded variable 'ret' Jason Yan
2020-04-18 7:13 ` Bjorn Andersson
2020-04-22 4:06 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).