* [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static
@ 2020-04-18 1:51 YueHaibing
2020-04-18 3:25 ` Richard Cochran
2020-04-20 18:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-04-18 1:51 UTC (permalink / raw)
To: richardcochran, davem; +Cc: pbonzini, netdev, linux-kernel, YueHaibing
Fix sparse warning:
drivers/ptp/ptp_kvm.c:25:1: warning:
symbol 'kvm_ptp_lock' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/ptp/ptp_kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_kvm.c b/drivers/ptp/ptp_kvm.c
index fc7d0b77e118..658d33fc3195 100644
--- a/drivers/ptp/ptp_kvm.c
+++ b/drivers/ptp/ptp_kvm.c
@@ -22,7 +22,7 @@ struct kvm_ptp_clock {
struct ptp_clock_info caps;
};
-DEFINE_SPINLOCK(kvm_ptp_lock);
+static DEFINE_SPINLOCK(kvm_ptp_lock);
static struct pvclock_vsyscall_time_info *hv_clock;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static
2020-04-18 1:51 [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static YueHaibing
@ 2020-04-18 3:25 ` Richard Cochran
2020-04-20 18:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2020-04-18 3:25 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, pbonzini, netdev, linux-kernel
On Sat, Apr 18, 2020 at 09:51:54AM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/ptp/ptp_kvm.c:25:1: warning:
> symbol 'kvm_ptp_lock' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static
2020-04-18 1:51 [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static YueHaibing
2020-04-18 3:25 ` Richard Cochran
@ 2020-04-20 18:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-20 18:04 UTC (permalink / raw)
To: yuehaibing; +Cc: richardcochran, pbonzini, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 18 Apr 2020 09:51:54 +0800
> Fix sparse warning:
>
> drivers/ptp/ptp_kvm.c:25:1: warning:
> symbol 'kvm_ptp_lock' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 1:51 [PATCH net-next] ptp_kvm: Make kvm_ptp_lock static YueHaibing
2020-04-18 3:25 ` Richard Cochran
2020-04-20 18:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).