* [PATCH] arm64: dts: allwinner: sun50i-a64: Add missing address/size-cells
@ 2020-04-20 10:31 Ondrej Jirman
2020-04-20 13:27 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Jirman @ 2020-04-20 10:31 UTC (permalink / raw)
To: linux-sunxi
Cc: Ondrej Jirman, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
The binding specifies #address-cells and #size-cells should be present.
Without them present, dtc issues a warning because default for
#address-cells seems to be <2>:
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi:1108.4-52:
Warning (dma_ranges_format):
/soc/dram-controller@1c62000:dma-ranges:
"dma-ranges" property has invalid length (12 bytes)
(parent #address-cells == 1, child #address-cells == 2,
#size-cells == 1)
mbus #address-cells should be 1.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index cca4261089aa..61698094f450 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -1105,6 +1105,8 @@ mbus: dram-controller@1c62000 {
compatible = "allwinner,sun50i-a64-mbus";
reg = <0x01c62000 0x1000>;
clocks = <&ccu 112>;
+ #address-cells = <1>;
+ #size-cells = <1>;
dma-ranges = <0x00000000 0x40000000 0xc0000000>;
#interconnect-cells = <1>;
};
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: sun50i-a64: Add missing address/size-cells
2020-04-20 10:31 [PATCH] arm64: dts: allwinner: sun50i-a64: Add missing address/size-cells Ondrej Jirman
@ 2020-04-20 13:27 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-04-20 13:27 UTC (permalink / raw)
To: Ondrej Jirman
Cc: linux-sunxi, Rob Herring, Chen-Yu Tsai,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Mon, Apr 20, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote:
> The binding specifies #address-cells and #size-cells should be present.
> Without them present, dtc issues a warning because default for
> #address-cells seems to be <2>:
>
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi:1108.4-52:
> Warning (dma_ranges_format):
> /soc/dram-controller@1c62000:dma-ranges:
> "dma-ranges" property has invalid length (12 bytes)
> (parent #address-cells == 1, child #address-cells == 2,
> #size-cells == 1)
>
> mbus #address-cells should be 1.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-20 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 10:31 [PATCH] arm64: dts: allwinner: sun50i-a64: Add missing address/size-cells Ondrej Jirman
2020-04-20 13:27 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).