* [PATCH] irqchip/gic-v3: fix missing "__init" for gic_smp_init()
@ 2020-04-22 11:28 Ingo Rohloff
2020-05-30 7:46 ` [tip: irq/core] irqchip/gic-v3: Fix " tip-bot2 for Ingo Rohloff
0 siblings, 1 reply; 2+ messages in thread
From: Ingo Rohloff @ 2020-04-22 11:28 UTC (permalink / raw)
To: maz; +Cc: linux-kernel, Ingo Rohloff
With an SMP configuration, gic_smp_init() calls set_smp_cross_call().
set_smp_cross_call() is marked with "__init".
So gic_smp_init() should also be marked with "__init".
gic_smp_init() is only called from gic_init_bases().
gic_init_bases() is also marked with "__init";
So marking gic_smp_init() with "__init" is fine.
Signed-off-by: Ingo Rohloff <ingo.rohloff@lauterbach.com>
---
drivers/irqchip/irq-gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index d7006ef18a0d..98c886dab02d 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1150,7 +1150,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
isb();
}
-static void gic_smp_init(void)
+static void __init gic_smp_init(void)
{
set_smp_cross_call(gic_raise_softirq);
cpuhp_setup_state_nocalls(CPUHP_AP_IRQ_GIC_STARTING,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: irq/core] irqchip/gic-v3: Fix missing "__init" for gic_smp_init()
2020-04-22 11:28 [PATCH] irqchip/gic-v3: fix missing "__init" for gic_smp_init() Ingo Rohloff
@ 2020-05-30 7:46 ` tip-bot2 for Ingo Rohloff
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Ingo Rohloff @ 2020-05-30 7:46 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Ingo Rohloff, Marc Zyngier, x86, LKML
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 8a94c1ab34d53476617f83610521cfb6674db8d4
Gitweb: https://git.kernel.org/tip/8a94c1ab34d53476617f83610521cfb6674db8d4
Author: Ingo Rohloff <ingo.rohloff@lauterbach.com>
AuthorDate: Wed, 22 Apr 2020 13:28:57 +02:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 18 May 2020 10:28:30 +01:00
irqchip/gic-v3: Fix missing "__init" for gic_smp_init()
With an SMP configuration, gic_smp_init() calls set_smp_cross_call().
set_smp_cross_call() is marked with "__init".
So gic_smp_init() should also be marked with "__init".
gic_smp_init() is only called from gic_init_bases().
gic_init_bases() is also marked with "__init";
So marking gic_smp_init() with "__init" is fine.
Signed-off-by: Ingo Rohloff <ingo.rohloff@lauterbach.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200422112857.4300-1-ingo.rohloff@lauterbach.com
---
drivers/irqchip/irq-gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index d7006ef..98c886d 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1150,7 +1150,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
isb();
}
-static void gic_smp_init(void)
+static void __init gic_smp_init(void)
{
set_smp_cross_call(gic_raise_softirq);
cpuhp_setup_state_nocalls(CPUHP_AP_IRQ_GIC_STARTING,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-30 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 11:28 [PATCH] irqchip/gic-v3: fix missing "__init" for gic_smp_init() Ingo Rohloff
2020-05-30 7:46 ` [tip: irq/core] irqchip/gic-v3: Fix " tip-bot2 for Ingo Rohloff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).