From: Nathan Chancellor <natechancellor@gmail.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] soundwire: intel: Make sdw_intel_init static
Date: Thu, 23 Apr 2020 11:03:23 -0700 [thread overview]
Message-ID: <20200423180323.GA18440@ubuntu-s3-xlarge-x86> (raw)
In-Reply-To: <20200420071212.GV72691@vkoul-mobl>
On Mon, Apr 20, 2020 at 12:42:12PM +0530, Vinod Koul wrote:
> On 10-04-20, 19:57, YueHaibing wrote:
> > Fix sparse warning:
> >
> > drivers/soundwire/intel_init.c:193:6: warning:
> > symbol 'sdw_intel_init' was not declared. Should it be static?
>
> Applied, thanks
>
> --
> ~Vinod
Why was this applied? It replaces one warning with another (that is
actually visible during a normal kernel build):
$ make -j$(nproc) -s allyesconfig drivers/soundwire/intel_init.o
drivers/soundwire/intel_init.c:193:14: warning: ‘sdw_intel_init’ defined
but not used [-Wunused-function]
static void *sdw_intel_init(acpi_handle *parent_handle,
^~~~~~~~~~~~~~
Cheers,
Nathan
prev parent reply other threads:[~2020-04-23 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 11:57 [PATCH -next] soundwire: intel: Make sdw_intel_init static YueHaibing
2020-04-10 15:25 ` Pierre-Louis Bossart
2020-04-20 7:12 ` Vinod Koul
2020-04-23 18:03 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423180323.GA18440@ubuntu-s3-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).