From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
vkoul@kernel.org, sanyog.r.kale@intel.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] soundwire: intel: Make sdw_intel_init static
Date: Fri, 10 Apr 2020 10:25:43 -0500 [thread overview]
Message-ID: <e58ff419-588b-da7b-2e36-6cf568315c57@linux.intel.com> (raw)
In-Reply-To: <20200410115708.27708-1-yuehaibing@huawei.com>
On 4/10/20 6:57 AM, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/soundwire/intel_init.c:193:6: warning:
> symbol 'sdw_intel_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/soundwire/intel_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index 4b769409f6f8..ad7053463889 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -190,7 +190,8 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
> * This scans the namespace and creates SoundWire link controller devices
> * based on the info queried.
> */
> -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)
> +static void *sdw_intel_init(acpi_handle *parent_handle,
> + struct sdw_intel_res *res)
This declaration has been this way since 2017, there are no users and it
will be removed with the Intel patchsets, so fixing this warning doesn't
really add much value. No sustained objection though.
> {
> acpi_status status;
>
>
next prev parent reply other threads:[~2020-04-13 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 11:57 [PATCH -next] soundwire: intel: Make sdw_intel_init static YueHaibing
2020-04-10 15:25 ` Pierre-Louis Bossart [this message]
2020-04-20 7:12 ` Vinod Koul
2020-04-23 18:03 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e58ff419-588b-da7b-2e36-6cf568315c57@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).