From: Lee Jones <lee.jones@linaro.org>
To: saravanan sekar <sravanhome@gmail.com>
Cc: andy.shevchenko@gmail.com, robh+dt@kernel.org, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
sre@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger
Date: Fri, 24 Apr 2020 10:37:20 +0100 [thread overview]
Message-ID: <20200424093720.GA3542@dell> (raw)
In-Reply-To: <8ff17d07-8030-fcfe-8d8a-3011e4077778@gmail.com>
On Fri, 24 Apr 2020, saravanan sekar wrote:
> Hi Lee,
>
> On 24/04/20 9:18 am, Lee Jones wrote:
> > On Wed, 15 Apr 2020, Saravanan Sekar wrote:
> >
> > > mp2629 is a highly-integrated switching-mode battery charge management
> > > device for single-cell Li-ion or Li-polymer battery.
> > >
> > > Add MFD core enables chip access for ADC driver for battery readings,
> > > and a power supply battery-charger driver
> > >
> > > Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> > > ---
> > > drivers/mfd/Kconfig | 9 ++++
> > > drivers/mfd/Makefile | 2 +
> > > drivers/mfd/mp2629.c | 86 ++++++++++++++++++++++++++++++++++++++
> > > include/linux/mfd/mp2629.h | 19 +++++++++
> > > 4 files changed, 116 insertions(+)
> > > create mode 100644 drivers/mfd/mp2629.c
> > > create mode 100644 include/linux/mfd/mp2629.h
> > How is this driver registered?
> >
> > Looks like it has device tree support. Is there another way?
> Yes, only using device tree
Then how about using 'simple-mfd' and 'syscon'?
Then you can omit this driver completely.
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index 3c547ed575e6..85be799795aa 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -434,6 +434,15 @@ config MFD_MC13XXX_I2C
> > > help
> > > Select this if your MC13xxx is connected via an I2C bus.
> > > +config MFD_MP2629
> > > + tristate "Monolithic power system MP2629 ADC and Battery charger"
> > > + depends on I2C
> > > + select REGMAP_I2C
> > > + help
> > > + Select this option to enable support for monolithic power system
> > > + battery charger. This provides ADC, thermal, battery charger power
> > > + management functions on the systems.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-24 9:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:20 [PATCH v9 0/6] Add battery charger driver support for MP2629 Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 1/6] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-04-16 20:44 ` Rob Herring
2020-04-15 16:20 ` [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-04-24 7:18 ` Lee Jones
2020-04-24 7:26 ` saravanan sekar
2020-04-24 9:37 ` Lee Jones [this message]
2020-04-24 10:23 ` saravanan sekar
2020-04-24 10:53 ` Lee Jones
2020-04-24 11:04 ` saravanan sekar
2020-04-27 8:51 ` Lee Jones
2020-04-27 9:30 ` saravanan sekar
2020-04-30 10:39 ` saravanan sekar
2020-04-30 11:07 ` Andy Shevchenko
2020-04-27 7:26 ` Lee Jones
2020-04-15 16:20 ` [PATCH v9 3/6] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 4/6] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 5/6] power: supply: mp2629: Add impedance compenstation config Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 6/6] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
2020-04-15 16:40 ` [PATCH v9 0/6] Add battery charger driver support for MP2629 Andy Shevchenko
2020-04-15 16:53 ` saravanan sekar
2020-04-15 17:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424093720.GA3542@dell \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).